[Developer Toolbar] Web Console error count is too close to the label (win)

RESOLVED FIXED in Firefox 17

Status

()

Firefox
Developer Tools
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jaws, Assigned: jaws)

Tracking

17 Branch
Firefox 17
All
Windows 7
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Created attachment 645944 [details]
Screenshot of bug

This is on Windows 7. See attachment for screenshot.
Blocks: 764746

Comment 1

5 years ago
Could you take a screenshot where there's no errors?

Updated

5 years ago
Summary: [Developer Toolbar] Web Console error count is too close to the label → [Developer Toolbar] Web Console error count is too close to the label (win & linux)
(In reply to Paul Rouget [:paul] from comment #1)
> Could you take a screenshot where there's no errors?

http://screencast.com/t/rYSutmp2p
Created attachment 646350 [details] [diff] [review]
Patch

I looked at the pinstripe CSS but I'm not sure why it isn't happening on Mac (I didn't try it on Mac though).
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Attachment #646350 - Flags: review?(paul)

Comment 4

5 years ago
Thanks Jared. Can you try to do that for Linux as well?
If not, I'll r+ this and file a new bug.
> Can you try to do that for Linux as well?

What is "that"?

The patch contains the same fix for Linux (although I didn't test it out).

I don't have my Mac with me right now so I can't test out why it previously worked on Mac.
Created attachment 646687 [details] [diff] [review]
Patch v2 (windows only)

This version of the patch only applies to Windows since the measurement isn't exactly correct on Linux.
Attachment #646350 - Attachment is obsolete: true
Attachment #646350 - Flags: review?(paul)
Attachment #646687 - Flags: review?(paul)
Attachment #646687 - Attachment description: Patch v2 → Patch v2 (windows only)
Attachment #646687 - Flags: review?(shorlander)
Comment on attachment 646687 [details] [diff] [review]
Patch v2 (windows only)

Review of attachment 646687 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Jared Wein [:jaws] from comment #3)
> Created attachment 646350 [details] [diff] [review]
> Patch
> 
> I looked at the pinstripe CSS but I'm not sure why it isn't happening on Mac
> (I didn't try it on Mac though).

On Mac the spacing is coming from the margin on the label and not spacing on the icon. Might be nice to make them consistent at some point ;)
Attachment #646687 - Flags: review?(shorlander) → review+
Thanks for the review Stephen. I split out the linux bug to bug 781291.

https://hg.mozilla.org/integration/mozilla-inbound/rev/0f03bcb8d362
Flags: in-testsuite-
Summary: [Developer Toolbar] Web Console error count is too close to the label (win & linux) → [Developer Toolbar] Web Console error count is too close to the label (win)
Target Milestone: --- → Firefox 17
https://hg.mozilla.org/mozilla-central/rev/0f03bcb8d362
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
Attachment #646687 - Flags: review?(paul)
You need to log in before you can comment on or make changes to this bug.