Closed Bug 781291 Opened 13 years ago Closed 13 years ago

[Developer Toolbar] Web Console error count is too close to the label (linux)

Categories

(DevTools :: General, defect)

Product:
DevTools
Component:
General
Version:
17 Branch
Platform:
All
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox17 verified)

Status:
RESOLVED FIXED
Milestone:
Firefox 18
Tracking Flags:
Tracking Status
firefox17 --- verified

People

(Reporter: jaws, Assigned: ananuti)

References

Details

(Whiteboard: [good first bug][mentor=paul][lang=css][fixed-in-fx-team])

Attachments

(3 files, 2 obsolete files)

screenshot: no counter
51.29 KB, image/png
Details
screenshot: counter
43.78 KB, image/png
Details
patch for checkin
918 bytes, patch
ananuti
: review+
lsblakk
: approval-mozilla-aurora+
Details | Diff | Splinter Review
+++ This bug was initially created as a clone of Bug #777569 +++
See Also: → 777569
Whiteboard: [good first bug][mentor=paul][lang=css]
Assignee: nobody → ananuti
Attached patch patch (obsolete) — — Splinter Review
Attachment #651311 - Flags: review?(paul)
Comment on attachment 651311 [details] [diff] [review] patch Apparently, 5px is too much. I'll add some screenshot to show the problem.
Attachment #651311 - Flags: review?(paul)
Attached image screenshot: counter —
As you can see in the screenshots, this moves the command line to the left. The webconsole icon has a margin-right of 2px. Maybe that's enough. See http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/gnomestripe/global/toolbarbutton.css#26 The idea is to perfectly replace the icon.
Attached patch patch1 (obsolete) — — Splinter Review
add a margin right of 2px.
Attachment #651311 - Attachment is obsolete: true
Attachment #651759 - Flags: review?(paul)
Attachment #651759 - Attachment is patch: true
Attachment #651759 - Flags: review?(paul) → review+
Whiteboard: [good first bug][mentor=paul][lang=css] → [good first bug][mentor=paul][lang=css][land-in-fx-team]
Thank you Ekanan.
> Whiteboard: [land-in-fx-team] Paul, I don't see a patch on fx-team http://hg.mozilla.org/integration/fx-team. Are you sure you've pushed to fx-team?
unbitrotted patch. carrying r+ Paul, pls pull from m-c tip before apply a patch.
Attachment #651759 - Attachment is obsolete: true
Attachment #655929 - Flags: review+
(In reply to Ekanan Ketunuti from comment #8) > > Whiteboard: [land-in-fx-team] > > Paul, I don't see a patch on fx-team > http://hg.mozilla.org/integration/fx-team. Are you sure you've pushed to > fx-team? Sorry, land-in-fx-team not fixed in fx-team. please ignore comment 8 :(
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/c6ce84a6c4d0
Whiteboard: [good first bug][mentor=paul][lang=css][land-in-fx-team] → [good first bug][mentor=paul][lang=css][fixed-in-fx-team]
After this patch has been on m-c for a couple days, I think we should put in a request for Aurora uplift since this is a new feature in 17 and it's a simple, low-risk change.
https://hg.mozilla.org/mozilla-central/rev/c6ce84a6c4d0
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment on attachment 655929 [details] [diff] [review] patch for checkin [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 764746 User impact if declined: ugly button for Linux Testing completed (on m-c, etc.): on m-c Risk to taking this patch (and alternatives if risky): very very low String or UUID changes made by this patch: nope
Attachment #655929 - Flags: approval-mozilla-aurora?
Comment on attachment 655929 [details] [diff] [review] patch for checkin Approving low risk change to support the positive user experience for this new feature.
Attachment #655929 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Target Milestone: --- → Firefox 18
Keywords: verifyme
Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Firefox/17.0 Marking as verified. Change is visible when comparing to version 16. Re-sizing also displays the counter as expected.
status-firefox17: fixed → verified
Keywords: verifyme
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: