Closed
Bug 779077
Opened 13 years ago
Closed 13 years ago
Don't focus the content area when closing a places context menu (Port Bug 776271)
Categories
(SeaMonkey :: Bookmarks & History, defect)
SeaMonkey
Bookmarks & History
Tracking
(seamonkey2.12 fixed, seamonkey2.13 fixed, seamonkey2.14 fixed)
RESOLVED
FIXED
seamonkey2.14
People
(Reporter: philip.chee, Assigned: tonymec)
Details
(Whiteboard: [good first bug][lang=js][mentor=Philip.Chee][level=apprentice])
Attachments
(1 file)
|
1.16 KB,
patch
|
philip.chee
:
review+
Callek
:
approval-comm-aurora+
Callek
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
From Bug 776271:
> This was added in bug 365171. Whereas this.focus() in buildContextMenu is
> gone by now, this seems to be a leftover. As far as I can tell, no special
> treatment is needed. Focus should just go back to where it was.
|
Assignee | |
Comment 1•13 years ago
|
||
Assignee: nobody → antoine.mechelynck
Status: NEW → ASSIGNED
Attachment #647629 -
Flags: review?(philip.chee)
|
Reporter | |
Comment 2•13 years ago
|
||
Comment on attachment 647629 [details] [diff] [review]
patch v0
Looks good. No related errors in the error console. r=me
Attachment #647629 -
Flags: review?(philip.chee) → review+
|
|
Reporter | |
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.14
|
|
Assignee | |
Comment 4•13 years ago
|
||
Comment on attachment 647629 [details] [diff] [review]
patch v0
[Approval Request Comment]
Regression caused by (bug #): bug 365171 FIXED 2006-12-28. This is an identical Sm port of Fx bug 776271.
User impact if declined: focus behaviour remains bad after right-click
Testing completed (on m-c, etc.): FIXED on Firefox (m-c) since Jul.31, on SeaMonkey (c-c) since Aug.02
Risk to taking this patch (and alternatives if risky): risk quasi null (removes a single focus() statement)
String changes made by this patch: none
Attachment #647629 -
Flags: approval-comm-beta?
Attachment #647629 -
Flags: approval-comm-aurora?
|
|
Assignee | |
Comment 5•13 years ago
|
||
sorry I forgot to add Cc when asking for approval, see comment #4.
|
||
Updated•13 years ago
|
Attachment #647629 -
Flags: approval-comm-beta?
Attachment #647629 -
Flags: approval-comm-beta+
Attachment #647629 -
Flags: approval-comm-aurora?
Attachment #647629 -
Flags: approval-comm-aurora+
|
|
||
Comment 6•13 years ago
|
||
status-seamonkey2.12:
--- → fixed
|
|
Reporter | |
Comment 7•13 years ago
|
||
status-seamonkey2.13:
--- → fixed
status-seamonkey2.14:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•