779171 - "Not Logged In" icon is pixellated, unpretty

Status: RESOLVED DUPLICATE of bug 788589

(Firefox Graveyard :: SocialAPI, defect)

Description

[Johnathan Nightingale [:johnath]]

Attachment: pixels!

I'm test running the social UI and, for what gavin tells me are known reasons, the toolbar button thinks I'm logged out when I'm not. What he did suggest I file, though, is that the placeholder icon beside my not-logged-in status is pixellated, and generally lacking in flair.

Screenshot from mac incoming.

Comment 1

[Jennifer Morrow [:Boriss] (UX)]

Sounds like we need a better & prettier OSX and Windows icon.  I can make a default one, though it would be great if individual social networks could specify their own icon if they chose to.

Comment 2

[Shane Caraveo (:mixedpuppy)]

We could do that later, but right now the api doesn't provide a way to specify an image when logged out.

Comment 3

[Jennifer Morrow [:Boriss] (UX)]

(In reply to Jennifer Morrow [:Boriss] (Firefox UX) from comment #1)
> Sounds like we need a better & prettier OSX and Windows icon.  I can make a
> default one, though it would be great if individual social networks could
> specify their own icon if they chose to.

So we have to specify one image for now for any logged-out status?  How is what Johnathan's seeing specified?  I'm guessing you'd ever only see it on an error, as you should never be logged out, and even on disconnect you wouldn't have an icon change.

This problem might be rare, but we might as well have a better icon in case it happens.  Just trying to figure out when/how users would see it.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

There doesn't need to be an error for it to happen. If you log in to a provider (with "remember me"), enable the social API, restart Firefox, see the sidebar working, log out of provider, restart Firefox, then the provider will be opened in a "logged out" state and the image will be showing.

I think it will be common for people to log out of their social network at times and this state will be encountered.

Comment 5

[Shane Caraveo (:mixedpuppy)]

The api supports getting notified of a logout, so if a provider sends that signal, we will show the logged out icon (without restart).

Comment 6

[Jennifer Morrow [:Boriss] (UX)]

(In reply to Shane Caraveo (:mixedpuppy) from comment #5)
> The api supports getting notified of a logout, so if a provider sends that
> signal, we will show the logged out icon (without restart).

The logged out icon that they provide, for now, but that we could provide by changing the API to allow us to specify?  Because the icon is right next to the "Not logged in" error, let's do exactly what we do for other in-content errors and show the warning triangle icon:

- OSX: http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/pinstripe/global/icons/warning-32.png
- Windows: http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/winstripe/global/icons/Warning.png

Comment 7

[Jennifer Morrow [:Boriss] (UX)]

Attachment: Mockup: Warning icon instead of pixelated mystery man icon

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

I don't understand why we are using a warning icon here. The user did nothing wrong and they are not in danger. Can we use an Info icon instead?

Using the Warning icon because other in-content errors use it doesn't make it right. We should fix those other instances too (see bug 756920 for example).

Comment 9

[Shane Caraveo (:mixedpuppy)]

because this and the extra buddy image from bug 788589 are somewhat entwined, I'm duping this to the other and fixing both issues there.