generic buddy icon appears in profile section when logged in

RESOLVED FIXED in Firefox 17

Status

()

Firefox
SocialAPI
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

Tracking

Trunk
Firefox 18
Points:
---

Firefox Tracking Flags

(firefox17- fixed)

Details

(Whiteboard: [Fx17])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
click on provider favicon to see the user profile.
in addition to the user profile pic, the generic buddy icon appears as a part of the clickable button.  I fixed this once, I'll double check if that is in a patch somewhere or made it into m-c
(Assignee)

Comment 1

5 years ago
Created attachment 659000 [details] [diff] [review]
default profile image

also addresses bug 779171
Attachment #659000 - Flags: review?(felipc)
(Assignee)

Updated

5 years ago
Duplicate of this bug: 779171
Attachment #659000 - Flags: review?(felipc) → review+
Comment on attachment 659000 [details] [diff] [review]
default profile image

Boriss, requesting ui-r as following bug 779171 comment 8, this patch uses the information icon (http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/pinstripe/global/icons/information-32.png) to indicate the logged out state
Attachment #659000 - Flags: ui-review?(jboriss)
Attachment #659000 - Flags: ui-review?(jboriss) → ui-review+
(Assignee)

Comment 4

5 years ago
Created attachment 664592 [details] [diff] [review]
default profile image

patch is unchanged, updated to latest m-c, carry forward r+
Attachment #659000 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
tracking-firefox17: --- → ?
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/d82c59029dcb
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d82c59029dcb
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
(Assignee)

Comment 7

5 years ago
Comment on attachment 664592 [details] [diff] [review]
default profile image

[Approval Request Comment]
minimal risk, updates appearance of ugly icon in social
Attachment #664592 - Flags: approval-mozilla-aurora?
We'll take this for uplift but since there's little risk of regression here there's no need to track at this point.
tracking-firefox17: ? → -
Attachment #664592 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 9

5 years ago
bah, hardcoded reference to image in theme...
(In reply to Alfred Kayser from comment #9)
> bah, hardcoded reference to image in theme...

Alfred, please file a bug to get this changed so it is not dependent on filename/location.
OS: Mac OS X → All
Hardware: x86 → All
Version: unspecified → Trunk
https://hg.mozilla.org/releases/mozilla-aurora/rev/fd86769ee85d
status-firefox17: --- → fixed

Updated

5 years ago
Blocks: 797298

Updated

5 years ago
No longer blocks: 797298
Depends on: 797298
You need to log in before you can comment on or make changes to this bug.