788589 - generic buddy icon appears in profile section when logged in

Status: RESOLVED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Shane Caraveo (:mixedpuppy)]

click on provider favicon to see the user profile.
in addition to the user profile pic, the generic buddy icon appears as a part of the clickable button.  I fixed this once, I'll double check if that is in a patch somewhere or made it into m-c

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: default profile image

also addresses bug 779171

Comment 3

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 659000 [details] [diff] [review]
default profile image

Boriss, requesting ui-r as following bug 779171 comment 8, this patch uses the information icon (http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/pinstripe/global/icons/information-32.png) to indicate the logged out state

Comment 4

[Shane Caraveo (:mixedpuppy)]

Attachment: default profile image

patch is unchanged, updated to latest m-c, carry forward r+

Comment 5

[:Felipe Gomes (needinfo for replies!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d82c59029dcb

Comment 6

[Mounir Lamouri (:mounir)]

https://hg.mozilla.org/mozilla-central/rev/d82c59029dcb

Comment 7

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 664592 [details] [diff] [review]
default profile image

[Approval Request Comment]
minimal risk, updates appearance of ugly icon in social

Comment 8

[Lukas Blakk [:lsblakk] use ?needinfo]

We'll take this for uplift but since there's little risk of regression here there's no need to track at this point.

Comment 9

[Alfred Kayser]

bah, hardcoded reference to image in theme...

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Alfred Kayser from comment #9)
> bah, hardcoded reference to image in theme...

Alfred, please file a bug to get this changed so it is not dependent on filename/location.

Comment 11

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/fd86769ee85d