779223 - Downloads button is blank with custom themes

Status: VERIFIED FIXED

(Firefox :: Downloads Panel, defect)

Description

[Dietrich Ayala (:dietrich)]

screenshot: http://cl.ly/image/2B0S1e0n3o2G

Comment 1

[Dietrich Ayala (:dietrich)]

shorlander said it's only when user has a persona.

like this one. http://www.getpersonas.com/en-US/persona/415723

Comment 2

[:Paolo Amadini]

Do you also have a custom full theme in addition to the lightweight theme?

Comment 3

[Dietrich Ayala (:dietrich)]

Nope, just default theme.

Comment 4

[:Paolo Amadini]

(In reply to Dietrich Ayala (:dietrich) from comment #3)
> Nope, just default theme.

Can't reproduce on Linux. This happens on Mac OS X as indicated in the bug, right?

I don't see any special rule in the Mac stylesheet that's different from the Linux
one, this should be investigated by someone with access to a Mac build or more
familiar that me with the changes made by lightweight themes.

Comment 5

[[:Aleksej]]

An older report of this: bug 779223.

For on Linux it happens with some personas, but not others.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

(In reply to Aleksej [:Aleksej] from comment #5)
> An older report of this: bug 779223.
> 
> For on Linux it happens with some personas, but not others.

Which personas? Can you send me a link to a few?

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Ah, yep, seeing it on Linux now too.

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

Neither pinstripe nor gnomestripe ships with a Toolbar-inverted.png icon set. We simply need to continue using the same icon.

Comment 10

[Marco Bonardo [:mak]]

Comment on attachment 670924 [details] [diff] [review]
Patch v1

Review of attachment 670924 [details] [diff] [review]:
-----------------------------------------------------------------

makes sense, we basically made the pinstripe and gnomestripe css starting from the winstripe ones and adapting to the platform, this looks like a leftover.

Comment 11

[Mike Conley (:mconley) (:⚙️)]

Landed on mozilla-inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/261a27e7473f

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/261a27e7473f

Comment 13

[Simona Badau, Desktop QA]

Verified as fixed on the latest Nightly - the Downloads button is not blank when the user installs personas.

Verified on Windows 7, Ubuntu 12.04 and Mac OS X 10.7:

Mozilla/5.0 (Windows NT 6.1; rv:19.0) Gecko/19.0 Firefox/19.0        
Build ID: 20121111030749
Mozilla/5.0 (X11; Linux i686; rv:19.0) Gecko/19.0 Firefox/19.0        
Build ID: 20121112030753
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:19.0) Gecko/19.0 Firefox/19.0        Build ID: 20121112030753