779353 - B2G Telephony: Hook up to permissions manager

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Gregor Wagner [:gwagner]]

The whitelist approach will go away pretty soon. We should update to the permissionManager approach.
https://mxr.mozilla.org/mozilla-central/source/content/base/src/nsContentUtils.cpp#6834

Comment 1

[Marshall Culpepper [:marshall_law]]

We should separate this into two bugs, one for telephony, and one for bluetooth..

Comment 2

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Dividing telephony and bluetooth into 2 seperate bugs. Bluetooth now Bug 779384

Comment 3

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: Patch part1: use nsIPermissionManager

Comment 4

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: Patch: testcase

Comment 5

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: Patch part2: testcase

Comment 6

[Mounir Lamouri (:mounir)]

Comment on attachment 649208 [details] [diff] [review]
Patch part1: use nsIPermissionManager

Review of attachment 649208 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/telephony/Telephony.cpp
@@ +562,4 @@
>    NS_ENSURE_SUCCESS(rv, rv);
> +
> +  if (permission == nsIPermissionManager::UNKNOWN_ACTION ||
> +      permission == nsIPermissionManager::DENY_ACTION) {

if (permission != nsIPermissionManager::ALLOW_ACTON) {

@@ +566,5 @@
>      *aTelephony = nullptr;
>      return NS_OK;
>    }
> +  NS_ENSURE_SUCCESS(permission == nsIPermissionManager::ALLOW_ACTION,
> +                    NS_ERROR_FAILURE);

Remove that check.

Comment 7

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 649212 [details] [diff] [review]
Patch part2: testcase

Hi Philipp, 
Patch part1 passed mounir's review. Could you help review the modifications in telephony testcases? Thanks!

Comment 8

[Philipp von Weitershausen [:philikon]]

Comment on attachment 649212 [details] [diff] [review]
Patch part2: testcase

Please don't get rid of the clean up. It serves the important purpose of giving each test a clean slate, at least permission-wise. Please use SpecialPowers.removePermission("telephony", document);

Comment 9

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: Patch part2: testcase (v2)

Updated according to Comment 8.

Comment 10

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment 6 addressed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2898f99f375c

https://hg.mozilla.org/integration/mozilla-inbound/rev/707a4a6340f0

Comment 11

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: patch (part1) v2

Use nsIPermissionManager. Addressed Comment 6.

Comment 12

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2898f99f375c
https://hg.mozilla.org/mozilla-central/rev/707a4a6340f0