Closed Bug 779650 Opened 7 years ago Closed 7 years ago

[Azure] Azure/Cairo canvas does not render smashcat benchmark with D2D backend

Categories

(Core :: Graphics, defect)

15 Branch
x86_64
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla17

People

(Reporter: nrc, Assigned: nrc)

References

()

Details

Attachments

(1 file, 1 obsolete file)

Split off from Bug 779401.

The smashcat benchmark does not render with Azure/Cairo canvas on Windows 7 with with D2D enabled. Turning D2D off resolves the problem, as does using Azure/Skia or Thebes canvas.
Assignee: nobody → ncameron
Attachment #648131 - Flags: review?(bas.schouten)
Comment on attachment 648131 [details] [diff] [review]
patch: support DrawTargetCairo in CanvasLayerD3D10

Review of attachment 648131 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/d3d10/CanvasLayerD3D10.cpp
@@ +53,4 @@
>        return;
> +    } 
> +    
> +    mSurface = gfxPlatform::GetPlatform()->GetThebesSurfaceForDrawTarget(mDrawTarget);

This is ok for now. But it's not the best possible way of dealing with this. We'd rather store the DrawTarget and deal with it in UpdateSurface directly (i.e. bypassing Thebes). In the interest of fixing this bug I'll r+ it for now. Please add a comment.
Attachment #648131 - Flags: review?(bas.schouten) → review+
Attached patch patchSplinter Review
added comment; carrying r=bas
Attachment #648131 - Attachment is obsolete: true
Attachment #648207 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/4141cfa13685
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Depends on: 792032
You need to log in before you can comment on or make changes to this bug.