Last Comment Bug 779650 - [Azure] Azure/Cairo canvas does not render smashcat benchmark with D2D backend
: [Azure] Azure/Cairo canvas does not render smashcat benchmark with D2D backend
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: 15 Branch
: x86_64 Windows 7
: -- normal with 1 vote (vote)
: mozilla17
Assigned To: Nick Cameron [:nrc]
:
Mentors:
http://www.smashcat.org/av/canvas_test/
Depends on: 792032
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-01 14:50 PDT by Nick Cameron [:nrc]
Modified: 2012-09-20 10:02 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch: support DrawTargetCairo in CanvasLayerD3D10 (3.07 KB, patch)
2012-08-01 16:09 PDT, Nick Cameron [:nrc]
bas: review+
Details | Diff | Review
patch (3.17 KB, patch)
2012-08-01 20:59 PDT, Nick Cameron [:nrc]
ncameron: review+
Details | Diff | Review

Description Nick Cameron [:nrc] 2012-08-01 14:50:28 PDT
Split off from Bug 779401.

The smashcat benchmark does not render with Azure/Cairo canvas on Windows 7 with with D2D enabled. Turning D2D off resolves the problem, as does using Azure/Skia or Thebes canvas.
Comment 1 Nick Cameron [:nrc] 2012-08-01 16:09:40 PDT
Created attachment 648131 [details] [diff] [review]
patch: support DrawTargetCairo in CanvasLayerD3D10
Comment 2 Bas Schouten (:bas.schouten) 2012-08-01 18:00:20 PDT
Comment on attachment 648131 [details] [diff] [review]
patch: support DrawTargetCairo in CanvasLayerD3D10

Review of attachment 648131 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/d3d10/CanvasLayerD3D10.cpp
@@ +53,4 @@
>        return;
> +    } 
> +    
> +    mSurface = gfxPlatform::GetPlatform()->GetThebesSurfaceForDrawTarget(mDrawTarget);

This is ok for now. But it's not the best possible way of dealing with this. We'd rather store the DrawTarget and deal with it in UpdateSurface directly (i.e. bypassing Thebes). In the interest of fixing this bug I'll r+ it for now. Please add a comment.
Comment 3 Nick Cameron [:nrc] 2012-08-01 20:59:29 PDT
Created attachment 648207 [details] [diff] [review]
patch

added comment; carrying r=bas
Comment 5 Ed Morley [:emorley] 2012-08-02 06:21:44 PDT
https://hg.mozilla.org/mozilla-central/rev/4141cfa13685

Note You need to log in before you can comment on or make changes to this bug.