[Azure] Azure/Cairo canvas does not render smashcat benchmark with D2D backend

RESOLVED FIXED in mozilla17

Status

()

Core
Graphics
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: nrc, Assigned: nrc)

Tracking

15 Branch
mozilla17
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Split off from Bug 779401.

The smashcat benchmark does not render with Azure/Cairo canvas on Windows 7 with with D2D enabled. Turning D2D off resolves the problem, as does using Azure/Skia or Thebes canvas.
(Assignee)

Updated

5 years ago
Assignee: nobody → ncameron
(Assignee)

Comment 1

5 years ago
Created attachment 648131 [details] [diff] [review]
patch: support DrawTargetCairo in CanvasLayerD3D10
Attachment #648131 - Flags: review?(bas.schouten)
Comment on attachment 648131 [details] [diff] [review]
patch: support DrawTargetCairo in CanvasLayerD3D10

Review of attachment 648131 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/d3d10/CanvasLayerD3D10.cpp
@@ +53,4 @@
>        return;
> +    } 
> +    
> +    mSurface = gfxPlatform::GetPlatform()->GetThebesSurfaceForDrawTarget(mDrawTarget);

This is ok for now. But it's not the best possible way of dealing with this. We'd rather store the DrawTarget and deal with it in UpdateSurface directly (i.e. bypassing Thebes). In the interest of fixing this bug I'll r+ it for now. Please add a comment.
Attachment #648131 - Flags: review?(bas.schouten) → review+
(Assignee)

Comment 3

5 years ago
Created attachment 648207 [details] [diff] [review]
patch

added comment; carrying r=bas
Attachment #648131 - Attachment is obsolete: true
Attachment #648207 - Flags: review+
(Assignee)

Comment 4

5 years ago
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=4141cfa13685

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/4141cfa13685
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17

Updated

5 years ago
Depends on: 792032
You need to log in before you can comment on or make changes to this bug.