779885 - navigator.mozContacts.getSimContacts() drops non-ASCII chars

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Fabien Cazenave [:kaze]]

STR:

 • using a dumbphone (e.g. my Nokia 1616), store contacts with French accented chars on the SIM card;
 • take the SIM card out, use it in a Samsung GS2, all contacts are properly imported;
 • take the SIM card out, use it in an Otoro with the latest Gonk/Gecko/Gaia, all accented characters are dropped (e.g. «Cédric» becomes «Cdric»).

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

I'll check SIM part first.

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch to show non-ASCII chars in SIM

Hi Vicamo,
I add a function called readGsm8BitUnpackToString referenced from readSeptetsToString by your suggestion, would you take a look in it and give me some feedback?

Thanks

Comment 3

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 649222 [details] [diff] [review]
Patch to show non-ASCII chars in SIM

Review of attachment 649222 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/ril_worker.js
@@ +4074,5 @@
>    /**
> +   * Read GSM 8-bit unpacked octets,
> +   * which are SMS default 7-bit alphabets with bit 8 set to 0.
> +   */
> +  readGsm8BitUnpackedToString: function readGsm8BitUnpackedToString(length) {

Can you rename it to read8BitSeptetsToString()? That way we have similar names for the two septet string reading variants.

@@ +4077,5 @@
> +   */
> +  readGsm8BitUnpackedToString: function readGsm8BitUnpackedToString(length) {
> +    let ret = "";
> +    let escapeFound = false;
> +    const langTable = PDU_NL_LOCKING_SHIFT_TABLES[0];

we had defined PDU_NL_IDENTIFIER_DEFAULT for default charset index.

@@ +4079,5 @@
> +    let ret = "";
> +    let escapeFound = false;
> +    const langTable = PDU_NL_LOCKING_SHIFT_TABLES[0];
> +    const langShiftTable = PDU_NL_SINGLE_SHIFT_TABLES[0];
> +  

tailing white space

@@ +4123,5 @@
>    readUCS2String: function readUCS2String(numOctets) {
>      let str = "";
> +    for (let i = 0; i < numOctets; i++) {
> +      let temp = this.readHexOctet();
> +      if (temp == 0xff) {

Hey! UCS2 has no such restriction! For example, character 'Ͽ' has code 0x03FF.

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: WIP - Patch to show non-ASCII chars in SIM v2

- Address to Vicamo's review comments.
- Add a function 'readICCUCS2String' to read UCS2 String on ICC.

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: WIP - Patch to show non-ASCII chars in SIM. v3

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch to show non-ASCII chars in SIM. v4

Hi Vicamo
Could you review this patch for me?

Thanks

Comment 7

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: xpcshell tests

Hi, Vicamo
This is the xpcshell tests.

Thanks

Comment 8

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 650435 [details] [diff] [review]
Patch to show non-ASCII chars in SIM. v4

Review of attachment 650435 [details] [diff] [review]:
-----------------------------------------------------------------

Sweet!

Comment 9

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 2: xpcshell tests v2

update tests

Comment 10

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 1: Patch to show non-ASCII chars in SIM. v4

rebase

Comment 11

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 2: xpcshell tests v2

rebase

Comment 12

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Part 1: https://hg.mozilla.org/integration/mozilla-inbound/rev/461d2a2a5b88
Part 2: https://hg.mozilla.org/integration/mozilla-inbound/rev/8405e424a351

Comment 13

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/461d2a2a5b88
https://hg.mozilla.org/mozilla-central/rev/8405e424a351