Implement Wifi*Events using code generator

RESOLVED FIXED in mozilla19

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: smaug, Assigned: chucklee)

Tracking

unspecified
mozilla19
x86
Linux
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

5 years ago
Wifi*Events are simple interfaces which one should be able to generate automatically.
But since they are compiled only #ifdef MOZ_B2G_RIL, I have no idea how to test
that the implementation actually works.
gwagner, could you perhaps take this bug?

Basically, each event interface should be in their own .idl file, and the same
file should contain the init dictionary.
Then add the events to event_impl_gen.conf.in
(#ifdef should work in that file, at least if you do something similar what is done
to MOZ_JSDEBUGGER in the Makefile.in)
Assignee: nobody → chulee
Created attachment 673810 [details] [diff] [review]
0001. Rewrite WifiStatusChangeEvent

1. Rewrite WifiStatusChangeEvent in codegen style
2. UUID of nsIDOMMozWifiStatusChangeEvent is not change since the structure is not changed.
Attachment #673810 - Flags: review?(bugs)
Created attachment 673811 [details] [diff] [review]
0002. Rewrite nsDOMMozWifiConnectionInfoEvent

1. Rewrite nsDOMMozWifiConnectionInfoEvent in codegen style
2. UUID of nsDOMMozWifiConnectionInfoEvent is not change since the structure is not changed.
Attachment #673811 - Flags: review?(bugs)
(Reporter)

Updated

5 years ago
Attachment #673810 - Flags: review?(bugs) → review+
(Reporter)

Updated

5 years ago
Attachment #673811 - Flags: review?(bugs) → review+
Created attachment 673830 [details] [diff] [review]
0001. Rewrite WifiStatusChangeEvent. Final patch for inboud. r=smaug

1. Rewrite WifiStatusChangeEvent in codegen style
2. UUID of nsIDOMMozWifiStatusChangeEvent is not change since the structure is not changed.
3. Final patch for inbound. r=smaug
Attachment #673810 - Attachment is obsolete: true
Created attachment 673831 [details] [diff] [review]
0002. Rewrite nsDOMMozWifiConnectionInfoEvent. Final patch for inboud. r=smaug

1. Rewrite nsDOMMozWifiConnectionInfoEvent in codegen style
2. UUID of nsDOMMozWifiConnectionInfoEvent is not change since the structure is not changed.
3. Final patch for inbound. r=smaug
Attachment #673811 - Attachment is obsolete: true
Whiteboard: checkin-needed
Keywords: checkin-needed
Whiteboard: checkin-needed
I don't see any Try results for these patches, so I've gone ahead and pushed them. I'll land this on inbound if it builds OK.
https://tbpl.mozilla.org/?tree=Try&rev=b1de0f2d6301
https://hg.mozilla.org/integration/mozilla-inbound/rev/76836f462a5b
https://hg.mozilla.org/integration/mozilla-inbound/rev/051bc70ec007
Flags: in-testsuite-
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/76836f462a5b
https://hg.mozilla.org/mozilla-central/rev/051bc70ec007
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
I received a mail warning about memory leak, but using codegen shouldn't such issue.
I can't understand why for now.

Regression  Trace Malloc Leaks increase 7.91% on MacOSX 10.7 Mozilla-Inbound
------------------------------------------------------------------------------
    Previous: avg 2778267.333 stddev 59407.885 of 30 runs up to revision 97474744374c
    New     : avg 2997970.000 stddev 5103.391 of 5 runs since revision e2e341820373
    Change  : +219702.667 (7.91% / z=3.698)
    Graph   : http://mzl.la/SfE0NW

Changeset range: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=97474744374c&tochange=e2e341820373

Changesets:
  * http://hg.mozilla.org/integration/mozilla-inbound/rev/76836f462a5b
    : Chuck Lee <chulee@mozilla.com> - Bug 780142 - Rewrite WifiStatusChangeEvent. r=smaug
    : http://bugzilla.mozilla.org/show_bug.cgi?id=780142

  * http://hg.mozilla.org/integration/mozilla-inbound/rev/051bc70ec007
    : Chuck Lee <chulee@mozilla.com> - Bug 780142 - Rewrite MozWifiConnectionInfoEvent. r=smaug
    : http://bugzilla.mozilla.org/show_bug.cgi?id=780142

  * http://hg.mozilla.org/integration/mozilla-inbound/rev/e2e341820373
    : Benjamin Chen <bechen@mozilla.com> - Bug 797817 - Update the battery indicator led when receiving battery status change. r=cjones
    : http://bugzilla.mozilla.org/show_bug.cgi?id=797817

Bugs:
  * http://bugzilla.mozilla.org/show_bug.cgi?id=797817 - Otoro LED stays lit after disconnecting from mains following full charge
  * http://bugzilla.mozilla.org/show_bug.cgi?id=780142 - Implement Wifi*Events using code generator
(Reporter)

Comment 9

5 years ago
This code shouldn't even be compiled on OSX, so the leak increase must be something else.
You need to log in before you can comment on or make changes to this bug.