Closed
Bug 780222
Opened 12 years ago
Closed 12 years ago
Remove redundant check-sync-dirs call in js/src/Makefile.in
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla17
People
(Reporter: rain1, Assigned: rain1)
References
Details
Attachments
(1 file)
5.39 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
check-sync-dirs is now run in client.mk (bug 740452), so the call in js/src/Makefile.in is no longer necessary. I've also removed all the configure goop associated with it. This blocks enabling pymake on Windows because of some funkiness with absolutely configured pymake.
Attachment #648778 -
Flags: review?(ted.mielczarek)
Updated•12 years ago
|
Assignee: nobody → sagarwal
Comment 1•12 years ago
|
||
Comment on attachment 648778 [details] [diff] [review] patch v1 Review of attachment 648778 [details] [diff] [review]: ----------------------------------------------------------------- The only downside here is that people who aren't doing client.mk rebuilds won't notice this until they push. However, it'd still get caught by pushing to try or inbound, and it will fail quickly, so it's not that bad. ::: client.mk @@ +402,5 @@ > -o \( -name '*.[ao]' -o -name '*.so' \) -type f -print`; \ > build/autoconf/clean-config.sh; \ > fi; > > +# Because the SpiderMonkey can be distributed and built independently "the SpiderMonkey"? I guess that's from the original, but can you fix the grammer?
Attachment #648778 -
Flags: review?(ted.mielczarek) → review+
Comment 2•12 years ago
|
||
(In reply to Ted Mielczarek [:ted] from comment #1) > The only downside here is that people who aren't doing client.mk rebuilds > won't notice this until they push. However, it'd still get caught by pushing > to try or inbound, and it will fail quickly, so it's not that bad. As I mentioned on IRC last week, people who aren't doing client.mk builds are unlikely to be running make check anyways, and this check only runs during make check.
Assignee | ||
Comment 3•12 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/9dd1dc9801e6 and review comment addressed in http://hg.mozilla.org/integration/mozilla-inbound/rev/a218e9b11bc5
Status: NEW → ASSIGNED
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9dd1dc9801e6 https://hg.mozilla.org/mozilla-central/rev/a218e9b11bc5
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•