Last Comment Bug 780222 - Remove redundant check-sync-dirs call in js/src/Makefile.in
: Remove redundant check-sync-dirs call in js/src/Makefile.in
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: x86_64 Windows 7
: -- normal (vote)
: mozilla17
Assigned To: Siddharth Agarwal [:sid0] (inactive)
:
:
Mentors:
Depends on:
Blocks: 593585
  Show dependency treegraph
 
Reported: 2012-08-03 11:09 PDT by Siddharth Agarwal [:sid0] (inactive)
Modified: 2012-08-07 07:36 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch v1 (5.39 KB, patch)
2012-08-03 11:09 PDT, Siddharth Agarwal [:sid0] (inactive)
ted: review+
Details | Diff | Splinter Review

Description Siddharth Agarwal [:sid0] (inactive) 2012-08-03 11:09:41 PDT
Created attachment 648778 [details] [diff] [review]
patch v1

check-sync-dirs is now run in client.mk (bug 740452), so the call in js/src/Makefile.in is no longer necessary. I've also removed all the configure goop associated with it.

This blocks enabling pymake on Windows because of some funkiness with absolutely configured pymake.
Comment 1 Ted Mielczarek [:ted.mielczarek] 2012-08-06 10:47:05 PDT
Comment on attachment 648778 [details] [diff] [review]
patch v1

Review of attachment 648778 [details] [diff] [review]:
-----------------------------------------------------------------

The only downside here is that people who aren't doing client.mk rebuilds won't notice this until they push. However, it'd still get caught by pushing to try or inbound, and it will fail quickly, so it's not that bad.

::: client.mk
@@ +402,5 @@
>  	          -o \( -name '*.[ao]' -o -name '*.so' \) -type f -print`; \
>  	   build/autoconf/clean-config.sh; \
>  	fi;
>  
> +# Because the SpiderMonkey can be distributed and built independently

"the SpiderMonkey"? I guess that's from the original, but can you fix the grammer?
Comment 2 Mike Hommey [:glandium] 2012-08-06 10:57:59 PDT
(In reply to Ted Mielczarek [:ted] from comment #1)
> The only downside here is that people who aren't doing client.mk rebuilds
> won't notice this until they push. However, it'd still get caught by pushing
> to try or inbound, and it will fail quickly, so it's not that bad.

As I mentioned on IRC last week, people who aren't doing client.mk builds are unlikely to be running make check anyways, and this check only runs during make check.
Comment 3 Siddharth Agarwal [:sid0] (inactive) 2012-08-06 14:16:59 PDT
http://hg.mozilla.org/integration/mozilla-inbound/rev/9dd1dc9801e6
and review comment addressed in
http://hg.mozilla.org/integration/mozilla-inbound/rev/a218e9b11bc5

Note You need to log in before you can comment on or make changes to this bug.