Last Comment Bug 780241 - pythonpath.py should not be a native command
: pythonpath.py should not be a native command
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: x86_64 Windows 7
: -- normal (vote)
: mozilla17
Assigned To: Siddharth Agarwal [:sid0] (inactive)
:
Mentors:
Depends on:
Blocks: 593585
  Show dependency treegraph
 
Reported: 2012-08-03 12:08 PDT by Siddharth Agarwal [:sid0] (inactive)
Modified: 2012-08-04 11:19 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (1.45 KB, patch)
2012-08-03 12:08 PDT, Siddharth Agarwal [:sid0] (inactive)
sid.bugzilla: review+
Details | Diff | Review

Description Siddharth Agarwal [:sid0] (inactive) 2012-08-03 12:08:48 PDT
Created attachment 648798 [details] [diff] [review]
patch

pythonpath.py isn't suitable to be a native command, because it modifies too much stuff (sys.argc, sys.argv) and too little stuff (not sys.modules['__main__']). Since it's going anyway in bug 774911, there's no point spending time fixing it.

This patch has r=ted over IRC.
Comment 1 Siddharth Agarwal [:sid0] (inactive) 2012-08-03 12:11:28 PDT
http://hg.mozilla.org/integration/mozilla-inbound/rev/ba994bcb9d33
Comment 2 Ed Morley [:emorley] 2012-08-04 11:19:09 PDT
https://hg.mozilla.org/mozilla-central/rev/ba994bcb9d33

Note You need to log in before you can comment on or make changes to this bug.