Closed
Bug 780487
Opened 13 years ago
Closed 12 years ago
All |overflow:hidden| became scrollable
Categories
(Firefox OS Graveyard :: General, defect)
Firefox OS Graveyard
General
Tracking
(blocking-basecamp:+)
VERIFIED
FIXED
| blocking-basecamp | + |
People
(Reporter: etienne, Assigned: timdream)
References
Details
(Whiteboard: [qa!])
Attachments
(2 files)
|
1.58 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
|
2.06 KB,
patch
|
Details | Diff | Splinter Review |
Test changeset: 38bf3dfd81a0
Gaia examples:
* Scrolling up on the lockscreen reveals the pinlock screen
* Scrolling left on the Dialer Cal log reveals the edit mode header
* Idem in the sms app
...
|
||
Comment 2•13 years ago
|
||
crossposting gaia issue: https://github.com/mozilla-b2g/gaia/issues/3174
|
|
||
Updated•13 years ago
|
blocking-basecamp: --- → ?
|
||
Comment 3•13 years ago
|
||
Do we have a regression range for this? This kind of massive breakage should be dealt with very swiftly. Lets identify the regressor and back it out if we don't have a better fix.
|
Assignee | |
Comment 4•13 years ago
|
||
|
||
Comment 5•13 years ago
|
||
(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TW) from comment #4)
> Candidates: bug 777672, bug 773356, bug 770453
The lack of tests in all of these patches makes me sad. We should try better.
|
|
Assignee | |
Comment 6•13 years ago
|
||
(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TW) from comment #4)
> Candidates: bug 777672, bug 773356, bug 770453
Reverted the patch of bug 773356 and rebuild gecko fix this. What do we do about it?
|
|
Assignee | |
Updated•13 years ago
|
Blocks: 773356
Keywords: regression
|
|
Assignee | |
Comment 7•13 years ago
|
||
Patch by merging the checks for two conditions.
Attachment #649536 -
Flags: review?(justin.lebar+bug)
|
||
Updated•13 years ago
|
Attachment #649536 -
Flags: review?(justin.lebar+bug) → review?(roc)
Attachment #649536 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 8•12 years ago
|
||
|
|
Assignee | |
Updated•12 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → tchien
|
||
Comment 9•12 years ago
|
||
Keywords: checkin-needed,
regression
|
|
||
Comment 10•12 years ago
|
||
backout at https://hg.mozilla.org/integration/mozilla-inbound/rev/97b04123694a for bad commit message
and repushed at
https://hg.mozilla.org/integration/mozilla-inbound/rev/f8638ec4a85c
|
|
||
Comment 11•12 years ago
|
||
style.indexOf("auto") seems sub-optimal, it will also match for "autofoo". For the future I think you want to do a split and then iterate through the result and set a few flags. Not a big deal though.
|
|
Assignee | |
Comment 12•12 years ago
|
||
(In reply to Andreas Gal :gal from comment #11)
> style.indexOf("auto") seems sub-optimal, it will also match for "autofoo".
> For the future I think you want to do a split and then iterate through the
> result and set a few flags. Not a big deal though.
It was originally written back in bug 717844.
|
|
Assignee | |
Updated•12 years ago
|
Status: NEW → ASSIGNED
|
||
Comment 13•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
blocking-basecamp: ? → +
|
||
Updated•12 years ago
|
Summary: All |oveflow:hidden| became scrollable → All |overflow:hidden| became scrollable
|
||
Comment 14•12 years ago
|
||
We should probably get someone from the QA team to verify this, given that this caused a lot of problems on the phone (i.e. lots of dups were filed). I'll test this today.
QA Contact: jsmith
Whiteboard: [qa+]
|
|
||
Comment 15•12 years ago
|
||
Unassigning. Looks like John is already testing this.
QA Contact: jsmith
Whiteboard: [qa+]
|
||
Comment 16•12 years ago
|
||
I verify that this is fixed on nexus s and galaxy s2 devices. Thanks!
|
|
||
Updated•12 years ago
|
QA Contact: jsmith
Whiteboard: [qa+]
|
|
||
Updated•12 years ago
|
Status: RESOLVED → VERIFIED
Whiteboard: [qa+] → [qa!]
You need to log in
before you can comment on or make changes to this bug.
Description
•