781171 - Remove MOZ_SIZE_OF_TYPE

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

This macro causes problem for doing universal builds. It should be replace with #ifdefs in header files.

Comment 1

[(not currently active) Ted Mielczarek]

The obvious place for hardcoding what we've been testing for is jscpucfg.h:
http://mxr.mozilla.org/mozilla-central/source/js/src/jscpucfg.h

Comment 2

[Jeff Walden [:Waldo]]

I'd rather jscpucfg.h didn't exist, ideally, and it'd be nice to discourage adding to or changing it.  I once started work on a mfbt/CPU.h header, sitting in an mq now, containing only mozilla::PointerSize at the time.  Possibly stuff like this should be moved into that header as well.  (I'm not sure if I ever filed a bug for the work, and I'm not sure I actually finished it, either.)  Possibly I could pick that up again now, although I need to strategically tunnel out of a month's backlog of bugmail and other such things before I do anything else.  :-)

Comment 3

[Nathan Froyd [:froydnj]]

Attachment: delete JS_BYTES_PER_WORD/JS_BITS_PER_WORD from configure.in

Applying this is not a good idea right now, as there are dependent bugs outstanding,
but I promise to apply them all in the right order.

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 816036 [details] [diff] [review]
delete JS_BYTES_PER_WORD/JS_BITS_PER_WORD from configure.in

Review of attachment 816036 [details] [diff] [review]:
-----------------------------------------------------------------

You need to update js/src/aclocal.m4 too.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/dfbfe76ad7f6