Skip/append more "WaitFor" variants and BaseGetNamedObjectDirectory

RESOLVED FIXED

Status

Socorro
Backend
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Benjamin Smedberg, Assigned: Benjamin Smedberg)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

5 years ago
I'll have a PR shortly which I'd like to get into production ASAP. This changes some append/skiplist settings to include a few more variants of windows functions, mainly for better hang processing.
(Assignee)

Comment 1

5 years ago
https://github.com/mozilla/socorro/pull/781
Assignee: nobody → benjamin

Comment 2

5 years ago
I am confused.
RealMsgWaitFor.* belongs to irrelevantSignatureRegEx and prefixSignatureRegEx (under the .*WaitFor.* pattern).
Blocks: 763896, 779830, 779657
(Assignee)

Comment 3

5 years ago
Yes, but we process irrelevant first and then prefix, AIUI, so this should still be correct.

Comment 4

5 years ago
Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/63861cb298762a3f4edd462eb3925c49283f339f
Bug 781317 - Put all "WaitFor" functions and "BaseGetNamedObjectDirectory" into the append list, and add a few additional windows functions to the skiplist.

Comment 5

5 years ago
Lonnen, this has been pushed, right? In that case, I guess we can mark it fixed.

(I hope this is on master and the branch used for prod right now.)

Comment 6

5 years ago
(In reply to Robert Kaiser (:kairo@mozilla.com) from comment #5)
> (I hope this is on master and the branch used for prod right now.)
It is on prod according to crash stats.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Comment 7

5 years ago
(In reply to Scoobidiver from comment #6)
> (In reply to Robert Kaiser (:kairo@mozilla.com) from comment #5)
> > (I hope this is on master and the branch used for prod right now.)
> It is on prod according to crash stats.

I knew it had been pushed to production. There was a reason why I didn't just mark fuixed but asked instead. Please don't just set them as fixed when questions asked are open, like if this was pushed to both master and production, as I asked above. I'll leave it resolved though, as there is *probably* no harm done.
(Assignee)

Comment 8

5 years ago
Through some kind of gitfail the thing which was pushed only accounted for the WaitFor parts of this patch: I've put up https://github.com/mozilla/socorro/pull/784 for the BaseGetNamedObjectDirectory change.

Comment 9

5 years ago
Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/47573de947b0af52feea1f9097600f0129f7ab8a
Merge pull request #784 from bsmedberg/BaseGetNamedObjectDirectory

Bug 781317 - Add BaseGetNamedObjectDirectory to the append list for better signatures from bug 763896
This is on master and stage, but has not been pushed to prod yet since it's not needed tonight and we're anticipating more changes to follow shortly.

@:bsmedberg, in the future it may be best to avoid putting other bug numbers in the summary. Bug 763896 also got a comment about a Socorro master push.
You need to log in before you can comment on or make changes to this bug.