782661 - Mozmill endurance test failure in testBookmarks_OpenAllIntTabs | "could not find element Selector: .bookmark-item[label='Test Folder'] "

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect, P2)

Description

[Maniac Vlad Florin (:vladmaniac)]

Mozmill: 1.5.17 
Started failing today on Aurora: 
http://mozmill-ci.blargon7.com/#/endurance/report/d87d47fd1034f072b9bece6ee634057f
OS: Mac OS X 10.8

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Please finish up your other assignments first before starting on this bug. It seems to be intermittent for this platform only.

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚BST]

I think we just need to wait for this element. A similar thing was recently mentioned on bug 780107 comment 13.

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

This has occurred again today: http://mozmill-ci.blargon7.com/#/endurance/report/352218d7e3125c857fc1d3716745fadf

Comment 4

[Daniela Petrovici]

The previous report should be in bug 812438
This issue reproduced today on Aurora:
Happened today with Aurora on Mac OS X 10.8.2 (x86_64)
http://mozmill-ci.blargon7.com/#/endurance/report/352218d7e3125c857fc1d37167c8b41f

Since they are on different branches and the fix for Aurora will require more investigation I will leave both bugs as opened.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

What is common in both tests?

Comment 6

[Andreea Matei [:AndreeaMatei]]

Also happened on ESR10, OS X 10.8.2:
http://mozmill-ci.blargon7.com/#/endurance/report/352218d7e3125c857fc1d37167cc102e

Comment 7

[Andreea Matei [:AndreeaMatei]]

Please ignore my previous comment, it was meant to be in bug 812438.

Comment 8

[Daniela Petrovici]

(In reply to Henrik Skupin (:whimboo) from comment #5)
> What is common in both tests?

The same item (see below) is common to both cases. The error probably appears in both cases because we are not waiting for the testFolder element before clicking on it. This was the case for bug 812438, but I was not able to reproduce this issue locally yet.

var testFolder = new elementslib.Selector(controller.window.document,
                                          ".bookmark-item[label='" +
                                            BOOKMARK_FOLDER_NAME + "']");
(http://hg.mozilla.org/qa/mozmill-tests/file/3235c72219a3/tests/endurance/testBookmarks_OpenAndClose/test1.js#l40)

Comment 9

[Daniela Petrovici]

Attachment: patch v1.0

Added waitForElement in front of rightClick since the problem seems to be that we are not waiting before right clicking on the testFolder.

Comment 10

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 693014 [details] [diff] [review]
patch v1.0

Review of attachment 693014 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, since the other bug with the same fix hasn't failed.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Can we please get the branch situation cleared? Which ones are affected? Please mark it appropriately.

Comment 12

[Andreea Matei [:AndreeaMatei]]

ESR10 was not affected, on comment 7 I repaired the mistake.

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

well, I cannot imagine that only firefox 19 is affected.

Comment 14

[Daniela Petrovici]

I verified all endurance reports starting with 08/14 on all branches and platforms. This issue reproduced only in the following dates (already added in the bug):
- 08/14 with FF 16.0a2 on MAC
- 12/07 with FF 19.0a2 on Mac OS X 10.8.2 (x86_64)

Please tell me if you want the patch for default branch, too or close the issue as WFM (since it did not reproduce starting 2 weeks ago).

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This is not only about branches were you can reproduce this problem. It's about missing code in general.

Comment 16

[Daniela Petrovici]

Attachment: patch v1.0

This is the patch for nightly and it clearly applies across branches

Comment 17

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 693875 [details] [diff] [review]
patch v1.0

Review of attachment 693875 [details] [diff] [review]:
-----------------------------------------------------------------

Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/3439507f4478 (default)

Let's watch for regressions and backport once we have a clear run.

Comment 18

[Daniela Petrovici]

No failure reports since the patch landed on default last week.

Comment 19

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Transplanted as:
http://hg.mozilla.org/qa/mozmill-tests/rev/b8b17b34ea88 (mozilla-aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/3321c33ea567 (mozilla-beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/a16d4b75e0ff (mozilla-release)
http://hg.mozilla.org/qa/mozmill-tests/rev/92111efeaf2f (mozilla-esr17)
http://hg.mozilla.org/qa/mozmill-tests/rev/a2ebb041c551 (mozilla-esr10)