782683 - Image upload broken on Firebug wiki (SSL connection error)

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: WebOps: Other, task, P3)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

When uploading a new image to Firebug wiki I am seeing:

https://getfirebug.com:80/wiki/index.php/Special:Upload

Secure Connection Failed
An error occurred during a connection to getfirebug.com:80.
SSL received a record that exceeded the maximum permissible length.
(Error code: ssl_error_rx_record_too_long)

As a test case, just try to upload an image here:
https://getfirebug.com/wiki/index.php/Main_Page

Honza

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Just marking as p1 since we are not able to make documentation.

Honza

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

The problem seems to be related to the URL which is used after the submit button (on the upload page) is clicked.

It's:
https://getfirebug.com:80/wiki/index.php/Special:Upload

If I change it (using Firebug) to:
https://getfirebug.com/wiki/index.php/Special:Upload

It works.

Honza

Comment 3

[Brandon Burton [:solarce]]

I am looking into this

Comment 4

[Brandon Burton [:solarce]]

This seems like something Mediawiki is doing.

I am digging into why

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Hi, any progress on this one?
It's really annoying for the Firebug team.

Honza

Comment 6

[Brandon Burton [:solarce]]

(In reply to Jan Honza Odvarko from comment #5)
> Hi, any progress on this one?
> It's really annoying for the Firebug team.
> 
> Honza

This seems to be coming from Mediawiki but neither :jakem nor I could find a setting that would correlate nor a bug report that matches.

This wiki is currently on https://getfirebug.com/wiki/index.php/Special:Version - 1.16.5 and 1.19.2 is the current stable version, http://www.mediawiki.org/wiki/Download

We'd like to schedule a time to upgrade to the latest stable version and see if that corrects the issue, we can do this on the dev site first, but want to coordinate some testing, what would be a good time to schedule this?

Comment 7

[Sebastian Zartner [:sebo]]

When you're planning to update the wiki, please also consider to implement bug 631022.

For me a good time for testing would be 9-10am PDT. Just leave me a mail if that fits you. Honza, if you want to test it, feel free to make a time suggestion.

Sebastian

Comment 8

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Brandon Burton [:solarce] from comment #6)
> (In reply to Jan Honza Odvarko from comment #5)
> > Hi, any progress on this one?
> > It's really annoying for the Firebug team.
> > 
> > Honza
> 
> This seems to be coming from Mediawiki but neither :jakem nor I could find a
> setting that would correlate nor a bug report that matches.
> 
> This wiki is currently on
> https://getfirebug.com/wiki/index.php/Special:Version - 1.16.5 and 1.19.2 is
> the current stable version, http://www.mediawiki.org/wiki/Download
> 
> We'd like to schedule a time to upgrade to the latest stable version and see
> if that corrects the issue, we can do this on the dev site first, but want
Great, thanks!

> to coordinate some testing, what would be a good time to schedule this?
I am based in GMT+1 (+1 daylight saving time currently) and anything between 1am - 10am PDT is fine for me.

Honza

Comment 9

[Brandon Burton [:solarce]]

:jakem is checking with OpSec on bug 631022 , do you want us to block doing the base upgrade on these plugins?

Comment 10

[Sebastian Zartner [:sebo]]

No, the image upload is more important than the plugins.
I assume all of them can also be added afterwards, no?

Sebastian

Comment 11

[Daniel Maher [:phrawzty]]

Hello everybody,

This bug has been sitting around for a while, therefore I'd like to execute on one of the two following options :

1. Establish the clear and quantifiable steps that will allow this bug to be closed.
2. Close the bug for now and call it a day.

Please comment at your earliest convenience.  Thank you. :)

Comment 12

[Sebastian Zartner [:sebo]]

Hi Daniel,

I don't understand what you mean by "Establish the clear and quantifiable steps" nor "call it a day".
Fact is, this is still broken. If you need steps to reproduce it, here they are:

1. Log in to https://getfirebug.com/wiki/
2. Go to https://getfirebug.com/wiki/index.php/Special:Upload
3. Click the "Upload file" button (or check the form's URL).

The MediaWiki still didn't get updated yet. So it would be great if someone could finally take care of that, which hopefully fixes this bug.

Sebastian

Comment 13

[Daniel Maher [:phrawzty]]

Hi Sebastian,

So upgrading MediaWiki is the clear and quantifiable step necessary in order to close this bug - that's fine. :)  As you can see, :jd has set up a blocker bug, which covers the upgrading of our MediaWiki instances in general.

Thanks for your reply - have a great day !

Comment 14

[Sebastian Zartner [:sebo]]

> So upgrading MediaWiki is the clear and quantifiable step necessary in order to close this bug
Ah, now I understand. :-)

> As you can see, :jd has set up a blocker bug, which covers the upgrading of our MediaWiki instances in general.
I am not authorized to see that bug but thanks for the info.

Have a nice weekend!

Sebastian

Comment 15

[Jake Maul [:jakem]]

This is resolved (finally). Turned out to be a Mediawiki setting- it attempts to detect if HTTPS is set or not, and set the $wgServer variable based on this. It also attempts to detect non-standard ports, and add them if necessary. In our setup, SSL is offloaded by the load balancers so it doesn't get detected properly.

The end result is it decides the proper server name is:

https://getfirebug.com:80

Which clearly won't work (:80 is for http, not https)

The fix is to simply specify $wgServer in the LocalSettings.php (or in this case, I used LocalSettings-local.php).

Comment 16

[Jake Maul [:jakem]]

By the way I uploaded a file to test this, but don't to have access to delete it:

https://getfirebug.com/wiki/index.php/File:HbWj.png

Comment 17

[Sebastian Zartner [:sebo]]

I can confirm that it works now. Thanks a lot for the analyses and the fix, Jake!

I also deleted your test image.

Sebastian