Chrome refreshdriver runs all the time

RESOLVED FIXED in Firefox 17

Status

()

Core
Layout
--
blocker
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

unspecified
mozilla17
x86
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox17+ fixed)

Details

(Whiteboard: [qa-])

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
I was randomly checking where to optimize responsiveness and noticed that the
chrome refresh driver runs all the time at full speed. It happens even if there is
just one Firefox window open and the only page is about:blank.
(in that case the content refreshdriver doesn't run)


(Another thing not clear to me at all is why we have separate refreshdriver for content and chrome)
(Assignee)

Comment 1

5 years ago
Looks like we run the driver all the time because there are 2 image requests.
Investigating ...
(Assignee)

Comment 2

5 years ago
chrome://browser/skin/tabbrowser/connecting.png
chrome://browser/skin/tabbrowser/loading.png
are all the time in the refresh driver.
(Assignee)

Updated

5 years ago
Component: Layout → General
Product: Core → Firefox
(Assignee)

Comment 3

5 years ago
Not sure if this is a layout bug or Firefox/Toolkit bug.
These images are used by <xul:image> tags that have a list-style-image assigned. If the tab's not busy they're hidden using 'display: none'.

https://mxr.mozilla.org/mozilla-central/source/browser/base/content/tabbrowser.css#44

I suspect a layout bug here.
(Assignee)

Updated

5 years ago
Component: General → Layout
Product: Firefox → Core
(Assignee)

Comment 5

5 years ago
Back to layout. It really should remove imgIRequests from refreshdriver if those won't be painted.
(Assignee)

Comment 6

5 years ago
So I think this is because ImageLoader registers image request even if there isn't any
frames using it.
Trying to fix this.
Assignee: nobody → bugs
(Assignee)

Comment 7

5 years ago
Created attachment 652268 [details] [diff] [review]
WIP
(Assignee)

Comment 8

5 years ago
https://tbpl.mozilla.org/?tree=Try&rev=43ad063bd61c
(Assignee)

Comment 9

5 years ago
Comment on attachment 652268 [details] [diff] [review]
WIP

Breaks animated backgrounds.
Attachment #652268 - Attachment is obsolete: true
(Assignee)

Comment 10

5 years ago
To Kyle who wrote all this new code.
Assignee: bugs → khuey
(Assignee)

Updated

5 years ago
Blocks: 697230
(Assignee)

Comment 11

5 years ago
(In reply to Olli Pettay [:smaug] from comment #9)
> Comment on attachment 652268 [details] [diff] [review]
> WIP
> 
> Breaks animated backgrounds.

Or maybe not. They are broken anyway, Bug 783220
(Assignee)

Comment 12

5 years ago
(This is killing my battery)
Severity: normal → blocker
(Assignee)

Updated

5 years ago
tracking-firefox17: --- → ?
(Assignee)

Updated

5 years ago
Attachment #652268 - Attachment is obsolete: false
Attachment #652268 - Flags: review?(khuey)
(Assignee)

Comment 13

5 years ago
https://tbpl.mozilla.org/?tree=Try&rev=67f1c1ef4586
tracking-firefox17: ? → +
Attachment #652268 - Flags: review?(khuey) → review+
Assignee: khuey → bugs
(Assignee)

Comment 14

5 years ago
Created attachment 653999 [details] [diff] [review]
patch

actually use presContext and don't recall the method.
(Assignee)

Comment 15

5 years ago
https://hg.mozilla.org/mozilla-central/rev/e33c175f6807
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Blocks: 783906

Updated

5 years ago
status-firefox17: --- → fixed
Target Milestone: --- → mozilla17
Can someone please advise QA how to verify this bug is fixed for Firefox 17?
Whiteboard: [qa?]
(Assignee)

Comment 17

5 years ago
that is hard. I profiled FF, and added some printfs to refreshdriver to figure out 
this.

but I haven't seen this after the fix.
Okay, thanks Olli. I'm going to flag this [qa-] meaning QA won't allocate resources to trying to verify this fix. If you or someone else finds a way to reliably verify this, please do so.

Thank you.
Whiteboard: [qa?] → [qa-]

Updated

4 years ago
Depends on: 865511
You need to log in before you can comment on or make changes to this bug.