Turn on CSS flexbox in builds by default (by enabling pref, build flag, etc)

RESOLVED FIXED in mozilla20

Status

()

Core
Layout
RESOLVED FIXED
5 years ago
2 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Trunk
mozilla20
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [pref currently disabled in release builds -- see bug 841876])

Attachments

(1 attachment, 3 obsolete attachments)

Bug 666041 is on the main CSS3 flexbox implementation, but there may be a bit of followup work to do in helper-bugs that will land separately.

I'm filing this bug to track the work that we need to do before we're ready to enable flexbox in nightly builds.
Created attachment 652616 [details] [diff] [review]
patch to enable flexbox in builds

Here's the patch to toggle flexbox on in builds (formerly posted as "patch 99" on bug 666041)
Depends on: 783415
Depends on: 783470
Depends on: 783474
Depends on: 785468
NOTE: this bug is really a tracker for when flexbox is ready to be enabled in builds & exposed to the web by default.

If it turns out we can easily pref properties off (soon w/ paris DOM bindings -- maybe it's already possible?), then we can enable MOZ_FLEXBOX in builds ASAP, but just pref off its properties (so that developers can toggle the pref to try it out while pieces are still landing).  Then, we can morph this bug into preffing it on.
Summary: Enable MOZ_FLEXBOX in builds → Enable MOZ_FLEXBOX in builds (preffed on, if possible/applicable)
Summary: Enable MOZ_FLEXBOX in builds (preffed on, if possible/applicable) → Enable MOZ_FLEXBOX in builds (and pref it on, if applicable)
Depends on: 791037
Depends on: 790903
Created attachment 666341 [details] [diff] [review]
patch v2 to enable flexbox in builds

Updated patch to also uncomment the flexbox-reftest line in layout/reftests/reftest.list
Attachment #652616 - Attachment is obsolete: true
I'm clarifying this bug's summary to be track *fully enabling* flexbox by default.

(I'm going to spin off a separate bug on enabling the build flag, so that the flexbox code will compile but will still be preffed off per bug 796212.)
Depends on: 796212
Summary: Enable MOZ_FLEXBOX in builds (and pref it on, if applicable) → Turn on CSS flexbox in builds by default (by enabling pref, build flag, etc)
Depends on: 797022
Comment on attachment 666341 [details] [diff] [review]
patch v2 to enable flexbox in builds

(In reply to Daniel Holbert [:dholbert] from comment #4)
> (I'm going to spin off a separate bug on enabling the build flag

Spun off bug 797022 for that.  Obsoleting the patch on this bug here -- it's being replaced by a few patches over on that new bug.
Attachment #666341 - Attachment is obsolete: true
Created attachment 667393 [details] [diff] [review]
patch v3: enable flexbox pref

For reference, here's what the patch for this bug would look like now -- just a pref tweak.
Depends on: 798666
Blocks: 815442
Created attachment 689451 [details] [diff] [review]
patch v4: enable flexbox pref, and tweak reftests/mochitests accordingly

I think we should turn this on, at least in nightly builds.  (Though we may decide to turn it off again on the Beta and possibly Aurora channels, when this patch makes it to those, depending on how spec-compliant/bug-free we are at that point.)

Patch attached to enable this and update our automated tests' expectations about the pref being [dis|en]abled.

Try run: https://tbpl.mozilla.org/?tree=Try&rev=f8133fcad6ca
Attachment #667393 - Attachment is obsolete: true
Attachment #689451 - Flags: review?(dbaron)
Comment on attachment 689451 [details] [diff] [review]
patch v4: enable flexbox pref, and tweak reftests/mochitests accordingly

r=dbaron
Attachment #689451 - Flags: review?(dbaron) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/75cab729c971
oops, that had the wrong bug number. (inverted two digits)

Backed out:
  https://hg.mozilla.org/integration/mozilla-inbound/rev/4bf567bd1a3c
and re-landed w/ that fixed:
  https://hg.mozilla.org/integration/mozilla-inbound/rev/9bf579519470
https://hg.mozilla.org/mozilla-central/rev/9bf579519470
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Whiteboard: [pref currently disabled in release builds -- see bug 841876]

Updated

4 years ago
Depends on: 905229
No longer depends on: 905229

Updated

2 years ago
Depends on: 1212625
No longer depends on: 1212625
You need to log in before you can comment on or make changes to this bug.