798666 - flexbox doesn't honor min-height on horizontal auto-height flex container

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Daniel Holbert [:dholbert]]

Attachment: testcase

STR: enable flexbox pref (layout.css.flexbox.enabled), and load testcase

EXPECTED RESULTS: green area should be 800px tall
ACTUAL RESULTS: green area is only 1 line tall

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix v1

Still need to add a reftest, but here's the fix.

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix v1a (now w/ reftests)

Added reftests.

Note that I've already got reftests to address "min-height/max-height" in _vertical_ auto-height flex containers.  The reftests here are for _horizontal_ auto-height flex containers, with min-height / max-height constraints.

(plus a reftest for a vertical auto-width flex container, with min-width/max-width, for symmetry)


So -- the idea behind the code-change is:
 (a) if cross-size is unconstrained, we shrinkwrap our flex line's cross-size, **but** we must respect min/max sizing constraints.

 (b) If those min/max constraints end up affecting our cross-size, we need to update our line's cross-size. (so that positioning / stretch-sizing within the line will be working with the correct cross-size)  (That's why I changed the conditions under which we call lineCrossAxisPosnTracker.SetLineCrossSize().)

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 668743 [details] [diff] [review]
fix v1a (now w/ reftests)

r=dbaron

Comment 4

[Daniel Holbert [:dholbert]]

Unprefixed testcase (per bug 801098), and pushed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a70b58fcf059

Comment 5

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/a70b58fcf059