Closed
Bug 783631
Opened 13 years ago
Closed 13 years ago
Make media/mtransport build on Windows
Categories
(Core :: WebRTC: Networking, defect)
Core
WebRTC: Networking
Tracking
()
RESOLVED
FIXED
People
(Reporter: ted, Assigned: ted)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
19.82 KB,
patch
|
ekr
:
review+
|
Details | Diff | Splinter Review |
Fix a bunch of stuff to compile on Win32.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #652852 -
Flags: review?(ekr)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 652852 [details] [diff] [review]
Make media/mtransport build on Windows
Review of attachment 652852 [details] [diff] [review]:
-----------------------------------------------------------------
With minor nits.
::: media/mtransport/third_party/nICEr/nicer.gyp
@@ +159,5 @@
> + 'USE_STUN_PEDANTIC',
> + '_CRT_SECURE_NO_WARNINGS',
> + '__UNUSED__=',
> + 'HAVE_STRDUP',
> + 'OPENSSL',
We should probably take off OPENSSL here.
::: media/mtransport/transportlayer.h
@@ +86,5 @@
> };
>
> #define LAYER_INFO "Flow[" << flow_id() << "(none)" << "]; Layer[" << id() << "]: "
>
> +#pragma pop_macro("ERROR")
Can you file a bug for this ERROR thing so I can change it to have a prefix?
Attachment #652852 -
Flags: review?(ekr) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•13 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•