Make media/mtransport build on Windows

RESOLVED FIXED

Status

()

Core
WebRTC: Networking
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ted, Assigned: ted)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Fix a bunch of stuff to compile on Win32.
(Assignee)

Comment 1

5 years ago
Created attachment 652852 [details] [diff] [review]
Make media/mtransport build on Windows
Attachment #652852 - Flags: review?(ekr)

Comment 2

5 years ago
Comment on attachment 652852 [details] [diff] [review]
Make media/mtransport build on Windows

Review of attachment 652852 [details] [diff] [review]:
-----------------------------------------------------------------

With minor nits.

::: media/mtransport/third_party/nICEr/nicer.gyp
@@ +159,5 @@
> +                    'USE_STUN_PEDANTIC',
> +                    '_CRT_SECURE_NO_WARNINGS',
> +                    '__UNUSED__=',
> +                    'HAVE_STRDUP',
> +                    'OPENSSL',

We should probably take off OPENSSL here.

::: media/mtransport/transportlayer.h
@@ +86,5 @@
>  };
>  
>  #define LAYER_INFO "Flow[" << flow_id() << "(none)" << "]; Layer[" << id() << "]: "
>  
> +#pragma pop_macro("ERROR")

Can you file a bug for this ERROR thing so I can change it to have a prefix?
Attachment #652852 - Flags: review?(ekr) → review+
(Assignee)

Comment 3

5 years ago
Filed bug 783654.

https://hg.mozilla.org/projects/alder/rev/ba97a9078cbc
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Duplicate of this bug: 768450
(Assignee)

Updated

5 years ago
Blocks: 699646

Updated

5 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.