784184 - [Dialer] DTMF tone volume is not regulated by the volume button

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect, P1)

Description

[[e-mail] [:onecyrenus]]

Dialer audio levels are not regulated by the volume button. 

The audio level seems fine to me, but I can see how a person would expect the volume button to have an effect on the volume.

Comment 1

[[e-mail] [:onecyrenus]]

The repro for this is:

1) Enter the dialer app
2) Press 5
3) increase the volume
4) Press 5

The volume should change, it doesn't. 


Otoro: 08/20/2012 Daily Build

Comment 2

[Andrew Overholt [:overholt]]

Would be great to have the dialer using the same audio system as everything else but not likely a blocker.

Comment 3

[ayman maat :maat]

component = Gaia:Dialer

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

This is breaking smoketests which, to me, suggests it should be blocking basecamp otherwise why do we have a smoketest for this?

Comment 6

[Joe Cheng [:jcheng] (please needinfo)]

(In reply to [e-mail]  [:onecyrenus] from comment #1)
> The repro for this is:
> 
> 1) Enter the dialer app
> 2) Press 5
> 3) increase the volume
> 4) Press 5
> 
> The volume should change, it doesn't. 
> 
> 
> Otoro: 08/20/2012 Daily Build

Base on the steps, it seems like it's the DTMF tone that doesn't get changed with the volumne buttons. I tried on my own phone and it behaves the same. 
Adding UX to confirm if DTMF tones need to change by Volumn Buttons

Comment 7

[Ben Francis [:benfrancis]]

Triage: Gordon (UX) suggested to go ahead as described.

P3 for less severe usability issue.

Comment 9

[Dylan Oliver [:doliver]]

Removing from smoketest blocker list and updating title since this is about the DTMF volume rather than the in-call volume. 

mvines, do you have an opinion about the severity of this one?

Comment 10

[Michael Vines [:m1] [:evilmachines]]

I don't think this will affect any conformance tests, maybe just a little annoying for the user.

Comment 11

[Joe Cheng [:jcheng] (please needinfo)]

Is this really a blocker? since it doesn't block smoketest now and my commercial Android phone behaves the same (DTMF tone audio volume doesn't get changed)

Comment 12

[Joe Cheng [:jcheng] (please needinfo)]

Triage: BB-, commercial Android devices behave the same

Comment 13

[Daniel Holbert [:dholbert]]

(In reply to Joe Cheng from comment #11)
> Is this really a blocker? since it doesn't block smoketest now and my
> commercial Android phone behaves the same (DTMF tone audio volume doesn't
> get changed)

Really? I've had several android devices, and as far as I recall, Android has always had "expected results" from this bug. (DTMF is controlled by volume control, when you're in the dialer app)  This is the case in my Nexus 4 that I'm holding in my hand right now, at least.

RE-noming, since this was the basis for minusing (in comment 12).

Comment 14

[Daniel Holbert [:dholbert]]

(In particular, Android's dialer app has always allowed me to silence the DTMF tones by hitting the volume rocker all the way down to 0 when I'm in the dialer app.  This doesn't work in Gaia.)

Comment 15

[Joe Cheng [:jcheng] (please needinfo)]

I was testing on a HTC One X where the DTMF tones does not change audio volume along with the the system audio volume change. However, when the phone is muted, the DTMF tone will get muted as well.

Comment 16

[Daniel Holbert [:dholbert]]

On my Nexus 4, while I'm in the dialer app, the volume-rocker controls the "Ringtone & notifications" level.  And that's the sound-category that DTMF falls under, on my phone at least.

(I seem to recall that an earlier version of Android classified DTMF under "media" instead -- but even on that version, if you touched the volume rocker while a DTMF tone was playing, it would adjust the DTMF volume level by noticing what sound was playing while you hit the volume-control, or something like that.)

Comment 18

[Dylan Oliver [:doliver]]

I still don't see why we would block v1 on this -- perhaps it doesn't meet expectations but how is this detrimental to the user?

Comment 19

[Daniel Holbert [:dholbert]]

(In reply to Dylan Oliver [:doliver] from comment #18)
> but how is this detrimental to the user?

If you're in a quiet environment & you're trying to dial your phone (e.g. to place a quick hushed-tones call, or to listen in on a teleconference, or to check your voicemail), it's really annoying if your phone insists on making loud bleeps and boops as you dial, calling attention to you & annoying your neighbors in an otherwise-quiet environment.

I've come to expect that any modern mobile phone will let me turn off the DTMF noise for situations like this -- but B2G does not, currently. (At least, not in any discoverable way.)

Comment 20

[Dylan Oliver [:doliver]]

Sorry Daniel, I was stuck imagining a volume increase scenario for some reason -- this makes more sense.

There is a way to turn them off in the Sound section of the Settings app. I agree that it's not that discoverable from the place you are when you want to make that change. 

I also see now that David marked this tracking+ and not blocking+, so I should just be quiet now.

Comment 21

[Andrew Overholt [:overholt]]

We don't have voting in the Boot2Gecko component but I'd definitely be in favour of fixing this ASAP :)

Comment 22

[(inactive after 6/18) Alive Kuo [:alive]]

renominate. comment 15 doesn't happen on my S3. Not all android phone act like comment 15 I think.

Comment 23

[Joe Cheng [:jcheng] (please needinfo)]

Triage: BB-, keep original decision since user can disable DTMF tones in settings

Comment 25

[Jason Smith [:jsmith]]

Putting needsinfo on Josh to see if UX would block on this - Personally I actually *would* block on this, as most users manage their volume through the sound hardware buttons. The fact that they don't work under user expectation even though there is a hidden work-around is absolutely annoying (I didn't even know that work-around existed until I read about it).

Comment 26

[Larissa Co [:lco]]

Alive, would the issue of these being short audio clips be fixed if we just treated DTMF Tones as tied ringer/notification tones instead of content tones?

Comment 27

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Larissa Co from comment #26)
> Alive, would the issue of these being short audio clips be fixed if we just
> treated DTMF Tones as tied ringer/notification tones instead of content
> tones?

Yes...for this bug only.
But this means DTMF tones would interrupt any playing content. Don't know how the user would feel.

Comment 28

[Christian Heilmann]

We just had the same issue in the app porting training - turning the phone to mute still plays a music of a game. That is not the best experience.

Comment 29

[Josh Carpenter [:jcarpenter]]

(In reply to Jason Smith [:jsmith] from comment #25)
> Putting needsinfo on Josh to see if UX would block on this - Personally I
> actually *would* block on this, as most users manage their volume through
> the sound hardware buttons. The fact that they don't work under user
> expectation even though there is a hidden work-around is absolutely annoying
> (I didn't even know that work-around existed until I read about it).

I agree: system volume should regulate DTMF volume. This always bites me while I try to test the device in the office, a flight, etc, and the dialer volume plays at max. It's great that we have a work around, but the vast majority of users will not discover it. 

I also agree that we should block on this, because it is so fundamental, and the current implementation is so aggravating.

Comment 30

[Jason Smith [:jsmith]]

Another triage round this bug goes!

Comment 31

[David Scravaglieri [:scravag]]

This is certainly annoying, but we will not block the V1 for that.

Comment 32

[Damon Sicore (:damons)]

I know we decided to not block on this as it's user initiated, again, for basecamp, but I really think we should.  This is annoying.  I'd very much like to see a patch for this before final product.

Comment 33

[(inactive after 6/18) Alive Kuo [:alive]]

I have a patch per comment#26 right now ;)
c.c. Casey too.

It depends on the solution we decide though.
* Fix bug 815970 or bug 819842 could make the keypad sound be silent too.

Comment 34

[Dylan Oliver [:doliver]]

(In reply to Alive Kuo [:alive] from comment #33)
> I have a patch per comment#26 right now ;)

With that patch, does it still honor the on/off checkbox for Keypad in the Settings|Sound prefs? Or do they get grouped with Ringer&Nofications and we'd remove the Keypad checkbox?

Comment 35

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Dylan Oliver [:doliver] from comment #34)
> (In reply to Alive Kuo [:alive] from comment #33)
> > I have a patch per comment#26 right now ;)
> 
> With that patch, does it still honor the on/off checkbox for Keypad in the
> Settings|Sound prefs? Or do they get grouped with Ringer&Nofications and
> we'd remove the Keypad checkbox?

I think remove it or not would be an UX decision.
There're cases that people would keep sounds unmuted ALWAYS but disable the key tones IMO. 

For the question: They are grouped with notification, ya.

Comment 37

[(inactive after 6/18) Alive Kuo [:alive]]

Casey, let's figure out if comment 26 is adoptable.
BTW, I believe there're still some sound-related UX bugs needs to be marked as BerlinWW....

Comment 38

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/7433

https://github.com/mozilla-b2g/gaia/pull/7433
Casey told me that he would like to change DTMF to ringer channel.

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):

Comment 39

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Alive Kuo [:alive] from comment #38)
> Created attachment 699751 [details]
> https://github.com/mozilla-b2g/gaia/pull/7433
> 
> https://github.com/mozilla-b2g/gaia/pull/7433
> Casey told me that he would like to change DTMF to ringer channel.

What does change the channel fixes the bug? I would love to r+ this after I know this is a valid fix.

Comment 40

[(inactive after 6/18) Alive Kuo [:alive]]

Because volume rocker by default is changing audio.volume.notification and ringer channel is relying on that.

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) from comment #39)
> (In reply to Alive Kuo [:alive] from comment #38)
> > Created attachment 699751 [details]
> > https://github.com/mozilla-b2g/gaia/pull/7433
> > 
> > https://github.com/mozilla-b2g/gaia/pull/7433
> > Casey told me that he would like to change DTMF to ringer channel.
> 
> What does change the channel fixes the bug? I would love to r+ this after I
> know this is a valid fix.

Comment 41

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 699751 [details]
https://github.com/mozilla-b2g/gaia/pull/7433

All right, I believe you.

Comment 42

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 699751 [details]
https://github.com/mozilla-b2g/gaia/pull/7433

Seems a pretty simple change. a+.

Comment 43

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/9a6950b4353d6c1813cdde8d85f0f0467a4fe492

Comment 44

[Casey Yee]

Works a charm!

Good work guys :D