784982 - [10.8] DMG window is much wider than on Lion and older

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[philippe (part-time)]

Attachment: camino-dmg on ML

On Lion / Snow Leopard, the DMG window is 400px, on Mountain Lion it is 452px wide. As a result the diagrammatic background image appears too short (Mountain Lion appears to enforce a wider minimum width).

Firefox had the same issue in bug 736655; they resolved the problem by making their images larger. I’m not user if that is a solution for us (while keeping compatibility with Tiger - Lion).

Note: it’s trivial to stretch the background bar to fit the new width while keeping all icons in place by adding 26px on both sides.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I assume Camino 2.1.2 ML looks fine, though (bug 729396)?  If so, then I don't see any reason why making the en-only dmg window wider will be a problem for 10.4-10.7, other than just having to accomodate extra space.

If so, when you get a chance, can you make a wider background (you can switch to .png now :-) since we're going to have to regenerate the .DS_Store anyway)?  I think we probably want to increase the spacing between the icons rather than just adding 26px of "blank" space on each side, though.

Then I'll tweak the file positions and regenerate the .DS_Store, and the world will be 52px wider (why, Apple, why!?)

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Oh, hmm.  I wonder if the current background looks terrible on Retina Macs?

I guess we should probably open a separate bug for that, because I imagine it's going to be more work (first seeing if a @2x page in a tiff gets used, then redrawing the icon elements of background at double size, etc).

Comment 3

[philippe (part-time)]

( from comment #1)
> I assume Camino 2.1.2 ML looks fine, though (bug 729396)?

Yes the 2.1.2 ML DMG is OK on this machine

> If so, when you get a chance, can you make a wider background (you can
> switch to .png now :-) since we're going to have to regenerate the .DS_Store
> anyway)?  I think we probably want to increase the spacing between the icons
> rather than just adding 26px of "blank" space on each side, though.

OK, I'll make a wider image and play a little with the spacing. 

> (why, Apple, why!?)

Just guessing, HiDPI ?

( from comment #2)
> Oh, hmm.  I wonder if the current background looks terrible on Retina Macs?
> 
> I guess we should probably open a separate bug for that, …

Filed bug 785281 for that part.

Comment 4

[philippe (part-time)]

Attachment: updated background image

* resized the image to 452px wide (and while I was at it, I made the image 100px taller, just in case)
* moved the two blocks of icons to left/right and spaced the icons out a little (similar to the l10n image)

For the benefit of retina displays:
* some very small tweaks to sharpen the background arrows and the ‘eject’ arrow.
There is unfortunately no much more I can do to improve the appearance of the image on retina displays. Rectangular shapes will scale fine, but anything that is not a vertical or horizontal line will show jaggies, although slightly less so with a PNG image than a JPG image. I could make some very small tweaks at the bottom of the disk image on the right, to straighten the lines. That will make those lines darker, though – I’d be fine with that, fwiw; the disk will look crisper on both low and high dpi screens. A real HiDPI image wouldn’t have those problems, but given the issues in bug 785281, that doesn’t seem possible atm.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 655387 [details]
updated background image

This looks good to me; thanks!

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: installer Makefile patch to account for new filename

Switching to a PNG background, so we have to update the Makefile about the new name of the file we're copying…

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: New dsstore

Updated .DS_Store.

1) Uses the new background…
2) At the new size…
3) Moves Camino.app to the new center
4) Splits the additional space between the two text files, so that each file's outside edge is an additional 13px from the dmg edge (vs 100px before).  This keeps all the distances relatively similar, instead of making the inner gap bigger or the edge gaps bigger.

I think that 4 is the right thing to do, but feedback is welcome.

We might also want to consider moving the dmg origin to the left somewhat to account for the new, wider dmg, but it wasn't a core issue, so I didn't do it.

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Screenshot of the new dmg window

For the benefit of anyone who can't build or doesn't want to hassle with the incantations to pkg-dmg, here's what the end result looks like on 10.5 with philippe's new background (attachment 655387 [details]) and my new .DS_Store (attachment 655529 [details]).

Comment 9

[philippe (part-time)]

Comment on attachment 655529 [details]
New dsstore

Looks good on Mountain Lion.

Comment 10

[philippe (part-time)]

Attachment: new DMG window on Mountain Lion

Comment 11

[Stuart Morgan]

Comment on attachment 655527 [details] [diff] [review]
installer Makefile patch to account for new filename

sr=smorgan

Comment 12

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

http://hg.mozilla.org/camino/rev/360db2d64a48 for the philippe's background
http://hg.mozilla.org/camino/rev/bacd0ba987a6 for the rest