Closed Bug 785659 Opened 8 years ago Closed 8 years ago

Get rid of calIRecurrenceDateSet

Categories

(Calendar :: Internal Components, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Fallen, Assigned: Fallen)

References

Details

Attachments

(1 file)

This interface isn't used often and items are usually parsed into multiple EXDATE properties anyway. This will help me transition to using the jsical library in the future.
Attached patch Fix - v1 β€” β€” Splinter Review
Attachment #655366 - Flags: review?(matthew.mecca)
Comment on attachment 655366 [details] [diff] [review]
Fix - v1

Review of attachment 655366 [details] [diff] [review]:
-----------------------------------------------------------------

r=mmecca

::: calendar/providers/storage/calStorageCalendar.js
@@ +1814,4 @@
>          item.setProperty("LAST-MODIFIED", savedLastModifiedTime);
>      },
>  
> +    addRecurrenceItemsFromRow: function cSC_getRecurrenceItemFromRow(row, item) {

I'd suggest cSC_addRecurrenceItemsFromRow for consistency
Attachment #655366 - Flags: review?(matthew.mecca) → review+
(In reply to Matthew Mecca [:mmecca] from comment #2)
> > +    addRecurrenceItemsFromRow: function cSC_getRecurrenceItemFromRow(row, item) {
> 
> I'd suggest cSC_addRecurrenceItemsFromRow for consistency

Nevermind, I see the name changes in Bug 785733
Pushed to comm-central changeset 0e6bba2e7c54
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0
You need to log in before you can comment on or make changes to this bug.