Closed
Bug 785659
Opened 13 years ago
Closed 13 years ago
Get rid of calIRecurrenceDateSet
Categories
(Calendar :: Internal Components, defect)
Calendar
Internal Components
Tracking
(Not tracked)
RESOLVED
FIXED
2.0
People
(Reporter: Fallen, Assigned: Fallen)
References
Details
Attachments
(1 file)
|
27.90 KB,
patch
|
mmecca
:
review+
|
Details | Diff | Splinter Review |
This interface isn't used often and items are usually parsed into multiple EXDATE properties anyway. This will help me transition to using the jsical library in the future.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #655366 -
Flags: review?(matthew.mecca)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 655366 [details] [diff] [review]
Fix - v1
Review of attachment 655366 [details] [diff] [review]:
-----------------------------------------------------------------
r=mmecca
::: calendar/providers/storage/calStorageCalendar.js
@@ +1814,4 @@
> item.setProperty("LAST-MODIFIED", savedLastModifiedTime);
> },
>
> + addRecurrenceItemsFromRow: function cSC_getRecurrenceItemFromRow(row, item) {
I'd suggest cSC_addRecurrenceItemsFromRow for consistency
Attachment #655366 -
Flags: review?(matthew.mecca) → review+
|
|
||
Comment 3•13 years ago
|
||
(In reply to Matthew Mecca [:mmecca] from comment #2)
> > + addRecurrenceItemsFromRow: function cSC_getRecurrenceItemFromRow(row, item) {
>
> I'd suggest cSC_addRecurrenceItemsFromRow for consistency
Nevermind, I see the name changes in Bug 785733
|
|
Assignee | |
Comment 4•13 years ago
|
||
Pushed to comm-central changeset 0e6bba2e7c54
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0
You need to log in
before you can comment on or make changes to this bug.
Description
•