786189 - Make more use of selectedMessageIs

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Ian Neal]

Attachment: Use selectedMessageIs more

Bug 517238 introduced selectedMessageIsNews and selectedMessageIsImap, these both could be used more and functions like IsNewsMessage and IsImapMessage could be removed from mailWindowOverlay.js and also other code simplification. This ports part of Bug 474701.

Brackets after "if (numSelected >= 0)" in mailContextMenus.js have been deliberately left as will be needed again for a follow-up bug.

Comment 1

[[e-mail]]

This works in the standalone message window too?
(Somehow calling it gFolderDisplay looks wrong...)

Comment 2

[Ian Neal]

(In reply to [e-mail] from comment #1)
> This works in the standalone message window too?
> (Somehow calling it gFolderDisplay looks wrong...)

Yes, it does work and yes it does look wrong, but we're stuck with that name to maintain compatibility for extensions.

Comment 3

[[e-mail]]

Comment on attachment 655926 [details] [diff] [review]
Use selectedMessageIs more

>   if (numSelected >= 0)
>   {
>-    selectedMessage = GetFirstSelectedMessage();
>-    isNewsgroup = IsNewsMessage(selectedMessage);
>+    isNewsgroup = gFolderDisplay.selectedMessageIsNews;
>   }
[Weird, why are we checking for numSelected >= 0?]

Comment 4

[Ian Neal]

Attachment: Less numSelected [Checked in: Comment 6]

Changes since last version:
* As selectedMessageIsNews only checks the first selected message no need to check the numSelected.

Comment 5

[[e-mail]]

Comment on attachment 655996 [details] [diff] [review]
Less numSelected [Checked in: Comment 6]

>   var numSelected = GetNumSelectedMessages();
>   var oneOrMore = (numSelected > 0);
>   var single = (numSelected == 1);
[Might it be slightly neater to put isNewsgroup in this block?]

Comment 6

[Ian Neal]

Comment on attachment 655996 [details] [diff] [review]
Less numSelected [Checked in: Comment 6]

Checked in with var isNewsgroup moved to earlier block.
https://hg.mozilla.org/comm-central/rev/c7bf9a085fc4