Infobar reappears on some conditions even in 3D mode.

RESOLVED FIXED in Firefox 17

Status

()

Firefox
Developer Tools: Inspector
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Optimizer, Assigned: paul)

Tracking

unspecified
Firefox 18
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(firefox17 fixed)

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
Created attachment 656394 [details]
Rare screenshot that I captured luckily.

I was playing around with the dev tools and suddenly I found that the infobar has reappeared even in the 3D mode and is not disappearing (except when hovering over style sidebar).

I was able to reproduce it only once thereafter.

It has something to do with the new markup panel (or maybe not). The common things that I did in both the tries was open and close the markup panel once, have Responsive mode on, along with the 3D view.
(Assignee)

Comment 1

5 years ago
STR:

13:25 < victorporof> open inspector
13:25 < victorporof> open tilt
13:25 < victorporof> switch to a different tab
13:25 < victorporof> switch back
13:26 < victorporof> you'll see what happens.
(Assignee)

Updated

5 years ago
Assignee: nobody → paul
Status: NEW → ASSIGNED
(Assignee)

Comment 2

5 years ago
I think this has been fixed by bug 785910 or bug 787952 (can't reproduce when patches applied).

I'll ask you to re-test once those 2 bugs have landed.
(Assignee)

Comment 3

5 years ago
Landed in fx-team. Can someone confirm this is fixed?
(In reply to Paul Rouget [:paul] from comment #3)
> Landed in fx-team. Can someone confirm this is fixed?

Not fixed. I was able to reproduce with the same steps in comment #1.
(Assignee)

Comment 5

5 years ago
To reproduce, the sidebar needs to be open apparently.
(Assignee)

Comment 6

5 years ago
Created attachment 658093 [details] [diff] [review]
v1
(Assignee)

Comment 7

5 years ago
Comment on attachment 658093 [details] [diff] [review]
v1

`show` is now being called by other components, so we can't trust `hide`.
And when we are recreating the highlighter, we were putting it on top of the canvas.

This should work.
Attachment #658093 - Flags: review?(vporof)
Comment on attachment 658093 [details] [diff] [review]
v1

Review of attachment 658093 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!
Attachment #658093 - Flags: review+
(Assignee)

Updated

5 years ago
Whiteboard: [land-in-fx-team]
(Assignee)

Comment 9

5 years ago
https://hg.mozilla.org/integration/fx-team/rev/8518de3a9edf
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/8518de3a9edf
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 18
(Assignee)

Comment 11

5 years ago
Comment on attachment 658093 [details] [diff] [review]
v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 770818
User impact if declined: unexpected UI elements on the 3D inspector
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): low
String or UUID changes made by this patch: no
Attachment #658093 - Flags: review?(vporof) → approval-mozilla-aurora?

Updated

5 years ago
Attachment #658093 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 12

5 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/0a441e2ad8c9
status-firefox17: --- → fixed
You need to log in before you can comment on or make changes to this bug.