786619 - Infobar reappears on some conditions even in 3D mode.

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Girish Sharma [:Optimizer]]

Attachment: Rare screenshot that I captured luckily.

I was playing around with the dev tools and suddenly I found that the infobar has reappeared even in the 3D mode and is not disappearing (except when hovering over style sidebar).

I was able to reproduce it only once thereafter.

It has something to do with the new markup panel (or maybe not). The common things that I did in both the tries was open and close the markup panel once, have Responsive mode on, along with the 3D view.

Comment 1

[Paul Rouget [:paul]]

STR:

13:25 < victorporof> open inspector
13:25 < victorporof> open tilt
13:25 < victorporof> switch to a different tab
13:25 < victorporof> switch back
13:26 < victorporof> you'll see what happens.

Comment 2

[Paul Rouget [:paul]]

I think this has been fixed by bug 785910 or bug 787952 (can't reproduce when patches applied).

I'll ask you to re-test once those 2 bugs have landed.

Comment 3

[Paul Rouget [:paul]]

Landed in fx-team. Can someone confirm this is fixed?

Comment 4

[Victor Porof [:vporof][:vp]]

(In reply to Paul Rouget [:paul] from comment #3)
> Landed in fx-team. Can someone confirm this is fixed?

Not fixed. I was able to reproduce with the same steps in comment #1.

Comment 5

[Paul Rouget [:paul]]

To reproduce, the sidebar needs to be open apparently.

Comment 6

[Paul Rouget [:paul]]

Attachment: v1

Comment 7

[Paul Rouget [:paul]]

Comment on attachment 658093 [details] [diff] [review]
v1

`show` is now being called by other components, so we can't trust `hide`.
And when we are recreating the highlighter, we were putting it on top of the canvas.

This should work.

Comment 8

[Mihai Sucan [:msucan]]

Comment on attachment 658093 [details] [diff] [review]
v1

Review of attachment 658093 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!

Comment 9

[Paul Rouget [:paul]]

https://hg.mozilla.org/integration/fx-team/rev/8518de3a9edf

Comment 10

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/8518de3a9edf

Comment 11

[Paul Rouget [:paul]]

Comment on attachment 658093 [details] [diff] [review]
v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 770818
User impact if declined: unexpected UI elements on the 3D inspector
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): low
String or UUID changes made by this patch: no

Comment 12

[Paul Rouget [:paul]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0a441e2ad8c9