786791 - MSYS mangles the signtool shlibsign cmd with Pymake because it begins with a space

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Rain [:rain1] (inactive)]

Attachment: patch

I wish I were kidding.

Comment 1

[Rain [:rain1] (inactive)]

Checked into build-system pending review: http://hg.mozilla.org/projects/build-system/rev/c85bc58f10ba

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 656558 [details] [diff] [review]
patch

Review of attachment 656558 [details] [diff] [review]:
-----------------------------------------------------------------

This is fine. But, it's only a band-aid. I think a better fix would be for pymake to strip() the first argument. I'm pretty sure there is never a legitimate scenario where the command name or the first argument after |sh -c| would have leading or trailing whitespace.

Comment 3

[Rain [:rain1] (inactive)]

Pymake actually does strip the first argument. This is somewhere deep in the middle of a command, with $(SIGN_CMD) enclosed in quotes and passed as a parameter to a Python command.

Comment 4

[Gregory Szorc [:gps]]

We need a whiteboard annotation for bugs caused by the stupidity that is make.

Comment 5

[Rain [:rain1] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/c85bc58f10ba

Comment 6

[Rain [:rain1] (inactive)]

Comment on attachment 656558 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): not a regression
User impact if declined: we'll still need to keep using GNU make for a year from now
Testing completed (on m-c, etc.): Yes
Risk to taking this patch (and alternatives if risky): Zero risk.
String or UUID changes made by this patch: None

Comment 7

[Alex Keybl [:akeybl]]

Comment on attachment 656558 [details] [diff] [review]
patch

[Triage Comment]
Very low risk, Callek let us know that if anything seems fishy we can easily back this out.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a7b4aedef3fa