Closed Bug 787272 Opened 13 years ago Closed 13 years ago

disable recommend button on logout

Categories

(Firefox Graveyard :: SocialAPI, defect)

Product:
Firefox Graveyard
Component:
SocialAPI
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox17 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 18
Tracking Flags:
Tracking Status
firefox17 --- fixed

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

References

Details

(Whiteboard: [Fx17])

Attachments

(1 file, 1 obsolete file)

minor fix
2.48 KB, patch
mixedpuppy
: review+
Gavin
: approval-mozilla-aurora+
Details | Diff | Splinter Review
providers can specify logged in/out state through the social.user-profile message. We should only enable the recommend button when we have a logged in state. Currently, if you "logout" the recommend button is still available.
Assignee: nobody → mixedpuppy
Attached patch hide share when logged out (obsolete) — — Splinter Review
[Approval Request Comment] social share button should not be displayed if the user is not logged in
Attachment #657368 - Flags: review?(jaws)
Attachment #657368 - Flags: approval-mozilla-aurora?
Comment on attachment 657368 [details] [diff] [review] hide share when logged out Best to avoid asking for aurora approval until you have r+
Attachment #657368 - Flags: approval-mozilla-aurora?
Attachment #657368 - Flags: review?(jaws) → review+
Comment on attachment 657368 [details] [diff] [review] hide share when logged out [Approval Request Comment] need to remove share button when user is not logged in
Attachment #657368 - Flags: approval-mozilla-aurora?
We don't approve for aurora until patches have baked on central for a bit, set 'checkin-needed' in the keywords if you need someone to land this to trunk.
Depends on: 789248
a new try to verify that tests are fixed by bug 789248, which is also showing up under bug 785676. https://tbpl.mozilla.org/?tree=Try&rev=36accc765abd
Attached patch minor fix — — Splinter Review
minor fix on previous patch, carry forward r+
Attachment #657368 - Attachment is obsolete: true
Attachment #657368 - Flags: approval-mozilla-aurora?
Attachment #658984 - Flags: review+
try works with patch in bug 789248
Keywords: checkin-needed
Comment on attachment 658984 [details] [diff] [review] minor fix [Triage Comment]
Attachment #658984 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/ec01a56ff70d
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: