disable recommend button on logout

RESOLVED FIXED in Firefox 17

Status

()

Firefox
SocialAPI
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

Tracking

unspecified
Firefox 18
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(firefox17 fixed)

Details

(Whiteboard: [Fx17])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
providers can specify logged in/out state through the social.user-profile message.  We should only enable the recommend button when we have a logged in state.  Currently, if you "logout" the recommend button is still available.
(Assignee)

Updated

5 years ago
Assignee: nobody → mixedpuppy
(Assignee)

Comment 1

5 years ago
Created attachment 657368 [details] [diff] [review]
hide share when logged out

[Approval Request Comment]
social share button should not be displayed if the user is not logged in
Attachment #657368 - Flags: review?(jaws)
Attachment #657368 - Flags: approval-mozilla-aurora?
Comment on attachment 657368 [details] [diff] [review]
hide share when logged out

Best to avoid asking for aurora approval until you have r+
Attachment #657368 - Flags: approval-mozilla-aurora?
Attachment #657368 - Flags: review?(jaws) → review+
(Assignee)

Comment 3

5 years ago
https://tbpl.mozilla.org/?tree=Try&rev=1b8647eb9f36
(Assignee)

Comment 4

5 years ago
Comment on attachment 657368 [details] [diff] [review]
hide share when logged out

[Approval Request Comment]
need to remove share button when user is not logged in
Attachment #657368 - Flags: approval-mozilla-aurora?
We don't approve for aurora until patches have baked on central for a bit, set 'checkin-needed' in the keywords if you need someone to land this to trunk.
(Assignee)

Updated

5 years ago
Depends on: 789248
(Assignee)

Comment 6

5 years ago
a new try to verify that tests are fixed by bug 789248, which is also showing up under bug 785676.

https://tbpl.mozilla.org/?tree=Try&rev=36accc765abd
(Assignee)

Comment 7

5 years ago
Created attachment 658984 [details] [diff] [review]
minor fix

minor fix on previous patch, carry forward r+
Attachment #657368 - Attachment is obsolete: true
Attachment #657368 - Flags: approval-mozilla-aurora?
Attachment #658984 - Flags: review+
(Assignee)

Comment 8

5 years ago
try works with patch in bug 789248
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/ec01a56ff70d
Keywords: checkin-needed
Comment on attachment 658984 [details] [diff] [review]
minor fix

[Triage Comment]
Attachment #658984 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/ec01a56ff70d
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
https://hg.mozilla.org/releases/mozilla-aurora/rev/586ceed8707b
status-firefox17: --- → fixed
You need to log in before you can comment on or make changes to this bug.