fix failing social tests

RESOLVED FIXED in Firefox 17

Status

()

Firefox
SocialAPI
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

Tracking

unspecified
Firefox 18
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox17 fixed)

Details

(Whiteboard: [Fx17])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Our tests are throwing an exception on social_panel.html accessing mozSocial.  This is caused when our tests remove the test provider prior to the panel finishing it's load.  The test code is setting a status panel during social.initialize, but none of the tests are verifying it is ready or shutdown, except the one test that uses it.

On occasion, it is also showing up during try runs for unrelated social patches.
(Assignee)

Updated

5 years ago
Assignee: nobody → mixedpuppy
Whiteboard: [Fx17]
(Assignee)

Comment 1

5 years ago
Created attachment 658974 [details] [diff] [review]
test fixes

also fixes an https error in local testing when accessing example1.com
Attachment #658974 - Flags: review?(felipc)
(Assignee)

Updated

5 years ago
Blocks: 787272
Attachment #658974 - Flags: review?(felipc) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
(Assignee)

Comment 2

5 years ago
Comment on attachment 658974 [details] [diff] [review]
test fixes

[Approval Request Comment]
fixes tests in aurora
Attachment #658974 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/integration/mozilla-inbound/rev/8fe2906b0cb2
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8fe2906b0cb2
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
Attachment #658974 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/42c27fdb0445
status-firefox17: --- → fixed
You need to log in before you can comment on or make changes to this bug.