Last Comment Bug 789248 - fix failing social tests
: fix failing social tests
Product: Firefox
Classification: Client Software
Component: SocialAPI (show other bugs)
: unspecified
: x86 Mac OS X
-- normal (vote)
: Firefox 18
Assigned To: Shane Caraveo (:mixedpuppy)
: Shane Caraveo (:mixedpuppy)
Depends on:
Blocks: 785676 787272
  Show dependency treegraph
Reported: 2012-09-06 13:13 PDT by Shane Caraveo (:mixedpuppy)
Modified: 2012-09-25 11:40 PDT (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

test fixes (3.25 KB, patch)
2012-09-06 13:16 PDT, Shane Caraveo (:mixedpuppy)
felipc: review+
lukasblakk+bugs: approval‑mozilla‑aurora+
Details | Diff | Splinter Review

Description User image Shane Caraveo (:mixedpuppy) 2012-09-06 13:13:54 PDT
Our tests are throwing an exception on social_panel.html accessing mozSocial.  This is caused when our tests remove the test provider prior to the panel finishing it's load.  The test code is setting a status panel during social.initialize, but none of the tests are verifying it is ready or shutdown, except the one test that uses it.

On occasion, it is also showing up during try runs for unrelated social patches.
Comment 1 User image Shane Caraveo (:mixedpuppy) 2012-09-06 13:16:12 PDT
Created attachment 658974 [details] [diff] [review]
test fixes

also fixes an https error in local testing when accessing
Comment 2 User image Shane Caraveo (:mixedpuppy) 2012-09-06 15:39:10 PDT
Comment on attachment 658974 [details] [diff] [review]
test fixes

[Approval Request Comment]
fixes tests in aurora
Comment 3 User image :Felipe Gomes (needinfo me!) 2012-09-06 16:32:12 PDT
Comment 4 User image Ed Morley [:emorley] 2012-09-07 08:47:52 PDT
Comment 5 User image :Gavin Sharp [email:] 2012-09-25 11:40:03 PDT

Note You need to log in before you can comment on or make changes to this bug.