Closed Bug 789248 Opened 13 years ago Closed 13 years ago

fix failing social tests

Categories

(Firefox Graveyard :: SocialAPI, defect)

Product:
Firefox Graveyard
Component:
SocialAPI
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox17 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 18
Tracking Flags:
Tracking Status
firefox17 --- fixed

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

References

Details

(Whiteboard: [Fx17])

Attachments

(1 file)

test fixes
3.25 KB, patch
Felipe
: review+
lsblakk
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Our tests are throwing an exception on social_panel.html accessing mozSocial. This is caused when our tests remove the test provider prior to the panel finishing it's load. The test code is setting a status panel during social.initialize, but none of the tests are verifying it is ready or shutdown, except the one test that uses it. On occasion, it is also showing up during try runs for unrelated social patches.
Assignee: nobody → mixedpuppy
Whiteboard: [Fx17]
Attached patch test fixes — — Splinter Review
also fixes an https error in local testing when accessing example1.com
Attachment #658974 - Flags: review?(felipc)
Blocks: 787272
Attachment #658974 - Flags: review?(felipc) → review+
Keywords: checkin-needed
Comment on attachment 658974 [details] [diff] [review] test fixes [Approval Request Comment] fixes tests in aurora
Attachment #658974 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/8fe2906b0cb2
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
Attachment #658974 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: