787529 - Use |use 5.10.1| everywhere

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Frédéric Buclin]

For now, I kept say() in the export list of Bugzilla::Util so that other scripts can use it. But this trick fails for at least sanitycheck.cgi while it seems to work fine elsewhere. I'm going to put |use feature ':5.10';| in all Bugzilla scripts so that we can remove this trick.

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

I add |use feature ':5.10';| in all *.cgi, *.pl and *.pm files so that we can load all Perl 5.10 features. This is also required to use parent instead of base. I also removed some useless module loads as well as some obsolete/useless comments which were here since Bugzilla 2.0.

I also added a new test to t/002goodperl.t which makes sure that Perl 5.10 features are loaded for all our scripts and modules. For checksetup.pl, |use 5.10.1| automatically loads all Perl 5.10 features.

This patch doesn't include files in contrib/, extensions/, t/ and xt/. They can be fixed later if we want to.

Comment 2

[Frédéric Buclin]

Attachment: patch, v2

wicked correctly suggested to use |use 5.10.1| instead. This is indeed a good idea as we don't support Perl 5.10.0. And all features available in 5.10.1 will be automatically loaded for us.

Comment 3

[Frédéric Buclin]

Attachment: patch, v2

Slight copy & paste error in Util.pm.

Comment 4

[Teemu Mannermaa (:wicked)]

Comment on attachment 657583 [details] [diff] [review]
patch, v2

Nice cleanup and yes, I do like |use 5.10.1| instead of |use feature| since now we have a clear error message when somebody tries to run our scripts using too old Perl interpreter. With |use feature| there is just a cryptic "can't find feature.pm" that doesn't really help.

Comment 5

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified Bugzilla.pm
modified admin.cgi
modified attachment.cgi
modified buglist.cgi
modified chart.cgi
modified colchange.cgi
modified collectstats.pl
modified config.cgi
modified createaccount.cgi
modified describecomponents.cgi
modified describekeywords.cgi
modified duplicates.cgi
modified editclassifications.cgi
modified editcomponents.cgi
modified editfields.cgi
modified editflagtypes.cgi
modified editgroups.cgi
modified editkeywords.cgi
modified editmilestones.cgi
modified editparams.cgi
modified editproducts.cgi
modified editsettings.cgi
modified editusers.cgi
modified editvalues.cgi
modified editversions.cgi
modified editwhines.cgi
modified editworkflow.cgi
modified email_in.pl
modified enter_bug.cgi
modified importxml.pl
modified index.cgi
modified install-module.pl
modified jobqueue.pl
modified jsonrpc.cgi
modified migrate.pl
modified mod_perl.pl
modified page.cgi
modified post_bug.cgi
modified process_bug.cgi
modified query.cgi
modified quips.cgi
modified relogin.cgi
modified report.cgi
modified reports.cgi
modified request.cgi
modified runtests.pl
modified sanitycheck.cgi
modified sanitycheck.pl
modified search_plugin.cgi
modified show_activity.cgi
modified show_bug.cgi
modified showdependencygraph.cgi
modified showdependencytree.cgi
modified summarize_time.cgi
modified testagent.cgi
modified testserver.pl
modified token.cgi
modified userprefs.cgi
modified votes.cgi
modified whine.pl
modified whineatnews.pl
modified xmlrpc.cgi
modified Bugzilla/Attachment.pm
modified Bugzilla/Auth.pm
modified Bugzilla/Bug.pm
modified Bugzilla/BugMail.pm
modified Bugzilla/BugUrl.pm
modified Bugzilla/CGI.pm
modified Bugzilla/Chart.pm
modified Bugzilla/Classification.pm
modified Bugzilla/Comment.pm
modified Bugzilla/Component.pm
modified Bugzilla/Config.pm
modified Bugzilla/Constants.pm
modified Bugzilla/DB.pm
modified Bugzilla/Error.pm
modified Bugzilla/Extension.pm
modified Bugzilla/Field.pm
modified Bugzilla/Flag.pm
modified Bugzilla/FlagType.pm
modified Bugzilla/Group.pm
modified Bugzilla/Hook.pm
modified Bugzilla/Install.pm
modified Bugzilla/JobQueue.pm
modified Bugzilla/Keyword.pm
modified Bugzilla/Mailer.pm
modified Bugzilla/Migrate.pm
modified Bugzilla/Milestone.pm
modified Bugzilla/Object.pm
modified Bugzilla/Product.pm
modified Bugzilla/RNG.pm
modified Bugzilla/Report.pm
modified Bugzilla/Search.pm
modified Bugzilla/Series.pm
modified Bugzilla/Status.pm
modified Bugzilla/Template.pm
modified Bugzilla/Token.pm
modified Bugzilla/Update.pm
modified Bugzilla/User.pm
modified Bugzilla/UserAgent.pm
modified Bugzilla/Util.pm
modified Bugzilla/Version.pm
modified Bugzilla/WebService.pm
modified Bugzilla/Whine.pm
modified Bugzilla/Attachment/PatchReader.pm
modified Bugzilla/Auth/Login.pm
modified Bugzilla/Auth/Verify.pm
modified Bugzilla/Auth/Login/CGI.pm
modified Bugzilla/Auth/Login/Cookie.pm
modified Bugzilla/Auth/Login/Env.pm
modified Bugzilla/Auth/Login/Stack.pm
modified Bugzilla/Auth/Persist/Cookie.pm
modified Bugzilla/Auth/Verify/DB.pm
modified Bugzilla/Auth/Verify/LDAP.pm
modified Bugzilla/Auth/Verify/RADIUS.pm
modified Bugzilla/Auth/Verify/Stack.pm
modified Bugzilla/BugUrl/Bugzilla.pm
modified Bugzilla/BugUrl/Debian.pm
modified Bugzilla/BugUrl/GitHub.pm
modified Bugzilla/BugUrl/Google.pm
modified Bugzilla/BugUrl/JIRA.pm
modified Bugzilla/BugUrl/Launchpad.pm
modified Bugzilla/BugUrl/MantisBT.pm
modified Bugzilla/BugUrl/SourceForge.pm
modified Bugzilla/BugUrl/Trac.pm
modified Bugzilla/BugUrl/Bugzilla/Local.pm
modified Bugzilla/Config/Admin.pm
modified Bugzilla/Config/Advanced.pm
modified Bugzilla/Config/Attachment.pm
modified Bugzilla/Config/Auth.pm
modified Bugzilla/Config/BugChange.pm
modified Bugzilla/Config/BugFields.pm
modified Bugzilla/Config/Common.pm
modified Bugzilla/Config/Core.pm
modified Bugzilla/Config/DependencyGraph.pm
modified Bugzilla/Config/General.pm
modified Bugzilla/Config/GroupSecurity.pm
modified Bugzilla/Config/LDAP.pm
modified Bugzilla/Config/MTA.pm
modified Bugzilla/Config/PatchViewer.pm
modified Bugzilla/Config/Query.pm
modified Bugzilla/Config/RADIUS.pm
modified Bugzilla/Config/ShadowDB.pm
modified Bugzilla/Config/UserMatch.pm
modified Bugzilla/DB/Mysql.pm
modified Bugzilla/DB/Oracle.pm
modified Bugzilla/DB/Pg.pm
modified Bugzilla/DB/Schema.pm
modified Bugzilla/DB/Sqlite.pm
modified Bugzilla/DB/Schema/Mysql.pm
modified Bugzilla/DB/Schema/Oracle.pm
modified Bugzilla/DB/Schema/Pg.pm
modified Bugzilla/DB/Schema/Sqlite.pm
modified Bugzilla/Field/Choice.pm
modified Bugzilla/Field/ChoiceInterface.pm
modified Bugzilla/Install/CPAN.pm
modified Bugzilla/Install/DB.pm
modified Bugzilla/Install/Filesystem.pm
modified Bugzilla/Install/Localconfig.pm
modified Bugzilla/Install/Requirements.pm
modified Bugzilla/Install/Util.pm
modified Bugzilla/Job/Mailer.pm
modified Bugzilla/JobQueue/Runner.pm
modified Bugzilla/Migrate/Gnats.pm
modified Bugzilla/Search/Clause.pm
modified Bugzilla/Search/Condition.pm
modified Bugzilla/Search/Quicksearch.pm
modified Bugzilla/Search/Recent.pm
modified Bugzilla/Search/Saved.pm
modified Bugzilla/Send/Sendmail.pm
modified Bugzilla/Template/Context.pm
modified Bugzilla/Template/Plugin/Bugzilla.pm
modified Bugzilla/Template/Plugin/Hook.pm
modified Bugzilla/User/Setting.pm
modified Bugzilla/User/Setting/Lang.pm
modified Bugzilla/User/Setting/Skin.pm
modified Bugzilla/User/Setting/Timezone.pm
modified Bugzilla/WebService/Bug.pm
modified Bugzilla/WebService/Bugzilla.pm
modified Bugzilla/WebService/Constants.pm
modified Bugzilla/WebService/Group.pm
modified Bugzilla/WebService/Product.pm
modified Bugzilla/WebService/Server.pm
modified Bugzilla/WebService/User.pm
modified Bugzilla/WebService/Util.pm
modified Bugzilla/WebService/Server/JSONRPC.pm
modified Bugzilla/WebService/Server/XMLRPC.pm
modified Bugzilla/Whine/Query.pm
modified Bugzilla/Whine/Schedule.pm
modified contrib/Bugzilla.pm
modified docs/makedocs.pl
modified docs/lib/Pod/Simple/HTML/Bugzilla.pm
modified docs/lib/Pod/Simple/HTMLBatch/Bugzilla.pm
modified extensions/create.pl
modified t/002goodperl.t
Committed revision 8378.