788109 - Work - Enable 'ui.touch.radius' and remove metrofx specific front end code

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: Input, defect)

Description

[Jim Mathies [:jimm]]

See bug 780847 and ElementTouchHelper in

http://mxr.mozilla.org/projects-central/source/elm/browser/metro/base/content/contenthandlers/Content.js#49

Comment 1

[Matt Brubeck (:mbrubeck)]

Bug 794621 seems to have broken our front-end click redirection code.  Enabling the platform support should fix that regression.  Unfortunately it doesn't seem to be as simple as toggling the pref; when I do that, clicking near a link seems to focus/highlight it, but doesn't actually click it.

Comment 2

[Matt Brubeck (:mbrubeck)]

Actually the preference works fine on most sites, but doesn't work for some reason on http://www.metafilter.com/ which I happened to be using for testing.  Weird!  MetaFilter must be hitting some sort of bug or corner case in the platform code.

Comment 3

[Matt Brubeck (:mbrubeck)]

Attachment: patch

I had to keep our "getClosest" method for now because it's used for tap highlighting, but I changed it to use the same prefs as the platform code.  I'll file a separate follow-up bug to move the tap highlighting into platform.

Comment 4

[Jim Mathies [:jimm]]

Comment on attachment 689436 [details] [diff] [review]
patch

I clicked around on various sites, didn't seem much of a difference in behavior.

FWIW, I'm not a fan of our current highlight behavior anyway. Seems like the aesthetics need work. Usually the highlight is a semi-transparent dark blue rectangular block along the span of text, which looks kinda ugly. Honestly I'd prefer we just turn the highlight off to see how things work without it.

Comment 5

[Jim Mathies [:jimm]]

I'm tempted to to file a bug in dom along the lines of "Improve aesthetics of 'active' state for links for mobile platforms". What do you think Matt?

Comment 6

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/projects/elm/rev/6506c6476906

Comment 7

[Matt Brubeck (:mbrubeck)]

(In reply to Jim Mathies [:jimm] from comment #5)
> I'm tempted to to file a bug in dom along the lines of "Improve aesthetics
> of 'active' state for links for mobile platforms". What do you think Matt?

Yes, please do!

Comment 8

[Jim Mathies [:jimm]]

Attachment: follow up

Comment 9

[Jim Mathies [:jimm]]

https://hg.mozilla.org/projects/elm/rev/7526b43519aa