Closed Bug 788794 Opened 11 years ago Closed 11 years ago

Final basic layers paint goes down cairo slow path on gdi

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla18

People

(Reporter: jrmuizel, Assigned: jrmuizel)

References

(Blocks 1 open bug)

Details

(Whiteboard: [snappy])

Attachments

(1 file, 2 obsolete files)

Use BitBlt to do SOURCE from RGB24 to ARGB32
4.96 KB, patch
nical
: review+
Details | Diff | Splinter Review 
If you look at this profile you can see 36ms being spent doing this copy.

http://people.mozilla.com/~bgirard/cleopatra/?report=c14148bc43065cdfbe10b678cdd3c01ef195e2f6

Not sure why this is happening, but I somewhat suspect ExtendPad is to blame.
Summary: Final basic layers paint goes down cairo slow path → Final basic layers paint goes down cairo slow path on gdi
OS: Mac OS X → Windows XP
Nope. Turns out we're drawing to a ARGB32 DC, on which we try to do a SOURCE operation which isn't supported.
To be specific this is a RGB24 source on to a ARGB32 destination.
Attached patch Proof of concept (obsolete) — — Splinter Review 
This seems to fix the problem. I'll try to measure the improvement.
Whiteboard: [snappy]
Blocks: tabswitch
It looks like an average improvement of about 23x. That should be fine.

        Attachment #659004 -
        Attachment is obsolete: true

        Attachment #659822 -
        Flags: review?

    
  

        Attachment #659822 -
        Flags: review? → review?(nsilva)

    
    

    
  


  
The correct patch

        Attachment #659822 -
        Attachment is obsolete: true

        Attachment #659822 -
        Flags: review?(nsilva)

        Attachment #660199 -
        Flags: review?(nsilva)

        Attachment #660199 -
        Flags: review?(nsilva) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/4a911e226d42
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Depends on: 791708

          You need to log in
          before you can comment on or make changes to this bug.