788794 - Final basic layers paint goes down cairo slow path on gdi

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

If you look at this profile you can see 36ms being spent doing this copy.

http://people.mozilla.com/~bgirard/cleopatra/?report=c14148bc43065cdfbe10b678cdd3c01ef195e2f6

Not sure why this is happening, but I somewhat suspect ExtendPad is to blame.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Nope. Turns out we're drawing to a ARGB32 DC, on which we try to do a SOURCE operation which isn't supported.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

To be specific this is a RGB24 source on to a ARGB32 destination.

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Attachment: Proof of concept

This seems to fix the problem. I'll try to measure the improvement.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

It looks like an average improvement of about 23x. That should be fine.

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Attachment: Use BitBlt to do SOURCE from RGB24 to ARGB32

Comment 6

[Jeff Muizelaar [:jrmuizel]]

Attachment: Use BitBlt to do SOURCE from RGB24 to ARGB32

The correct patch

Comment 7

[Jeff Muizelaar [:jrmuizel]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4a911e226d42

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4a911e226d42