Final basic layers paint goes down cairo slow path on gdi

RESOLVED FIXED in mozilla18

Status

()

Core
Graphics
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jrmuizel, Assigned: jrmuizel)

Tracking

(Blocks: 1 bug)

unspecified
mozilla18
x86
Windows XP
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [snappy])

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
If you look at this profile you can see 36ms being spent doing this copy.

http://people.mozilla.com/~bgirard/cleopatra/?report=c14148bc43065cdfbe10b678cdd3c01ef195e2f6

Not sure why this is happening, but I somewhat suspect ExtendPad is to blame.
(Assignee)

Updated

5 years ago
Summary: Final basic layers paint goes down cairo slow path → Final basic layers paint goes down cairo slow path on gdi
(Assignee)

Updated

5 years ago
OS: Mac OS X → Windows XP
(Assignee)

Comment 1

5 years ago
Nope. Turns out we're drawing to a ARGB32 DC, on which we try to do a SOURCE operation which isn't supported.
(Assignee)

Comment 2

5 years ago
To be specific this is a RGB24 source on to a ARGB32 destination.
(Assignee)

Comment 3

5 years ago
Created attachment 659004 [details] [diff] [review]
Proof of concept

This seems to fix the problem. I'll try to measure the improvement.
(Assignee)

Updated

5 years ago
Whiteboard: [snappy]
(Assignee)

Updated

5 years ago
Blocks: 789573
(Assignee)

Comment 4

5 years ago
It looks like an average improvement of about 23x. That should be fine.
(Assignee)

Comment 5

5 years ago
Created attachment 659822 [details] [diff] [review]
Use BitBlt to do SOURCE from RGB24 to ARGB32
Attachment #659004 - Attachment is obsolete: true
Attachment #659822 - Flags: review?
(Assignee)

Updated

5 years ago
Attachment #659822 - Flags: review? → review?(nsilva)
(Assignee)

Comment 6

5 years ago
Created attachment 660199 [details] [diff] [review]
Use BitBlt to do SOURCE from RGB24 to ARGB32

The correct patch
Attachment #659822 - Attachment is obsolete: true
Attachment #659822 - Flags: review?(nsilva)
Attachment #660199 - Flags: review?(nsilva)

Updated

5 years ago
Attachment #660199 - Flags: review?(nsilva) → review+
(Assignee)

Comment 7

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/4a911e226d42
Assignee: nobody → jmuizelaar

Comment 8

5 years ago
https://hg.mozilla.org/mozilla-central/rev/4a911e226d42
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Depends on: 792993
Depends on: 791708
You need to log in before you can comment on or make changes to this bug.