788928 - B2G SMS: add test cases for nsIDOMSmsManager.ondelivered and nsIDOMSmsRequest.onerror events

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: RIL, defect)

Description

[Vicamo Yang [:vicamo][:vyang]]

See review comments in bug 787370. The Android emulator doesn't have SMS-STATUS-REPORT unsolicited event implemented, but we might still need it to verify SMS ondelivered event.

Comment 1

[Vicamo Yang [:vicamo][:vyang]]

Marshall mentioned a technique to insert arbitrary SMS PDU into emulator in bug 787370 comment #18. Code examples are here:
http://dxr.mozilla.org/mozilla-central/dom/telephony/test/marionette/pdu_builder.js.html
http://dxr.mozilla.org/mozilla-central/dom/telephony/test/marionette/test_voicemail_statuschanged.js.html#l10

Comment 2

[Vicamo Yang [:vicamo][:vyang]]

(In reply to Vicamo Yang [:vicamo][:vyang] from comment #1)
> Marshall mentioned a technique to insert arbitrary SMS PDU into emulator in
> bug 787370 comment #18. Code examples are here:
> http://dxr.mozilla.org/mozilla-central/dom/telephony/test/marionette/
> pdu_builder.js.html
> http://dxr.mozilla.org/mozilla-central/dom/telephony/test/marionette/
> test_voicemail_statuschanged.js.html#l10

Actually, `sms pdu` command alone can't accomplish the purpose here. SMS-STATUS-REPORT contains a TP-MR field that is used to pair sent message with the report itself. However, the value is currently an internal state of the emulator and there is no emulator command to fetch it.

To solve this issue, you'll either 1) make the emulator send a pre-configured[1] status-report status(TP-ST) to every outgoing sms, or 2) ask emulator the latest used TP-MR value and construct SMS-STATUS-REPORT PDUs with it. In either way, you'll still have to modify emulator code. The second method provides much more flexibility than the first one.

[1]: or, we may always return "destination unreachable", and "success" for inter emulator instances communication.

Comment 3

[Vicamo Yang [:vicamo][:vyang]]

I think I'll really need this feature to help verifying delivery events :(

Comment 4

[Vicamo Yang [:vicamo][:vyang]]

Attachment: Github Pull Request for hardware/ril

Comment 5

[Vicamo Yang [:vicamo][:vyang]]

Attachment: Github WIP branch for external/qemu

Comment 6

[Vicamo Yang [:vicamo][:vyang]]

Attachment: Github Pull Request for external/qemu

Comment 7

[Vicamo Yang [:vicamo][:vyang]]

Attachment: marionette test case : WIP

test cases for request.onerror

Comment 8

[Ken Chang[:kenkai]]

Please this into backlog.

Comment 9

[BMO Automation]

Firefox OS is not being worked on