789687 - update harfbuzz to release 0.9.4 (or later)

Status: RESOLVED FIXED

(Core :: Graphics: Text, defect)

Description

[Jonathan Kew [:jfkthame]]

We should take a further harfbuzz update soon, now that it includes support for dotted-circle insertion in "broken" sequences (e.g. diacritics without base).

Comment 1

[Behdad Esfahbod]

When you are ready to refresh, let me know and I'll roll a new release as I want to get testing for the synthetic GSUB stuff that was done post 0.9.4.

Comment 2

[Mathieu Pellerin]

Can this be considered before end of version 18 cycle? Version 17 included initial support for Indic script, it'd be nice to have it completed by next version.

Comment 3

[Jonathan Kew [:jfkthame]]

Attachment: patch, update harfbuzz to commit f2eb3fa9dca8d21fae20c9b9dddad3245df74a05

This updates harfbuzz to commit f2eb3fa9dca8d21fae20c9b9dddad3245df74a05 (dated Sept 25). I ran reftests on tryserver to check that nothing untoward happens: https://tbpl.mozilla.org/?tree=Try&rev=1a69056dcc86.

(If Behdad puts out a new release this week, we can take that instead of this commit, but it won't be substantially different from this.)

Comment 4

[Mathieu Pellerin]

Jonathan, I noticed v18 moved to Aurora. Is there any way this harfbuzz update can be applied on Aurora? As mentioned above, it's the only key piece missing for proper indic script support.

Comment 5

[Jonathan Kew [:jfkthame]]

(In reply to Mathieu Pellerin from comment #4)
> Jonathan, I noticed v18 moved to Aurora. Is there any way this harfbuzz
> update can be applied on Aurora? As mentioned above, it's the only key piece
> missing for proper indic script support.

Yeah, I was hoping this would land before the uplift, but it didn't get r+'d in time. :( I'm about to push this to inbound today.

I'd suggest that in a couple of days, once it's merged to mozilla-central and we see no ill effects in Nightly (I trust!), you try nominating the patch for Aurora, with an explanation of why it's important, and see what the product drivers decide.

Comment 6

[Mathieu Pellerin]

Jonathan, a commit was pushed onto harfbuzz that has the word "fixup" as well as "broke" and "ouch!" (http://cgit.freedesktop.org/harfbuzz/commit/?id=fecdfa95daf4916695f23e7dab89ab363be11b89). 

If it doesn't delay an upgrade to harfbuzz in inbound, might be word making a new patch to upgrade to this latest commit.

Comment 7

[Jonathan Kew [:jfkthame]]

Yes, I'm aware of that - though it doesn't actually affect our HB usage. :) But in any case, I'm currently testing a rebased patch that includes the latest few fixes from upstream.

Comment 8

[Jonathan Kew [:jfkthame]]

Updated to upstream commit fecdfa95daf4916695f23e7dab89ab363be11b89, carrying forward r=jdaggett; pushed to inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/550038369ab1

Comment 9

[Behdad Esfahbod]

Yeah, that fixup does not affect the shaping at all.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/550038369ab1