Closed
Bug 7913
Opened 27 years ago
Closed 26 years ago
Dynamic changing of ROWS and COLS
Categories
(Core :: Layout: Images, Video, and HTML Frames, defect, P3)
Core
Layout: Images, Video, and HTML Frames
Tracking
()
VERIFIED
FIXED
M18
People
(Reporter: pollmann, Assigned: pollmann)
References
Details
(Keywords: relnote, Whiteboard: [nsbeta3+][DONTTEST] fix in hand)
Attachments
(1 file)
|
33.85 KB,
patch
|
Details | Diff | Splinter Review |
Need to hack this into the frameset reflow method.
Updated•27 years ago
|
QA Contact: beppe → petersen
Updated•26 years ago
|
Whiteboard: [DONTTEST]
Comment 1•26 years ago
|
||
Marking [DONTTEST].
Comment 2•26 years ago
|
||
Bulk moving old [donttest] code to new donttest keyword. Sorry for the spam!
Keywords: donttest
| Assignee | ||
Comment 6•26 years ago
|
||
This bug has been marked "future" because the original netscape engineer working
on this is over-burdened. If you feel this is an error, that you or another
known resource will be working on this bug,or if it blocks your work in some way
-- please attach your concern to the bug for reconsideration.
Target Milestone: M20 → Future
Comment 8•26 years ago
|
||
This feature is very interesting for pre-loading all frames. This allow to
accelerate navigation in a site. We use it on a intranet service for limit the
stress of the server during a session. I think it's a good feature. And I have a
very big application to convert ! (IE5/PC -> Mozilla/MAC)
| Assignee | ||
Comment 10•26 years ago
|
||
It turns out that all the work that needs to be done for the content side of
things is in place. However, the big chunk that needs to be bitten off is the
frameset reflow method. I did an initial pass at this a while back and it was a
significant amount of work. I'll attach the patch I came up with then (will
probably out of date, but provide hints to the solution).
| Assignee | ||
Comment 11•26 years ago
|
||
| Assignee | ||
Comment 12•26 years ago
|
||
I think the main thing missing from the patch is setting border sizes and
colors. Since this was a regression, and more important work came up, I never
checked in the patch.
| Assignee | ||
Comment 13•26 years ago
|
||
This quick hack will also do the trick, but might lead to page reloading:
Index: nsHTMLFrameSetElement.cpp
===================================================================
RCS file: /cvsroot/mozilla/layout/html/content/src/nsHTMLFrameSetElement.cpp,v
retrieving revision 1.25
diff -u -r1.25 nsHTMLFrameSetElement.cpp
--- nsHTMLFrameSetElement.cpp 2000/05/10 13:13:14 1.25
+++ nsHTMLFrameSetElement.cpp 2000/07/14 03:02:58
@@ -180,7 +180,7 @@
{
if ((aAttribute == nsHTMLAtoms::rows) ||
(aAttribute == nsHTMLAtoms::cols)) {
- aHint = NS_STYLE_HINT_REFLOW;
+ aHint = NS_STYLE_HINT_FRAMECHANGE;
}
else if (! nsGenericHTMLElement::GetCommonMappedAttributesImpact(aAttribute,
aHint)) {
aHint = NS_STYLE_HINT_CONTENT;
I think that it might be a reasonable thing to check this hack in because it
enables the feature, and worry about fine tuning performance later.
Whiteboard: [DONTTEST] → [DONTTEST] fix in hand
Target Milestone: Future → M17
| Assignee | ||
Comment 14•26 years ago
|
||
(updating mutiple bugs)
Nominating this bug for beta3 because it is either a crasher or a correctness
bug and I have a straightforward fix in hand. This bug fix is small, low risk,
and can easily be reverted with no side effects.
Keywords: nsbeta3
Comment 15•26 years ago
|
||
relnote. May be performance issues when using this
Keywords: relnote
Whiteboard: [DONTTEST] fix in hand → [nsbeta3+][DONTTEST] fix in hand
| Assignee | ||
Comment 16•26 years ago
|
||
The fix has been checked in. Cooking up a testcase to assist with verification.
Status: ASSIGNED → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
Comment 17•26 years ago
|
||
Eric,
Need to verify. Let me know when test case is ready.
| Assignee | ||
Comment 18•26 years ago
|
||
Test case is available here:
http://blueviper.mcom.com/frames/rowchange.html
Sorry it took so long to get this one up - as a warning, the fix used here is
*really* slow, but the size change should still happen... :)
| Assignee | ||
Comment 20•26 years ago
|
||
As noticed on bug 48433, this was actually fixed in M18.
Target Milestone: M17 → M18
| Assignee | ||
Comment 21•26 years ago
|
||
s/48433/48422/;
Updated•8 years ago
|
Product: Core → Core Graveyard
Updated•8 years ago
|
Component: Layout: HTML Frames → Layout: Images
Product: Core Graveyard → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•