791338 - Firefox does not scroll screen to show cursor for contenteditable elements in iframe

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[radarxc]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.1 (KHTML, like Gecko) Chrome/21.0.1180.89 Safari/537.1

Steps to reproduce:

Go to http://www.tinymce.com/tryit/full.php
Click on the contenteditable element.



Actual results:

Android software keyboard covers up contenteditable element and the blinking text cursor.


Expected results:

The website is scrolled so that the blinking text cursor is visible within the lessened screen space, which is the same behavior that occurs for input box elements.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

What version of Firefox for Android are you seeing this on? It should have been fixed in bug 785520.

Comment 2

[radarxc]

(In reply to Kartikaya Gupta (:kats) from comment #1)
> What version of Firefox for Android are you seeing this on? It should have
> been fixed in bug 785520.

Firefox 18 in Android(fennec-18) 
Actually, I update the patch for bug 785520. However, it still does not work for the contenteditable elements in iframe.
If contenteditable in a iframe, the var focused will be an iframe rather than instance of HTMLTextarea or any other input tag instance. So maybe this is the problem.

Comment 3

[Martijn Wargers (dead)]

Related to bug 793677?

Comment 4

[Aaron Train [:aaronmt]]

I can reproduce with the aforementioned URL on Nightly (09/24).

Comment 5

[Kartikaya Gupta (email:[e-mail])]

I can also reproduce this. I'll take a look once my build is done (i.e. probably tomorrow).

Comment 6

[Kartikaya Gupta (email:[e-mail])]

While trying to fix this I found a regression from bug 727352. Patch for the regression coming, and I have this bug almost working as well.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Attachment: Part 1 - Fix regression from JSON conversion

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Attachment: Part 2 - Do a better job of scrolling-into-view editable elements inside frames

Comment 9

[Chris Lord [:cwiiis]]

Comment on attachment 664634 [details] [diff] [review]
Part 2 - Do a better job of scrolling-into-view editable elements inside frames

Review of attachment 664634 [details] [diff] [review]:
-----------------------------------------------------------------

Looks alright to me - I'll trust your comment about the better UX :)

::: mobile/android/chrome/content/browser.js
@@ -985,5 @@
>  
>        // tell gecko to scroll the field into view. this will scroll any nested scrollable elements
>        // as well as the browser's content window, and modify the scrollX and scrollY on the content window.
>        focused.scrollIntoView(false);
> -

Any reason for getting rid of this blank line?

Comment 10

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 664623 [details] [diff] [review]
Part 1 - Fix regression from JSON conversion

I'm moving this first patch over to bug 793677 which specifically tracks the regression. Carrying the r+ over there too.

Comment 11

[Kartikaya Gupta (email:[e-mail])]

(In reply to Chris Lord [:cwiiis] from comment #9)
> 
> Any reason for getting rid of this blank line?

Whoops, accident. I put it back in and landed on inbound:

https://hg.mozilla.org/integration/mozilla-inbound/rev/e305a1b3a777

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e305a1b3a777

Comment 13

[Aaron Train [:aaronmt]]

Is Aurora affected here?

Comment 14

[Kartikaya Gupta (email:[e-mail])]

Yeah, I think all versions back to 14 will be affected. It's not a regression, just a bug we've had since initial implementation.