793677 - Text field does not jump in to view when tapped

Status: VERIFIED FIXED

(Firefox for Android :: General, defect)

Description

[Andreea Pod]

Build: Firefox 18.0a1 (2012-09-23)
Device: Samsung Galaxy Nexus
OS: Android 4.1.1

Steps to reproduce: 
1. go to bugzilla.mozilla.org > Advanced Search
2. open Detailed Bug Information 
3. tap on the text field next to Keywords

Expected result:
- the page should scroll until the text field is over the keyboard allowing you to see the text field and what you write

Actual result:
- text field is covered by the keyboard and you are not able to see what you write

Comment 1

[Aaron Train [:aaronmt]]

Can you reproduce this on any other page other than Bugzilla?

Comment 2

[Andreea Pod]

Yes, on this page also:  http://www-archive.mozilla.org/quality/browser/front-end/testcases/wallet/login.html (http://goo.gl/vi7z6)

Comment 3

[Aaron Train [:aaronmt]]

Is this a regression?

Kats, has scrollIntoView behaviour changed? I remember a bug similar to this fixed many months ago.

Comment 4

[Kartikaya Gupta (email:[e-mail]) (away until Feb-2020)]

Looks like a regression, yes. I haven't touched this behaviour in a while and I don't think anybody else has either. Can we get a regression range?

Comment 5

[Andreea Pod]

Last good build is Nightly 18.0a1 from 2012-09-21
http://hg.mozilla.org/mozilla-central/rev/48c4938eaf57

First bad build is Nightly 18.0a1 from 2012-09-22
http://hg.mozilla.org/mozilla-central/rev/9cfb80a82883


http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=48c4938eaf57&tochange=9cfb80a82883

Comment 6

[Kartikaya Gupta (email:[e-mail]) (away until Feb-2020)]

Maybe this?

c0ccd183b276 Brad Lassey — bug 727352 - don't use JSON for viewport meta data r=kats,mfinkle

It would be good to bisect on inbound to narrow down the range further.

Comment 7

[Andreea Pod]

Last good build in inbound 20120919104357
http://hg.mozilla.org/integration/mozilla-inbound/rev/d71ef24d5b56

First bad build in inbound 20120919111757
http://hg.mozilla.org/integration/mozilla-inbound/rev/45a10fa9d60b


http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d71ef24d5b56&tochange=45a10fa9d60b

Comment 8

[Kartikaya Gupta (email:[e-mail]) (away until Feb-2020)]

(In reply to Andreea Pod from comment #7)
> http://hg.mozilla.org/mozilla-central/
> pushloghtml?fromchange=d71ef24d5b56&tochange=45a10fa9d60b

That should be http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=d71ef24d5b56&tochange=45a10fa9d60b

But thanks, that confirms that this is a regression from bug 727352. I have a patch that fixes it on bug 791338 but I'll move that over to this bug as it's more appropriate here.

Comment 9

[Kartikaya Gupta (email:[e-mail]) (away until Feb-2020)]

Attachment: Patch moved over from bug 791338

Moving the patch at https://bugzilla.mozilla.org/attachment.cgi?id=664623&action=edit to this bug. Carrying the r+ since blassey already reviewed it, and updated the bug number.

Comment 10

[Kartikaya Gupta (email:[e-mail]) (away until Feb-2020)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d0f31c494c68

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d0f31c494c68

Comment 12

[Aaron Train [:aaronmt]]

Is Aurora affected here?

Comment 13

[Kartikaya Gupta (email:[e-mail]) (away until Feb-2020)]

No, this one is a regression in 18 only.