[MP] Story - Search defaults for v1

VERIFIED FIXED in Firefox 27

Status

defect
P2
normal
VERIFIED FIXED
7 years ago
5 years ago

People

(Reporter: jimm, Assigned: bbondy)

Tracking

Trunk
Firefox 27
x86_64
Windows 8.1
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [l10n] [preview] feature=story c=firefox_app_bar_and_autocomplete u=metro_firefox_user p=1)

Attachments

(2 attachments, 2 obsolete attachments)

Reporter

Description

7 years ago
Just want to be sure these are set appropriately:

keyword search from the address bar:
google

search engine list on the awesome screen:
google
amazon
bing
ebay
twitter
wikipedia
yahoo
Assigning to Asa to verify whether our current settings (comment 0) are correct or to determine any changes we need to make.
Assignee: nobody → asa
Reporter

Comment 2

7 years ago
Posted file current plugins zip
Please strip out the channel parameters from the Google Firefox search plugin and replace client=firefox with client=metrofirefox
Reporter

Updated

7 years ago
Whiteboard: metro-preview → metro-beta, mc-merge
Reporter

Updated

7 years ago
Product: Firefox → Firefox for Metro
Whiteboard: metro-beta, mc-merge → [metro-mvp], mc-merge
Reporter

Updated

7 years ago
Whiteboard: [metro-mvp], mc-merge → [metro-mvp], mc-merge, LOE:-

Updated

7 years ago
Whiteboard: [metro-mvp], mc-merge, LOE:- → [metro-mvp] [LOE:-] mc-merge

Updated

7 years ago
Blocks: 831903
Whiteboard: [metro-mvp] [LOE:-] mc-merge → [metro-mvp] [LOE:-] mc-merge feature=work c=navigation_app_bar_autocomplete
Summary: Define search preferences in metrofx → Work - Define search preferences in metrofx
Whiteboard: [metro-mvp] [LOE:-] mc-merge feature=work c=navigation_app_bar_autocomplete → [mc-merge] feature=work
For Asa to follow up on in the near future.
Flags: needinfo?(asa)
I've converted this to a story.

Story: as a Metro Firefox user, I have quick and easy access to search services including Bing, Google, Yahoo, and Wikipedia

Flow: 

1. A Metro Firefox user opens a new tab, types in the string "moz" and sees a list of available search engines. 
2. The user looks over the list and sees these services in this order
2a. Bing
2b. Google
2c. Yahoo
2d. Wikipedia
Blocks: 831671
Flags: needinfo?(asa)
Summary: Work - Define search preferences in metrofx → Story - Search defaults for v1
Whiteboard: [mc-merge] feature=work → [mc-merge] feature=story
Blocks: metrov1backlog
No longer blocks: 831903
Whiteboard: [mc-merge] feature=story → [mc-merge] feature=story c=firefox_app_bar_and_autocomplete u=metro_firefox_user p=0
Priority: -- → P2
Depends on: 823541
Depends on: 871806
Blocks: metrov1planning
No longer blocks: metrov1backlog
Reporter

Updated

6 years ago
Whiteboard: [mc-merge] feature=story c=firefox_app_bar_and_autocomplete u=metro_firefox_user p=0 → [preview]
Reporter

Updated

6 years ago
No longer depends on: 823541, 871806
Summary: Story - Search defaults for v1 → [MP] Story - Search defaults for v1
Whiteboard: [preview] → [preview] feature=story c=tbd u=tbd p=0
Whiteboard: [preview] feature=story c=tbd u=tbd p=0 → [preview] feature=story c=firefox_app_bar_and_autocomplete u=metro_firefox_user p=0
Whiteboard: [preview] feature=story c=firefox_app_bar_and_autocomplete u=metro_firefox_user p=0 → [l10n] [preview] feature=story c=firefox_app_bar_and_autocomplete u=metro_firefox_user p=0
Assignee

Updated

6 years ago
Assignee: asa → netzen
Blocks: metrov1it15
No longer blocks: metrov1backlog
Status: NEW → ASSIGNED
Assignee

Updated

6 years ago
Whiteboard: [l10n] [preview] feature=story c=firefox_app_bar_and_autocomplete u=metro_firefox_user p=0 → [l10n] [preview] feature=story c=firefox_app_bar_and_autocomplete u=metro_firefox_user p=1
QA Contact: jbecerra
Assignee

Comment 6

6 years ago
Posted patch Patch v1. (obsolete) — Splinter Review
Attachment #804815 - Flags: review?(jmathies)
Reporter

Comment 7

6 years ago
This was originally assigned to Asa due to legal concerns. Did a final decision get made?
Assignee

Comment 8

6 years ago
Not sure, but Comment 5 defines a story to implement, so that's what I did :)
Asa if no decision has been made here and Comment 5 is invalid, please feel free to re-take the bug.
Reporter

Comment 9

6 years ago
(In reply to Brian R. Bondy [:bbondy] from comment #8)
> Not sure, but Comment 5 defines a story to implement, so that's what I did :)
> Asa if no decision has been made here and Comment 5 is invalid, please feel
> free to re-take the bug.

Yeah I think this is on hold until legal decides exactly what metrofx is. :)
Assignee

Comment 10

6 years ago
Alright, I seen that the bug needinfo'd Asa on 2013-04-08 and then he replied with a story a week later, so I assumed he had obtained he information he needed and had a story.  I still think that may be the case, but I'll assign it to Asa to be sure.
Assignee: netzen → asa
Sorry I didn't get back sooner. We're good to go here with the story as written in comment 5.
Back to Brian based on Comment #11 from Asa.
Assignee: asa → netzen
Assignee

Comment 13

6 years ago
Thanks for the quick reply.

Jim I have a change coming for a client=metrofirefox parameter, I just removed it in the last patch.
Assignee

Comment 14

6 years ago
Posted patch Patch v2. (obsolete) — Splinter Review
Attachment #804815 - Attachment is obsolete: true
Attachment #804815 - Flags: review?(jmathies)
Attachment #804824 - Flags: review?(jmathies)
Reporter

Comment 15

6 years ago
Comment on attachment 804815 [details] [diff] [review]
Patch v1.

WFM if Asa says the order is ok.
Attachment #804815 - Flags: review+
Reporter

Updated

6 years ago
Attachment #804824 - Flags: review?(jmathies) → review+
Assignee

Comment 16

6 years ago
Yep order matches what is given in the story:
Bing, Google, Yahoo, Wikipedia

But order is top to bottom, left to right so it looks like:
> Bing    Yahoo
> Google  Wikipedia
Since there is room for 2 on each column.
Assignee

Comment 17

6 years ago
Comment on attachment 804824 [details] [diff] [review]
Patch v2.

Causing a test failure, will upload a new patch when fixed.
Attachment #804824 - Flags: review+
Assignee

Comment 18

6 years ago
Posted patch Patch v3Splinter Review
Same as the last patch but when it's called for desktop front end it won't use metrolist.txt it'll use list.txt for the search plugins.
Attachment #804824 - Attachment is obsolete: true
Attachment #805374 - Flags: review?(jmathies)
Reporter

Comment 19

6 years ago
Comment on attachment 805374 [details] [diff] [review]
Patch v3

Review of attachment 805374 [details] [diff] [review]:
-----------------------------------------------------------------

Is |client=metrofirefox| the right value? (I have no idea what this should be.)
Attachment #805374 - Flags: review?(jmathies) → review+
(In reply to Jim Mathies [:jimm] from comment #19)
> Comment on attachment 805374 [details] [diff] [review]
> Patch v3
> 
> Review of attachment 805374 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Is |client=metrofirefox| the right value? (I have no idea what this should
> be.)


I'll get an update from legal and if we need to  change, we will.  We should go ahead and land what we have.
Assignee

Comment 21

6 years ago
Yep see comment 3.
Assignee

Comment 22

6 years ago
oops just seen asa's last comment, yep I'll land it and re-update via another bug if needed.
Assignee

Updated

6 years ago
Keywords: checkin-needed
Assignee

Comment 23

6 years ago
https://hg.mozilla.org/integration/fx-team/rev/330f82b3ddbd
Keywords: checkin-needed
Target Milestone: --- → Firefox 27
https://hg.mozilla.org/mozilla-central/rev/330f82b3ddbd
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Verified as fixed, for iteration #15, with latest Nightly on Win 8 64-bit.

I get the same results as from comment 16.
Status: RESOLVED → VERIFIED
Should have had build peer review
Flags: needinfo?(netzen)
Assignee

Comment 27

6 years ago
Comment on attachment 805374 [details] [diff] [review]
Patch v3

This is already landed but based on your feedback, if needed, I'll do a followup patch. Ms2ger let me know this should have been reviewed by a build peer. Thanks.
Attachment #805374 - Flags: review?(khuey)
Assignee

Updated

6 years ago
Flags: needinfo?(netzen)
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.