Closed Bug 791706 Opened 11 years ago Closed 10 years ago

[MP] Story - Search defaults for v1

Categories

(Firefox for Metro Graveyard :: General, defect, P2)

Product:
Firefox for Metro Graveyard
Component:
General
Platform:
x86_64
Windows 8.1
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
Firefox 27

People

(Reporter: jimm, Assigned: bbondy)

References

Details

(Whiteboard: [l10n] [preview] feature=story c=firefox_app_bar_and_autocomplete u=metro_firefox_user p=1)

Attachments

(2 files, 2 obsolete files)

current plugins zip
10.88 KB, application/x-zip-compressed
Details
Patch v3
4.12 KB, patch
jimm
: review+
khuey
: review+
Details | Diff | Splinter Review 
Just want to be sure these are set appropriately:

keyword search from the address bar:
google

search engine list on the awesome screen:
google
amazon
bing
ebay
twitter
wikipedia
yahoo
Assigning to Asa to verify whether our current settings (comment 0) are correct or to determine any changes we need to make.
Assignee: nobody → asa
Attached file current plugins zip — 

    
    

    
  
Please strip out the channel parameters from the Google Firefox search plugin and replace client=firefox with client=metrofirefox

    
  
Whiteboard: metro-preview → metro-beta, mc-merge

    
  
Product: Firefox → Firefox for Metro

    
  
Whiteboard: metro-beta, mc-merge → [metro-mvp], mc-merge

    
  
Whiteboard: [metro-mvp], mc-merge → [metro-mvp], mc-merge, LOE:-

    
  
Whiteboard: [metro-mvp], mc-merge, LOE:- → [metro-mvp] [LOE:-] mc-merge

    
  
Blocks: 831903
Whiteboard: [metro-mvp] [LOE:-] mc-merge → [metro-mvp] [LOE:-] mc-merge feature=work c=navigation_app_bar_autocomplete
Summary: Define search preferences in metrofx → Work - Define search preferences in metrofx
Whiteboard: [metro-mvp] [LOE:-] mc-merge feature=work c=navigation_app_bar_autocomplete → [mc-merge] feature=work

    
    

    
  
For Asa to follow up on in the near future.
Flags: needinfo?(asa)

    
    

    
  
I've converted this to a story.

Story: as a Metro Firefox user, I have quick and easy access to search services including Bing, Google, Yahoo, and Wikipedia

Flow: 

1. A Metro Firefox user opens a new tab, types in the string "moz" and sees a list of available search engines. 
2. The user looks over the list and sees these services in this order
2a. Bing
2b. Google
2c. Yahoo
2d. Wikipedia
Blocks: 831671
Flags: needinfo?(asa)
Summary: Work - Define search preferences in metrofx → Story - Search defaults for v1
Whiteboard: [mc-merge] feature=work → [mc-merge] feature=story
Blocks: metrov1backlog
No longer blocks: 831903
Whiteboard: [mc-merge] feature=story → [mc-merge] feature=story c=firefox_app_bar_and_autocomplete u=metro_firefox_user p=0
Priority: -- → P2
Depends on: 823541
Depends on: 871806
Blocks: metrov1planning
No longer blocks: metrov1backlog

    
  
Whiteboard: [mc-merge] feature=story c=firefox_app_bar_and_autocomplete u=metro_firefox_user p=0 → [preview]

    
  
No longer depends on: 823541, 871806
Summary: Story - Search defaults for v1 → [MP] Story - Search defaults for v1
Whiteboard: [preview] → [preview] feature=story c=tbd u=tbd p=0
Blocks: MetroPreviewRelease, metrov1backlog
No longer blocks: metrov1planning
Whiteboard: [preview] feature=story c=tbd u=tbd p=0 → [preview] feature=story c=firefox_app_bar_and_autocomplete u=metro_firefox_user p=0
Whiteboard: [preview] feature=story c=firefox_app_bar_and_autocomplete u=metro_firefox_user p=0 → [l10n] [preview] feature=story c=firefox_app_bar_and_autocomplete u=metro_firefox_user p=0

    
  
Assignee: asa → netzen
Blocks: metrov1it15
No longer blocks: metrov1backlog
Status: NEW → ASSIGNED

    
  
Whiteboard: [l10n] [preview] feature=story c=firefox_app_bar_and_autocomplete u=metro_firefox_user p=0 → [l10n] [preview] feature=story c=firefox_app_bar_and_autocomplete u=metro_firefox_user p=1
QA Contact: jbecerra

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch v1. (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #804815 -
        Flags: review?(jmathies)

    
    

    
  
This was originally assigned to Asa due to legal concerns. Did a final decision get made?

    
    

    
  
Not sure, but Comment 5 defines a story to implement, so that's what I did :)
Asa if no decision has been made here and Comment 5 is invalid, please feel free to re-take the bug.

    
    

    
  
(In reply to Brian R. Bondy [:bbondy] from comment #8)
> Not sure, but Comment 5 defines a story to implement, so that's what I did :)
> Asa if no decision has been made here and Comment 5 is invalid, please feel
> free to re-take the bug.

Yeah I think this is on hold until legal decides exactly what metrofx is. :)

    
    

    
  
Alright, I seen that the bug needinfo'd Asa on 2013-04-08 and then he replied with a story a week later, so I assumed he had obtained he information he needed and had a story.  I still think that may be the case, but I'll assign it to Asa to be sure.
Assignee: netzen → asa

    
    

    
  
Sorry I didn't get back sooner. We're good to go here with the story as written in comment 5.

    
    

    
  
Back to Brian based on Comment #11 from Asa.
Assignee: asa → netzen

    
    

    
  
Thanks for the quick reply.

Jim I have a change coming for a client=metrofirefox parameter, I just removed it in the last patch.

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch v2. (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #804815 -
        Attachment is obsolete: true

        Attachment #804815 -
        Flags: review?(jmathies)

        Attachment #804824 -
        Flags: review?(jmathies)

    
    

    
  
Comment on attachment 804815 [details] [diff] [review]
Patch v1.

WFM if Asa says the order is ok.

        Attachment #804815 -
        Flags: review+

    
  

        Attachment #804824 -
        Flags: review?(jmathies) → review+

    
    

    
  
Yep order matches what is given in the story:
Bing, Google, Yahoo, Wikipedia

But order is top to bottom, left to right so it looks like:
> Bing    Yahoo
> Google  Wikipedia
Since there is room for 2 on each column.

    
    

    
  
Comment on attachment 804824 [details] [diff] [review]
Patch v2.

Causing a test failure, will upload a new patch when fixed.

        Attachment #804824 -
        Flags: review+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch v3
        — 
          — Splinter Review
      

    


  
Same as the last patch but when it's called for desktop front end it won't use metrolist.txt it'll use list.txt for the search plugins.

        Attachment #804824 -
        Attachment is obsolete: true

        Attachment #805374 -
        Flags: review?(jmathies)

    
    

    
  
Comment on attachment 805374 [details] [diff] [review]
Patch v3

Review of attachment 805374 [details] [diff] [review]:
-----------------------------------------------------------------

Is |client=metrofirefox| the right value? (I have no idea what this should be.)

        Attachment #805374 -
        Flags: review?(jmathies) → review+

    
    

    
  
(In reply to Jim Mathies [:jimm] from comment #19)
> Comment on attachment 805374 [details] [diff] [review]
> Patch v3
> 
> Review of attachment 805374 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Is |client=metrofirefox| the right value? (I have no idea what this should
> be.)


I'll get an update from legal and if we need to  change, we will.  We should go ahead and land what we have.

    
    

    
  
Yep see comment 3.

    
    

    
  
oops just seen asa's last comment, yep I'll land it and re-update via another bug if needed.

    
  
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/integration/fx-team/rev/330f82b3ddbd
Keywords: checkin-needed
Target Milestone: --- → Firefox 27

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/330f82b3ddbd
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

    
    

    
  
Verified as fixed, for iteration #15, with latest Nightly on Win 8 64-bit.

I get the same results as from comment 16.
Status: RESOLVED → VERIFIED

    
    

    
  
Should have had build peer review
Flags: needinfo?(netzen)

    
    

    
  
Comment on attachment 805374 [details] [diff] [review]
Patch v3

This is already landed but based on your feedback, if needed, I'll do a followup patch. Ms2ger let me know this should have been reviewed by a build peer. Thanks.

        Attachment #805374 -
        Flags: review?(khuey)

    
  
Flags: needinfo?(netzen)
OS: Windows 8 Metro → Windows 8.1

          You need to log in
          before you can comment on or make changes to this bug.