791920 - Keyboard does not always show up in inline disposition window

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect, P1)

Description

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

https://github.com/mozilla-b2g/gaia/issues/4500
[System] Confirm that inline disposition window work with keyboard
Edit

STR
===
1. Go SMS app. and launch Contact App. as inline disposition window
2. Click the search input field, the keyboard will show up
3. Click outside the input to hide the keyboard
4. Click the input field again

Expected: the keyboard will show up again
Actual result: the keyboard will not show up -> if repeat step 3. 4., it will show up again

Comment 1

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Patch v.1

For some reason, "ime-enabled-state-changed" would not occur for the input in inline disposition window, so that isKeyboardOpened would not be reset to false.

So we have to reset it to false in blur event of the input field.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 662019 [details] [diff] [review]
Patch v.1

Review of attachment 662019 [details] [diff] [review]:
-----------------------------------------------------------------

::: b2g/chrome/content/forms.js
@@ +79,5 @@
>            sendAsyncMessage("Forms:Input", { "type": "blur" });
>            this.previousTarget = null;
> +          // Bug 791920: need to reset isKeyboardOpened here
> +          // since for some reason, "ime-enabled-state-changed" would not occur for the input in inline disposition window
> +          this.isKeyboardOpened = false;

I don't know if that's the right fix or not but I don't want to land that just with this explanation. Can you find the reason why the 'ime-enabled'state-changed' event is not fired?

Comment 3

[Dietrich Ayala (:dietrich)]

Does this need to block the release?

Comment 4

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

I think it's blocking.
we cannot see the keyboard (sometimes) in inline disposition window, like the contact selection window popped up from sms.

Dear Vivien,
Sorry that I may not have enough time to dig out the root cause of this issue by 9/28.

Comment 5

[Andrew Overholt [:overholt]]

Agreed with comment #4.

Comment 7

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

This is fixed by the change from Bug 796269.