Gfx driver block request: AMD driver 8.982.0.0

RESOLVED FIXED

Status

()

Toolkit
Blocklisting
RESOLVED FIXED
5 years ago
8 months ago

People

(Reporter: Joe Drew (not getting mail), Assigned: jorgev)

Tracking

unspecified
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox15+ fixed, firefox16+ fixed, firefox17 fixed, firefox18 fixed)

Details

(Whiteboard: [gfx])

Attachments

(3 attachments)

(Reporter)

Description

5 years ago
Vendor: 0x1002
Feature: DIRECT2D
Driver versions: 8.982.0.0
OS: ALL

We're seeing huge numbers of crashes with the ATI/AMD driver version 8.982.0.0, so we should block it from using Direct2D using the downloaded graphics blocklist.
(Reporter)

Updated

5 years ago
tracking-firefox15: --- → ?

Comment 1

5 years ago
Direct2D exists only on Vista and above.
In addition to the ATI vendor ID, the AMD vendor ID is 0x1022
Blocks: 789260
(In reply to Scoobidiver from comment #1)
> Direct2D exists only on Vista and above.
> In addition to the ATI vendor ID, the AMD vendor ID is 0x1022

Blocking it everywhere is harmless though, and prevents us from having to add 4 entries instead of 2.
(Assignee)

Comment 3

5 years ago
I staged both blocks using the data provided (id: 131 for ATI and 133 for AMG).
Assignee: nobody → jorge
Keywords: qawanted
QA Contact: anthony.s.hughes
Unfortunately, I don't have access to any AMD hardware locally.

Marcia or Juan, could one of you take ownership of this and test it in the lab?
QA Contact: anthony.s.hughes
(Reporter)

Comment 5

5 years ago
Er, AMD's vendor id is 0x1004, isn't it?
(Reporter)

Comment 6

5 years ago
(In reply to Joe Drew (:JOEDREW! \o/) from comment #5)
> Er, AMD's vendor id is 0x1004, isn't it?

No, I'm wrong. Ignore me.

Updated

5 years ago
tracking-firefox15: ? → +
tracking-firefox16: --- → +
QA Contact: jbecerra
Created attachment 662759 [details]
about:support information and blocklist entry

I checked the staged blocklist and forced a blocklist ping. The entry is added, but the information in about:support says Direct2D is still enabled.

Does the blocklist entry need an OS to be specified? See the attachment.

Updated

5 years ago
Keywords: verifyme
(Reporter)

Comment 8

5 years ago
Jorge, can you explicitly set the OS to "ALL" for those blocklist entries?
(Reporter)

Comment 9

5 years ago
OH! And you need to specify the comparator as EQUAL.
(Assignee)

Comment 10

5 years ago
Done. Does 'Feature Status' need to be set to anything?
(Reporter)

Comment 11

5 years ago
Oh crap, yes. BLOCKED_DRIVER_VERSION.
(Assignee)

Comment 12

5 years ago
Also done :)
(Reporter)

Comment 13

5 years ago
Ok, Juan, should be ready for testing again :)
Created attachment 663155 [details]
Direct2D still shows as enabled in about:support

Tried it again, but the about:suppport information still says "Direct2D Enabled: true."

The blocklist entry is updated with the information added, but the only thing that I see different from other similar blocklist entries is that it is missing a "device" parameter. Other than that, I don't know why it's about:support is still showing Direct2D as enabled.
(Reporter)

Comment 15

5 years ago
Ugh ugh ugh. I am so bad at this.

Can you change the OS to the literal "All" instead of "ALL"? It's case-sensitive because I am new at this apparently.

I've tested a blocklist xml file with this change and it worked for me (while spoofing vendor and driver).
(Assignee)

Comment 16

5 years ago
Updated.
It's working now on staging. The blocklist is updated, and the information in about:support now says D2D is blocked for this driver version.
(Reporter)

Comment 18

5 years ago
Thanks for sticking with me, Jorge and Juan. Let's push this live and see what it does to crash stats.
(Assignee)

Comment 19

5 years ago
The blocks are now live, ids 144 and 146.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Comment 20

5 years ago
I've updated https://wiki.mozilla.org/Blocklisting/Blocked_Graphics_Drivers#Downloaded_blacklist accordingly.

Updated

5 years ago
Blocks: 744043

Updated

5 years ago
No longer blocks: 744043
Depends on: 744043
(Reporter)

Updated

5 years ago
Blocks: 793869

Updated

5 years ago
No longer blocks: 793869
I've verified this in production.
Keywords: qawanted

Updated

5 years ago
Keywords: verifyme

Updated

5 years ago
status-firefox15: --- → fixed
status-firefox16: --- → fixed
status-firefox17: --- → fixed
status-firefox18: --- → fixed

Comment 22

5 years ago
So all acceleration for users with AMD/ATI graphics on Windows is now disabled? That seems a little drastic, doesn't it?

Comment 23

5 years ago
(In reply to James May [:fowl] from comment #22)
> That seems a little drastic, doesn't it?
Do you have a better solution because crashes were occurring behind the empty crash signature with no way to correlate to specific GPUs or user's configurations?
AMD releases a new driver version every two months, you just need to wait Catalyst 12.9.
(Reporter)

Comment 24

5 years ago
Actually, it's only users with Catalyst 12.8. Earlier or later versions aren't blocked.

Comment 25

5 years ago
Catalyst 12.9 Beta is released and fixes some memory corruptions with Firefox: http://support.amd.com/de/kbarticles/Pages/AMDCatalyst129betadriver.aspx

Comment 26

5 years ago
@Scoobidiver, thx. As a technical user i would have loved to be notified of this driver block.

Comment 27

5 years ago
(In reply to Dennis Jakobsen from comment #26)
> @Scoobidiver, thx. As a technical user i would have loved to be notified of
> this driver block.
Notifying such a thing would worry more people that don't even know HW acceleration than reassure a few technical users such as you. You can add the link in comment 20 and also https://addons.mozilla.org/firefox/blocked/ to your RSS.

Comment 28

5 years ago
ok, i realize the implications of such a notification.

That RSS feed does not include a single ATI/Amd Driver entry, so that's hardly useful.

The beta driver 9.1.0.0 is also blocked and nowhere to be found on the block list
I installed the driver you linked and it seems to use the Win8 driver version scheme and is also blocked, which is not indicated on the Block List: https://wiki.mozilla.org/Blocklisting/Blocked_Graphics_Drivers

Win7 x64 - AMD Radeon 7850
Driver version: 9.1.0.0

I can't find a block request for this driver in bugzilla.

Comment 29

5 years ago
(In reply to Dennis Jakobsen from comment #28)
> The beta driver 9.1.0.0 is also blocked
It's not intentionally blocked. Please file a new bug in the Core - Graphics component. Provide the Graphics section of your about:support in that bug.

Comment 30

5 years ago
Created attachment 667411 [details]
Graphics section of about:support after installation of 12.9 beta Catalyst package.

I just installed the 12.9 beta Catalyst package and cannot reproduce Dennis' issue.

Comment 31

5 years ago
I think it comes down to details like:

1. did you uninstall the old driver first?
2. did you reboot after install?
3. both

Windows keeps older driver installs, so if you install a new one on top.. and uninstall it again, you'll be back where you started.

If Firefox looks in the registry, maybe the old version lingers on case 1 or 2 ?

Anyway, i uninstalled all drivers i could and did a fresh install of 9.1.0.0, rebooted and i'm not seeing any blocked drivers anymore.
(Reporter)

Comment 32

5 years ago
I know what the problem was: Firefox doesn't immediately refresh what driver is installed for the purposes of blocking. It re-evalutes its decision daily when downloading the driver blocklist. Therefore, you might need to wait up to a day for the driver blacklisting decision to be re-evaluated.
Blocks: 790808
Product: addons.mozilla.org → Toolkit
You need to log in before you can comment on or make changes to this bug.