social tests with data: urls should specify a charset to reduce test output noise

RESOLVED FIXED in Firefox 17

Status

()

Firefox
SocialAPI
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: markh, Assigned: markh)

Tracking

unspecified
Firefox 18
Points:
---

Firefox Tracking Flags

(firefox17 fixed)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
When running the social tests, there are lots of entries in the test output like:

TEST-INFO | chrome://.../browser_frameworker.js | Console message: [JavaScript Error: "The character encoding of the plain text document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the file needs to be declared in the transfer protocol or file needs to use a byte order mark as an encoding signature." {file: "data:application/javascript,...

Low priority, but still worthwhile IMO, especially as such lines tend to be looooong
(Assignee)

Comment 1

5 years ago
Created attachment 665271 [details] [diff] [review]
add a charset to data: urls

Trivial patch.  Note the same warning is generated for tests that use real URLs, but those lines are much shorter so I haven't bothered looking into how to reduce them.
Assignee: nobody → mhammond
Attachment #665271 - Flags: review?(mixedpuppy)
Comment on attachment 665271 [details] [diff] [review]
add a charset to data: urls

Review of attachment 665271 [details] [diff] [review]:
-----------------------------------------------------------------

JS can have Unicode characters in it, so we should use utf-8 charset.

r=me with the change in charset.

::: toolkit/components/social/test/browser/browser_frameworker.js
@@ +3,4 @@
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
>  function makeWorkerUrl(runner) {
> +  return "data:application/javascript;charset=us-ascii," + encodeURI("let run=" + runner.toSource()) + ";run();"

data:application/javascript;charset=utf-8,

::: toolkit/components/social/test/browser/browser_notifications.js
@@ +74,4 @@
>    let manifest = {
>      origin: TEST_PROVIDER_ORIGIN,
>      name: "Example Provider",
> +    workerURL: "data:application/javascript;charset=us-ascii," + encodeURI("let run=" + workerFunction.toSource()) + ";run();"

charset=utf-8
Attachment #665271 - Flags: review?(mixedpuppy) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/a0c8f93e588c
Status: NEW → ASSIGNED

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/a0c8f93e588c
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
Attachment #665271 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/93968840a40b
status-firefox17: --- → fixed

Updated

5 years ago
Depends on: 797874
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.