796218 - make sure social docshells are marked as "inactive" by default

Status: RESOLVED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

In bug 784238 and bug 779360 we made the social panels all set their docshell's "active" property according to their display state, so that the mozSocial API could use it to determine visibility.

In those bugs it looks like we didn't do anything to ensure that the default state for the hidden panels is "inactive" - we should do that, since the "active" property also controls whether tabs are throttled ("background" tabs get fewer resources).

This should just involve setting isActive = false in the initialization code for all of the panels.

Comment 1

[:Felipe Gomes (needinfo for replies!)]

Attachment: Patch

Obvious patch, builds on top of the patch from bug 766616

Comment 2

[Asa Dotzler [:asa]]

If this needs to land for v1, let's be sure to land it ASAP.

Comment 3

[:Felipe Gomes (needinfo for replies!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d8ec55d3b98e

Comment 4

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/9b9678df7672 because something in the push was hitting "browser_frameworker.js | sub-test testEarlyClose failed: [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIXPCComponents_Utils.nukeSandbox]" nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)" location: "JS frame :: resource://gre/modules/FrameWorker.jsm :: terminate :: line 239" data: no]" and "browser_frameworker.js | check that websockets worked - Got FAILED calling WebSocket constructor: TypeError: WebSocket is not a constructor, expected ok" and I didn't know which (though I presume bug 790201), and didn't know interconnectedness among them.

Comment 5

[Mark Hammond [:markh] [:mhammond]]

relanded: https://hg.mozilla.org/integration/mozilla-inbound/rev/61e6d94f8216

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/61e6d94f8216

Comment 7

[:Felipe Gomes (needinfo for replies!)]

fixed in aurora with cset https://hg.mozilla.org/releases/mozilla-aurora/rev/b69ca3697450