make sure social docshells are marked as "inactive" by default

RESOLVED FIXED in Firefox 17

Status

()

Firefox
SocialAPI
RESOLVED FIXED
5 years ago
3 years ago

People

(Reporter: Gavin, Assigned: Felipe)

Tracking

Trunk
Firefox 18
Points:
---

Firefox Tracking Flags

(firefox17+ fixed)

Details

(Whiteboard: [Fx17])

Attachments

(1 attachment)

In bug 784238 and bug 779360 we made the social panels all set their docshell's "active" property according to their display state, so that the mozSocial API could use it to determine visibility.

In those bugs it looks like we didn't do anything to ensure that the default state for the hidden panels is "inactive" - we should do that, since the "active" property also controls whether tabs are throttled ("background" tabs get fewer resources).

This should just involve setting isActive = false in the initialization code for all of the panels.
(Assignee)

Updated

5 years ago
Assignee: nobody → felipc
Status: NEW → ASSIGNED
(Assignee)

Comment 1

5 years ago
Created attachment 666841 [details] [diff] [review]
Patch

Obvious patch, builds on top of the patch from bug 766616
Attachment #666841 - Flags: review?(gavin.sharp)
Attachment #666841 - Flags: review?(gavin.sharp) → review+

Comment 2

5 years ago
If this needs to land for v1, let's be sure to land it ASAP.

Updated

5 years ago
Whiteboard: [Fx17]
Depends on: 766616
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/d8ec55d3b98e
tracking-firefox17: --- → ?
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/9b9678df7672 because something in the push was hitting "browser_frameworker.js | sub-test testEarlyClose failed: [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIXPCComponents_Utils.nukeSandbox]" nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)" location: "JS frame :: resource://gre/modules/FrameWorker.jsm :: terminate :: line 239" data: no]" and "browser_frameworker.js | check that websockets worked - Got FAILED calling WebSocket constructor: TypeError: WebSocket is not a constructor, expected ok" and I didn't know which (though I presume bug 790201), and didn't know interconnectedness among them.
relanded: https://hg.mozilla.org/integration/mozilla-inbound/rev/61e6d94f8216

Comment 6

5 years ago
https://hg.mozilla.org/mozilla-central/rev/61e6d94f8216
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
(Assignee)

Comment 7

5 years ago
fixed in aurora with cset https://hg.mozilla.org/releases/mozilla-aurora/rev/b69ca3697450
status-firefox17: --- → fixed

Updated

5 years ago
tracking-firefox17: ? → +
You need to log in before you can comment on or make changes to this bug.