Closed Bug 796218 Opened 7 years ago Closed 7 years ago

make sure social docshells are marked as "inactive" by default

Categories

(Firefox Graveyard :: SocialAPI, defect)

defect
Not set

Tracking

(firefox17+ fixed)

RESOLVED FIXED
Firefox 18
Tracking Status
firefox17 + fixed

People

(Reporter: Gavin, Assigned: Felipe)

References

Details

(Whiteboard: [Fx17])

Attachments

(1 file)

In bug 784238 and bug 779360 we made the social panels all set their docshell's "active" property according to their display state, so that the mozSocial API could use it to determine visibility.

In those bugs it looks like we didn't do anything to ensure that the default state for the hidden panels is "inactive" - we should do that, since the "active" property also controls whether tabs are throttled ("background" tabs get fewer resources).

This should just involve setting isActive = false in the initialization code for all of the panels.
Assignee: nobody → felipc
Status: NEW → ASSIGNED
Attached patch PatchSplinter Review
Obvious patch, builds on top of the patch from bug 766616
Attachment #666841 - Flags: review?(gavin.sharp)
If this needs to land for v1, let's be sure to land it ASAP.
Whiteboard: [Fx17]
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/9b9678df7672 because something in the push was hitting "browser_frameworker.js | sub-test testEarlyClose failed: [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIXPCComponents_Utils.nukeSandbox]" nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)" location: "JS frame :: resource://gre/modules/FrameWorker.jsm :: terminate :: line 239" data: no]" and "browser_frameworker.js | check that websockets worked - Got FAILED calling WebSocket constructor: TypeError: WebSocket is not a constructor, expected ok" and I didn't know which (though I presume bug 790201), and didn't know interconnectedness among them.
https://hg.mozilla.org/mozilla-central/rev/61e6d94f8216
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.