796222 - Create panels with more appropriate default width to avoid mis-aligned anchor

Status: RESOLVED FIXED

Description

[Mark Hammond [:markh]]

The panels we create seem to have a default width of around 100x100, before we then resize the panel to fit the content - but still use a fixed width of 330px.  This resize behaviour causes the panel anchor to be in the wrong position when first displayed (see bug 793057).

We can work around that issue by arranging for the panels to always be created with an initial width of 330px.

Comment 1

[Jared Wein [:jaws] (Regression Engineering Owner for 65) (please needinfo? me)]

I think we should kill the max-width while we're at it, either that or make max-width = min(600, screen.width / 2);

Comment 2

[Mark Hammond [:markh]]

Actually, we don't have a max-width at all - we have a totally fixed width.  The CSS from the amigo currently don't offer any clues we can use at all - if we try and use the offsetWidth, for example, we will end up with all panels being exactly 100px wide (as that is what the CSS says).  I'm hoping to chat with them today about this.

Comment 3

[Mark Hammond [:markh]]

Created attachment 667818 [details] [diff] [review]
Set the width of the iframe on creation to the panel default width

Comment 4

[Jared Wein [:jaws] (Regression Engineering Owner for 65) (please needinfo? me)]

Comment on attachment 667818 [details] [diff] [review]
Set the width of the iframe on creation to the panel default width

Review of attachment 667818 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/browser-social.js
@@ +612,5 @@
>          notificationFrame.setAttribute("id", notificationFrameId);
>          notificationFrame.setAttribute("mozbrowser", "true");
> +        // work around bug 793057 - by making the panel roughly the final size
> +        // we are more likely to have the anchor in the correct position.
> +        notificationFrame.style.width = "330px";

Can we set this width in a CSS rule for .social-panel-frame ?

Comment 5

[Jared Wein [:jaws] (Regression Engineering Owner for 65) (please needinfo? me)]

Comment on attachment 667818 [details] [diff] [review]
Set the width of the iframe on creation to the panel default width

Discussed this on IRC and the solution of setting this value in external CSS will propagate a value among various files, removing the containment of a current workaround (the 330px seen elsewhere in browser-social.js).

Comment 6

[Mark Hammond [:markh]]

As discussed on IRC with Jaws, we are keeping the code where it is, but using the constant PANEL_MIN_WIDTH introduced with bug 797716.

https://hg.mozilla.org/integration/mozilla-inbound/rev/5b5981c2106b

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5b5981c2106b

Comment 8

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/52b3f1c7ca9a