Pref on WebRTC by default

RESOLVED FIXED in mozilla21

Status

()

Core
WebRTC
RESOLVED FIXED
5 years ago
a year ago

People

(Reporter: jesup, Assigned: jesup)

Tracking

(Blocks: 1 bug, {dev-doc-needed})

Trunk
mozilla21
dev-doc-needed
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(relnote-firefox 21+)

Details

(Whiteboard: [WebRTC], [blocking-webrtc+], [qa-])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
There will be a bunch of bugs blocking this (try to keep it to the highest bug in a chain of dependencies; if we're blocked by B, and A blocks B, don't generally bother having A block this as well.  This is not a hard-and-fast rule.

Doing this will require privacy and security reviews to be passed.

Comment 1

5 years ago
Is there currently a bug to make a pref?
(Assignee)

Comment 2

5 years ago
media.peerconnection.enabled (defaults to true on alder)

Updated

5 years ago
Depends on: 797258

Updated

5 years ago
Whiteboard: [WebRTC], [blocking-webrtc+]
Depends on: 781787
Blocks: 694812

Updated

5 years ago
Depends on: 798178
Depends on: 821884, 825510, 825511, 805251, 814882, 818670, 825785, 820538
No longer depends on: 781787, 797258, 798178
No longer blocks: 694812
Depends on: 825594
Depends on: 826807

Updated

5 years ago
No longer depends on: 821884

Updated

5 years ago
Depends on: 825927

Updated

5 years ago
Depends on: 822197
Depends on: 830247
Depends on: 827985
Removing Bug 827985 because we don't believe there is a significant advantage to moving webrtc out of libxul beyond the patch for bug 833118, which has already landed.
No longer depends on: 827985

Updated

5 years ago
Depends on: 834100
(Assignee)

Updated

5 years ago
No longer depends on: 834100
(Assignee)

Comment 4

4 years ago
Created attachment 708963 [details] [diff] [review]
enable PeerConnection by default
Depends on: 797258
Depends on: 829899, 831290
Depends on: 833219
(Assignee)

Updated

4 years ago
No longer depends on: 833219
(Assignee)

Updated

4 years ago
Depends on: 833219
Depends on: 834152
Depends on: 835283, 835835
Depends on: 836349, 836379
Depends on: 836931
Depends on: 838169

Updated

4 years ago
Depends on: 840344
(Assignee)

Comment 5

4 years ago
Comment on attachment 708963 [details] [diff] [review]
enable PeerConnection by default

Looking for trivial r+ in order to be ready to "flip the bit" once we've resolved the blockers.
Attachment #708963 - Flags: review?(roc)
Attachment #708963 - Flags: review?(roc) → review+
No longer depends on: 797258
No longer depends on: 834152
Depends on: 826044
(Assignee)

Updated

4 years ago
No longer depends on: 835283
Sounds like we should land this now, right?

Quick question - are you prefing this on by default in FF 21 or FF 22? That might affect when we land this and if an uplift is needed.
I think we should land this now (today). 

I'd love to pref this on for at least the Aurora cycle of 21 to get some extra testing from the Aurora population.  It's unclear if we'll be able to fix and uplift enough bugs (I realize we have around 50 blocker-webrtc+ bugs currently open) to keep the feature on when Fx21 goes to Beta.  (We probably won't be able to.)  But the extra test time and developer exposure in Aurora 21 would be very valuable to the feature IMO.  If at any point, it becomes problematic to keep the feature pref'd on in Aurora 21, we can disable it. but it would be great if we could keep it on through the end of the Aurora 21 cycle.  Randell and I are talking to Alex and Bhavana (release-drivers) about what makes the most sense.  Thoughts about this are welcome here.
(Assignee)

Comment 8

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/584660a01e64
Target Milestone: --- → mozilla21

Comment 9

4 years ago
https://hg.mozilla.org/mozilla-central/rev/584660a01e64
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Updated

4 years ago
Whiteboard: [WebRTC], [blocking-webrtc+] → [WebRTC], [blocking-webrtc+], [qa-]

Updated

4 years ago
relnote-firefox: --- → ?
Keywords: dev-doc-needed

Updated

4 years ago
relnote-firefox: ? → 21+
Depends on: 846358

Updated

4 years ago
No longer depends on: 846358

Comment 10

4 years ago
I noticed that it's not pref'd on by default anymore in Aurora (21.0a2) or in Firefox Beta (21.0). Is this intentional? Can we hope for it to be pref'd on by default when 21 goes to production?
(In reply to Adam Ullman from comment #10)
> I noticed that it's not pref'd on by default anymore in Aurora (21.0a2) or
> in Firefox Beta (21.0). Is this intentional? Can we hope for it to be pref'd
> on by default when 21 goes to production?

Yes, it's intentional. We preffed off for Fx21 because the feature isn't ready for production.

We're riding the trains to Fx22 for turning this feature on now.
(In reply to Jason Smith [:jsmith] from comment #11)
> Yes, it's intentional. We preffed off for Fx21 because the feature isn't
> ready for production.

Right, we had it preffed on in Aurora to enable wider testing, but the plan was to pref off before 21 went to Beta. See bug 853106.
Yes, our plan is to keep the feature pref'd on in Firefox 22 into production.

Comment 14

4 years ago
Thanks for the clarification.

Is there a way in JavaScript to detect whether the pref is on? Currently we're using 

  typeof(mozRTCPeerConnection) === 'function'

but that returns true even if the preference isn't on. It seems that the PeerConnection object is there it just doesn't work.

Comment 15

4 years ago
Sorry, just realised I can try/catch around new mozRTCPeerConnection. Should have tried that before posting.
Blocks: 1050930
You need to log in before you can comment on or make changes to this bug.