796725 - [system] remember the user's permission choice per app

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect, P1)

Description

[GH to BZ]

[GitHub issue by alivedise on 2012-09-25T04:41:03Z, https://github.com/mozilla-b2g/gaia/issues/5121]
Related to #3378, #2357

@jcarpenter 's spec about permission is here
https://www.dropbox.com/sh/ug5dd6d7rub0p5x/VfUq-JfGDo/Gaia_AppSecurity_20120909.pdf

System app needs to deal with permission prompt in a new way.(Modal type dialog, option to remember the choice)

Settings app needs to be capable to edit the permission list of apps.( I think @etiennesegonzac is on this? Could you comment? :) )

Comment 1

[GH to BZ]

[GitHub comment by alivedise on 2012-09-25T04:49:44Z]
The remember me function is blocking by https://bugzilla.mozilla.org/show_bug.cgi?id=773114

Comment 2

[GH to BZ]

[GitHub comment by jcarpenter on 2012-09-25T06:33:47Z]
Specs have been updated to v3. These should be final.

**Gaia_AppSecurity_20120924.pdf**
https://www.dropbox.com/sh/ug5dd6d7rub0p5x/a5r79NCwo3

@alivedise, please let me know if there are any questions.

Comment 3

[GH to BZ]

[GitHub comment by jcarpenter on 2012-09-25T06:44:13Z]
Also tracking in #3338.

Comment 4

[GH to BZ]

[GitHub comment by etiennesegonzac on 2012-09-25T09:56:45Z]
Yes @alivedise, it's tracked here #3338

Comment 5

[GH to BZ]

[GitHub comment by autonome on 2012-09-28T05:42:07Z]
We have a platform bug for remember permissions and we have a different issue for per-app permissions management in Settings.

Is there a reason to keep this one open?

Comment 6

[GH to BZ]

[GitHub comment by alivedise on 2012-09-28T10:04:51Z]
This one is for system app part's work I think.

Comment 7

[GH to BZ]

[GitHub comment by autonome on 2012-09-28T16:23:42Z]
@etiennesegonzac @fabricedesre @gregorwagner do you know what the system work here is once the platform fix lands?

Comment 8

[GH to BZ]

[GitHub comment by etiennesegonzac on 2012-10-01T14:41:26Z]
@autonome I think we're just going to need to update the event we send back to chrome a bit + implement a nice visual.

Platform devs, if I'm wrong please tell us quickly :)

Comment 9

[Etienne Segonzac (:etienne)]

Okay, here is what needs to happen, can't get to it right now, so brain dumping:

* Add the shared building block |confirm.css| to the system app
* Remove the then unused CSS rules from |themes/default/core.css|
* Make sure the alert/confirm/prompts are still working correctly
* Update the permission prompt to use |confirm.css| styling with Allow / Don't Allow buttons
(* the permissions names l10nification is already taken care of here https://github.com/mozilla-b2g/gaia/pull/5358)
* Add the shared building block |switches.css| to the system app
* Add a switch button for "Remember my choice" on the permission prompt
* Set the default value of the remember switch with the |details.remember| value coming from the mozChromeEvent when displaying the prompt
* Send back the value of the remember switch in the |details.remember| of the mozContentEvent
* Make sure the app-install prompt is still working

Comment 10

[Gregor Wagner [:gwagner]]

Alive, are you working on this?

Comment 11

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Gregor Wagner [:gwagner] from comment #10)
> Alive, are you working on this?

yes.
will submit pr this thu or fri.
(
today is Taiwan's National day.)

Comment 12

[(inactive after 6/18) Alive Kuo [:alive]]

Progress now:
Basically done, but stuck in Building blocks nightmare.
@kaze is watching BB conflict issues.

I'll still send PR anyway tomorrow.
Tell me if you don't think this is O.K.

Comment 13

[David Dahl :ddahl]

(In reply to Alive Kuo [:alive] from comment #12)
> Progress now:
> Basically done, but stuck in Building blocks nightmare.
> @kaze is watching BB conflict issues.
> 
> I'll still send PR anyway tomorrow.
> Tell me if you don't think this is O.K.

Can you please attach a patch or link to the patch here so I can look at it - I am working on the platform bits for this in bug 773114. Thanks.

Comment 14

[(inactive after 6/18) Alive Kuo [:alive]]

@Gregor, @David
What's the difference between `wifi` and `wifi-manage` permission?
What's relevant to the permission about wifi information?

Comment 15

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to David Dahl :ddahl from comment #13)
> (In reply to Alive Kuo [:alive] from comment #12)
> > Progress now:
> > Basically done, but stuck in Building blocks nightmare.
> > @kaze is watching BB conflict issues.
> > 
> > I'll still send PR anyway tomorrow.
> > Tell me if you don't think this is O.K.
> 
> Can you please attach a patch or link to the patch here so I can look at it
> - I am working on the platform bits for this in bug 773114. Thanks.

https://github.com/mozilla-b2g/gaia/pull/5788

David I don't have your github accout(Do you have one?) so ping you here.

Comment 16

[David Dahl :ddahl]

When I run your branch, Gaia never finishes loading the homescreen. Seeing both gaia errors and Gecko errors:

Timestamp: 10/12/2012 02:56:59 PM
Error: NS_ERROR_FAILURE: Denied
Source File: file:///home/ddahl/code/moz/b2g-desktop/build/dist/bin/components/Webapps.js
Line: 667

https://mxr.mozilla.org/mozilla-central/source/dom/apps/src/Webapps.js#687

When I set the homescreen to the contacts app - not sure what else to do at this point - I get this error:

Content JS LOG at app://communications.gaiamobile.org/contacts/js/contacts_list.js:72 in anonymous: ERROR Retrieving contacts

I imagine that is doing unexpected things. Any ideas on what to do?

Comment 17

[(inactive after 6/18) Alive Kuo [:alive]]

David, are you working on Firefox Nightly?
AFAIK the system app(loading to homescreen) is broken now...
Don't you have a real device?

(In reply to David Dahl :ddahl from comment #16)
> When I run your branch, Gaia never finishes loading the homescreen. Seeing
> both gaia errors and Gecko errors:
> 
> Timestamp: 10/12/2012 02:56:59 PM
> Error: NS_ERROR_FAILURE: Denied
> Source File:
> file:///home/ddahl/code/moz/b2g-desktop/build/dist/bin/components/Webapps.js
> Line: 667
> 
> https://mxr.mozilla.org/mozilla-central/source/dom/apps/src/Webapps.js#687
> 
> When I set the homescreen to the contacts app - not sure what else to do at
> this point - I get this error:
> 
> Content JS LOG at
> app://communications.gaiamobile.org/contacts/js/contacts_list.js:72 in
> anonymous: ERROR Retrieving contacts
> 
> I imagine that is doing unexpected things. Any ideas on what to do?

Comment 18

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Etienne Segonzac (:etienne) from comment #9)
> Okay, here is what needs to happen, can't get to it right now, so brain
> dumping:
> 
> * Add the shared building block |confirm.css| to the system app
> * Remove the then unused CSS rules from |themes/default/core.css|
> * Make sure the alert/confirm/prompts are still working correctly
> * Update the permission prompt to use |confirm.css| styling with Allow /

In order not to pollute this bug, I am going to open another bug about building blocks cleanup work for system app.

Comment 19

[(inactive after 6/18) Alive Kuo [:alive]]

system app bb works task bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=801532

Comment 20

[David Dahl :ddahl]

(In reply to Alive Kuo [:alive] from comment #17)
> David, are you working on Firefox Nightly?
> AFAIK the system app(loading to homescreen) is broken now...
> Don't you have a real device?
> 

I do, however, isn't the testing work flow going to be very slow updating a deveice each time you make a code change? Is that the preferred method for Gaia work?

Comment 21

[Gregor Wagner [:gwagner]]

(In reply to Alive Kuo [:alive] from comment #14)
> @Gregor, @David
> What's the difference between `wifi` and `wifi-manage` permission?
> What's relevant to the permission about wifi information?

It is the same. We wanted to rename wifi to wifi-manage but it hasn't happened yet.

Comment 22

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to David Dahl :ddahl from comment #20)
> (In reply to Alive Kuo [:alive] from comment #17)
> > David, are you working on Firefox Nightly?
> > AFAIK the system app(loading to homescreen) is broken now...
> > Don't you have a real device?
> > 
> 
> I do, however, isn't the testing work flow going to be very slow updating a
> deveice each time you make a code change? Is that the preferred method for
> Gaia work?

Exactly..NO
BUT most people who develops in other app could use theirapp.gaiamobile.org to skip the system app bustage.
And many of the system app issues/features needs a real device(another gecko). You call `alert` in firefox nightly and then you would get a real `alert`. The permission prompt is the same case because firefox has its own permission dialog.

Instead, debugging on desktop B2G could meet some requirement, HOWEVER.

Comment 23

[David Dahl :ddahl]

(In reply to Alive Kuo [:alive] from comment #22)
> (In reply to David Dahl :ddahl from comment #20)
> > (In reply to Alive Kuo [:alive] from comment #17)
> > > David, are you working on Firefox Nightly?
> > > AFAIK the system app(loading to homescreen) is broken now...
> > > Don't you have a real device?
> > > 
> > 
> > I do, however, isn't the testing work flow going to be very slow updating a
> > deveice each time you make a code change? Is that the preferred method for
> > Gaia work?
> 
> Exactly..NO
> BUT most people who develops in other app could use theirapp.gaiamobile.org
> to skip the system app bustage.

When I was experiencing this problem I tried that and it also did not work. 

However, things have stabilized enough to the point where I have a working patch in bug 773114 - please build with it and let me know how it works - if you have time.

Comment 24

[(inactive after 6/18) Alive Kuo [:alive]]

All Gaia/Gecko work of this issue has been done. closing.

Comment 25

[Jason Smith [:jsmith]]

Old bug, so won't reopen, but this isn't working for me - see bug 815974

Comment 26

[Jason Smith [:jsmith]]

Verified with some sanity checks with a hosted app and privileged app - we're doing correct behavior at the sanity level now.