796770 - [FM Radio] Hardware volume buttons don't work in radio app

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::FMRadio, defect, P1)

Description

[GH to BZ]

[GitHub issue by cgjones on 2012-09-28T06:48:12Z, https://github.com/mozilla-b2g/gaia/issues/5382]
STR
 (1) Play FM radio
 (2) Turn off screen
 (3) Press volume-up/down

The volume doesn't change.  May not be specific to FM radio.

Comment 1

[GH to BZ]

[GitHub comment by nhirata on 2012-09-28T23:43:14Z]
This might be in spec?

Comment 2

[Marco Chen [:mchen]]

If FM radio didn't acquire any wakelock, then system will go into suspend mode.
But FM sound still route from FM chip to codec directly.
The behavior should be defined clearly by spec.

Comment 3

[Carlos Martínez Toral [:carlosmartinez]]

This is happening with screen on too, changing title and nominating to bb. 

Tested with unagi:

gaia 1910eba
gecko 72dbb82

Comment 4

[Dylan Oliver [:doliver]]

blocking+

Comment 5

[Dylan Oliver [:doliver]]

Raising priority for smoketest blocker.

Comment 6

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

This patch can fix this issue.
https://bugzilla.mozilla.org/show_bug.cgi?id=812434
Also verified on today's unagi build.

Comment 7

[Cody Roesch [:croesch]]

Unagi build 20130103070201
The hardware buttons work while the screen is on, and in other programs as well still control FM Radio volume.

However

Once the screen is dark, the volume buttons don't work for the FM Radio BUT they do work for playing music in the Music app.

Should these be handled the same?

Comment 8

[Tony Chung [:tchung]]

(In reply to croesch from comment #7)
> Unagi build 20130103070201
> The hardware buttons work while the screen is on, and in other programs as
> well still control FM Radio volume.
> 
> However
> 
> Once the screen is dark, the volume buttons don't work for the FM Radio BUT
> they do work for playing music in the Music app.
> 
> Should these be handled the same?

Randy, what is the expected behavior here for screen being off?  

Chris, please just file a new bug for this.   At this point we should be calling out issues that just isnt working on recent builds.

thanks

Comment 9

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

I can't reproduce this issue on today build, maybe hit this bug: Bug 819965

Comment 10

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

correct the id :Bug 825635 Volume control stops working in FM when headset is unplugged and plugged

Comment 11

[Cody Roesch [:croesch]]

(In reply to Randy Lin [:rlin] from comment #9)
> I can't reproduce this issue on today build, maybe hit this bug: Bug 819965

I made sure to avoid bug 825635 when testing this.

Today I was occasionally able to get the volume buttons to work when the screen was dark but it's not easy or reliable as a user would expect.
Opening a new bug on this behavior.
https://bugzilla.mozilla.org/show_bug.cgi?id=826770

Comment 12

[mlevin]

Verified Fixed in:

Unagi Build ID: 20130318070202
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/af9270e8f205
Gaia: a78ebf426840b5ef08c0cc3e437ad30aba3e2528