799257 - Backport bug 795650 and bug 797883 to bmo/4.0 and bmo/4.2 for performance improvement

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[David Lawrence [:dkl]]

Bug 797833 adds a new process_cache variable to Bugzilla.pm for caching data for a HTTP child process such as mod_perl. Bug 795650 uses processs_cache to cache the HTML::Scrubber module used by the html_light filter in templates.

dkl

Comment 1

[David Lawrence [:dkl]]

Attachment: Patch to backport 797833/795650 to bmo (v1)

Comment 2

[:glob ✱]

Comment on attachment 669312 [details] [diff] [review]
Patch to backport 797833/795650 to bmo (v1)

you missed a few edits to Bugzilla/Template.pm from bug 797883

remove |our %shared_providers| and change clearing out the cached provider object.

Comment 3

[David Lawrence [:dkl]]

Attachment: Patch to backport 797833/795650 to bmo (v2)

Ugh. Long story. Anyway here is a proper patch.

dkl

Comment 4

[:glob ✱]

Comment on attachment 669692 [details] [diff] [review]
Patch to backport 797833/795650 to bmo (v2)

Review of attachment 669692 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob, with the duplicate code removed on commit.

::: Bugzilla/Template.pm
@@ +628,5 @@
>  
> +    # Use a per-process provider to cache compiled templates in memory across
> +    # requests.
> +    Bugzilla->process_cache->{shared_providers} ||= {};
> +

please remove this block on commit; it's from an old revision and is duplicated below.

Comment 5

[David Lawrence [:dkl]]

Committing to: bzr+ssh://[e-mail]/bmo/4.0                 
modified Bugzilla/Util.pm
modified Bugzilla.pm
modified Bugzilla/Template.pm
Committed revision 8354.

Committing to: bzr+ssh://[e-mail]/bmo/4.2
modified Bugzilla/Util.pm
modified Bugzilla.pm                                                                        
modified Bugzilla/Template.pm
Committed revision 8376.

dkl