79952 - can't manage bookmarks in Sidebar

Status: VERIFIED DUPLICATE of bug 82967

(SeaMonkey :: Bookmarks & History, defect, P1)

Description

[Luke Morey]

Using latest nightly 20010509 with Windows 2000 SP1

Right-clicking a bookmark in the toolbar shows a menu with menu items Open, Find
a Bookmark, Cut Copy Paste Delete, etc. Only Open works - others have no effect.

Comment 1

[Fabian Guisset]

Yeah right. Ben says it's the command dispatcher that's freaky. Marking NEW so
we have a bug to dup against.

Comment 2

[R.K.Aa.]

none of them work on Linux - not "Open" either.

Comment 3

[R.K.Aa.]

Isn't this a dup of bug 79925 btw?

Comment 4

[Fabian Guisset]

no.

Comment 5

[Fabian Guisset]

Something new:
When I right-click on an item in the sidebar the context menu correctly appears.
However when I click on a menuitem, I get an assertion:
###!!! ASSERTION: A XUL <menuitem> is attached to a command that doesn't exist!
Unable to execute menu item!
: 'PR_FALSE', file nsMenuFrame.cpp, line 1419
###!!! Break: at file nsMenuFrame.cpp, line 1419

Code in there:
nsCOMPtr<nsIDOMElement> commandElt;
domDoc->GetElementById(command, getter_AddRefs(commandElt));
nsCOMPtr<nsIContent> commandContent(do_QueryInterface(commandElt));
if (commandContent)
  shell->HandleDOMEventWithTarget(commandContent, &event, &status);
else
  NS_ASSERTION(PR_FALSE, "A XUL <menuitem> is attached to a command that doesn't
exist! Unable to execute menu item!\n");

I checked an re-checked the js code but everything looks fine (it's even the
same as in the bookmarks manager, why would it fail here and not there?

Comment 6

[Alberto J. Rodriguez]

I reported an odd behaviour in bug # 79977 which is closed related to this bug.
What looks new is : after working four or five times in the left side bookmark 
window, the list gets partially blank and no longer operative. The delete button 
does not work.
I am working with moz 2001050515, windows ME in spanish.

Comment 7

[Andrea]

*** Bug 79977 has been marked as a duplicate of this bug. ***

Comment 8

[Andrea]

This bug also appear on v0.9 release (as A.J. Rodriguez report) on Win98.

Comment 9

[R.K.Aa.]

Managing bookmarks from the sidebar is one of the best inventions in mozilla,
and reviewers have often commented on the sidebar as being much better than
MSIE's. Using the bookmark manager is like a nightmare in slow motion compared
to how switf it used to be in the sidebar.

Adding regression keyword since this used to work.
Why isn't a target milestone or priority been set on this yet? 

Comment 10

[:deanis74]

*** Bug 82511 has been marked as a duplicate of this bug. ***

Comment 11

[R.K.Aa.]

importing keyword from bug 82511 nominating nsbeta1

Comment 12

[Todd Pringle]

Vishy/Ben - I think this is a must have for rtm.

Comment 13

[Viswanath Ramachandran]

it would be nice to get a patch for this, and investigate if we can get an 
approval for this to be in the beta - but only after we can get the existing 
mozilla0.9.1 bugs to zaero. 

Comment 14

[R.K.Aa.]

the patch is lurking in bug 82967, awaiting a vacant accesskey and some r/sr
I applied it by hand on the 27th and it works like a dream.

Comment 15

[Ben Goodger (use ben at mozilla dot org for email)]

patch exists in 82967, awaiting sr. 

Comment 16

[Ben Goodger (use ben at mozilla dot org for email)]

duping. 

*** This bug has been marked as a duplicate of 82967 ***

Comment 17

[Claudius Gayle]

VERIFIED Dupe