Closed Bug 799749 Opened 7 years ago Closed 7 years ago
Add back the Show Desktop Notifications menuitem for the Social API toolbar menu
The patch for bug 790112 accidentally removed the Show Desktop Notifications toolbar menuitem. This patch adds it back, along with a test to make sure this doesn't happen again. This affects Firefox 17 and 18 as well, but the patch is minimal and doesn't introduce any strings. The strings weren't removed on accident, just the menuitem.
Attachment #669779 - Flags: review?(mhammond)
Comment on attachment 669779 [details] [diff] [review] Patch It would be even better if the test checked the menuitems did something :)
Attachment #669779 - Flags: review?(mhammond) → review+
Also fixed the toolbar icons in the other tests. Ok'd by Mark on IRC, 5:08 PM <jaws> markh: ok for me to fix the toolbar icons when i push the menuitem fix? 5:09 PM <markh> fine with me :) 5:10 PM <jaws> i mean the toolbar icons in the tests of course 5:10 PM <jaws> they're currently using 48x48 icons, which doesn't seem right The tests don't check the "checked" state toggling due to bug 799761.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
Verified fixed across all branches.
You need to log in before you can comment on or make changes to this bug.