The default bug view has changed. See this FAQ.

Add back the Show Desktop Notifications menuitem for the Social API toolbar menu

VERIFIED FIXED in Firefox 17

Status

()

Firefox
SocialAPI
VERIFIED FIXED
5 years ago
4 years ago

People

(Reporter: jaws, Assigned: jaws)

Tracking

({regression})

18 Branch
Firefox 19
regression
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox17+ verified, firefox18+ verified)

Details

(Whiteboard: [Fx17])

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 669779 [details] [diff] [review]
Patch

The patch for bug 790112 accidentally removed the Show Desktop Notifications toolbar menuitem. This patch adds it back, along with a test to make sure this doesn't happen again.

This affects Firefox 17 and 18 as well, but the patch is minimal and doesn't introduce any strings. The strings weren't removed on accident, just the menuitem.
Attachment #669779 - Flags: review?(mhammond)
Comment on attachment 669779 [details] [diff] [review]
Patch

It would be even better if the test checked the menuitems did something :)
Attachment #669779 - Flags: review?(mhammond) → review+
Created attachment 669810 [details] [diff] [review]
Patch for checkin

Also fixed the toolbar icons in the other tests. Ok'd by Mark on IRC,
5:08 PM <jaws> markh: ok for me to fix the toolbar icons when i push the menuitem fix?
5:09 PM <markh> fine with me :)
5:10 PM <jaws> i mean the toolbar icons in the tests of course
5:10 PM <jaws> they're currently using 48x48 icons, which doesn't seem right

The tests don't check the "checked" state toggling due to bug 799761.
Attachment #669779 - Attachment is obsolete: true
Attachment #669810 - Flags: review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/88bb0e2f0373
Flags: in-testsuite+
https://hg.mozilla.org/mozilla-central/rev/88bb0e2f0373
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19

Updated

5 years ago
tracking-firefox17: ? → +
tracking-firefox18: ? → +
Attachment #669810 - Flags: approval-mozilla-beta+
Attachment #669810 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-beta/rev/663a97922297
https://hg.mozilla.org/releases/mozilla-aurora/rev/24d2399d1ca1
status-firefox17: affected → fixed
status-firefox18: affected → fixed
Verified fixed across all branches.
Status: RESOLVED → VERIFIED
status-firefox17: fixed → verified
status-firefox18: fixed → verified
You need to log in before you can comment on or make changes to this bug.