800804 - [OTA update] Tapping Update now, does not restart and update

Status: VERIFIED FIXED

(Firefox OS Graveyard :: General, defect, P1)

Description

[Tony Chung [:tchung]]

Attachment: fuller logcat

Tested on the Unagi, going from a 10-11 -> 10-12 update.   Tapping the "Restart Now" after the update was downloaded does not actually restart the phone and apply the update.  instead, it just exits the dialog and goes back to homescreen.

Dogfood blocker.

Logcat snippet after tapping the restart button:
10-11 23:50:51.519: I/IdleService(1491): next timeout 1350024652524133 usec (999 msec from now)
10-11 23:50:51.519: I/IdleService(1491): SetTimerExpiryIfBefore: next timeout 1350024652524133 usec
10-11 23:50:51.519: I/IdleService(1491): reset timer expiry from 1350024722220764 usec to 1350024652534133 usec
10-11 23:50:51.519: I/IdleService(1491): Reset idle timeout: tell observer 47fe1670 user is back
10-11 23:50:51.639: I/GeckoDump(1491): XXX FIXME : Got a mozContentEvent: desktop-notification-click
10-11 23:50:51.649: E/GeckoConsole(1491): [JavaScript Warning: "XUL box for p element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "app://system.gaiamobile.org/index.html" line: 0}]
10-11 23:50:51.699: D/memalloc(1491): /dev/pmem: Allocated buffer base:0x4b800000 size:614400 offset:8404992 fd:196
10-11 23:50:51.729: D/memalloc(1491): /dev/pmem: Allocated buffer base:0x4b800000 size:40960 offset:5906432 fd:207
10-11 23:50:51.749: D/memalloc(1491): /dev/pmem: Allocated buffer base:0x4b800000 size:614400 offset:9019392 fd:212
10-11 23:50:51.759: D/memalloc(1491): /dev/pmem: Allocated buffer base:0x4b800000 size:40960 offset:5947392 fd:225
10-11 23:50:51.889: D/memalloc(1491): /dev/pmem: Allocated buffer base:0x4b800000 size:12288 offset:1245184 fd:230
10-11 23:50:51.899: D/memalloc(1491): /dev/pmem: Freeing buffer base:0x4c09a000 size:614400 offset:9019392 fd:212
10-11 23:50:51.909: D/memalloc(1491): /dev/pmem: Freeing buffer base:0x4c004000 size:614400 offset:8404992 fd:196
10-11 23:50:51.909: D/memalloc(1491): /dev/pmem: Freeing buffer base:0x4bdac000 size:40960 offset:5947392 fd:225
10-11 23:50:51.909: D/memalloc(1491): /dev/pmem: Freeing buffer base:0x4bda2000 size:40960 offset:5906432 fd:207
10-11 23:50:51.909: D/memalloc(1491): /dev/pmem: Allocated buffer base:0x4b800000 size:12288 offset:1507328 fd:196
10-11 23:50:52.379: D/memalloc(1491): /dev/pmem: Freeing buffer base:0x4b970000 size:12288 offset:1507328 fd:196
10-11 23:50:52.379: D/memalloc(1491): /dev/pmem: Freeing buffer base:0x4b930000 size:12288 offset:1245184 fd:230
10-11 23:50:52.529: I/IdleService(1491): Get idle time: time since reset 880 msec
10-11 23:50:52.529: I/IdleService(1491): Idle timer callback: current idle time 880 msec
10-11 23:50:52.529: I/IdleService(1491): next timeout 1350024652655288 usec (119 msec from now)
10-11 23:50:52.529: I/IdleService(1491): SetTimerExpiryIfBefore: next timeout 1350024652655288 usec
10-11 23:50:52.529: I/IdleService(1491): reset timer expiry from 0 usec to 1350024652665288 usec
10-11 23:50:52.659: I/IdleService(1491): Get idle time: time since reset 1009 msec
10-11 23:50:52.659: I/IdleService(1491): Idle timer callback: current idle time 1009 msec
10-11 23:50:52.659: I/IdleService(1491): next timeout 1350024951655288 usec (298990 msec from now)
10-11 23:50:52.659: I/IdleService(1491): SetTimerExpiryIfBefore: next timeout 1350024951655288 usec
10-11 23:50:52.659: I/IdleService(1491): reset timer expiry from 0 usec to 1350024951665288 usec
10-11 23:50:52.659: I/IdleService(1491): Idle timer callback: tell observer 47fe1670 user is idle
10-11 23:50:52.659: I/IdleService(1491): Get idle time: time since reset 1010 msec
10-11 23:51:01.429: I/IdleService(1491): next timeout 1350024662432218 usec (999 msec from now)
10-11 23:51:01.429: I/IdleService(1491): SetTimerExpiryIfBefore: next timeout 1350024662432218 usec
10-11 23:51:01.429: I/IdleService(1491): reset timer expiry from 1350024951665288 usec to 1350024662442218 usec
10-11 23:51:01.429: I/IdleService(1491): Reset idle timeout: tell observer 47fe1670 user is back
10-11 23:51:01.579: I/GeckoDump(1491): XXX FIXME : Got a mozContentEvent: update-prompt-apply-result
10-11 23:51:01.599: D/memalloc(1491): /dev/pmem: Freeing buffer base:0x4bf6e000 size:614400 offset:7790592 fd:217
10-11 23:51:01.609: D/memalloc(1491): /dev/pmem: Freeing buffer base:0x4bed8000 size:614400 offset:7176192 fd:197
10-11 23:51:02.439: I/IdleService(1491): Get idle time: time since reset 864 msec
10-11 23:51:02.439: I/IdleService(1491): Idle timer callback: current idle time 864 msec
10-11 23:51:02.439: I/IdleService(1491): next timeout 1350024662579144 usec (135 msec from now)
10-11 23:51:02.439: I/IdleService(1491): SetTimerExpiryIfBefore: next timeout 1350024662579144 usec
10-11 23:51:02.439: I/IdleService(1491): reset timer expiry from 0 usec to 1350024662589144 usec
10-11 23:51:02.579: I/IdleService(1491): Get idle time: time since reset 1010 msec
10-11 23:51:02.579: I/IdleService(1491): Idle timer callback: current idle time 1010 msec
10-11 23:51:02.579: I/IdleService(1491): next timeout 1350024961579144 usec (298989 msec from now)
10-11 23:51:02.579: I/IdleService(1491): SetTimerExpiryIfBefore: next timeout 1350024961579144 usec
10-11 23:51:02.579: I/IdleService(1491): reset timer expiry from 0 usec to 1350024961589144 usec
10-11 23:51:02.579: I/IdleService(1491): Idle timer callback: tell observer 47fe1670 user is idle
10-11 23:51:02.579: I/IdleService(1491): Get idle time: time since reset 1011 msec

Repro:
1. load the 10-11-2012 daily Unagi buid
2. force an OTA update using https://gist.github.com/7acb26790bf3dd0bd71e
3. wait ~2 minutes and the phone will begin downloading the update
4. When the update is found, apply the update and watch the download happen in logcat
5. When Files are successfully downloaded, a dialog pops up asking to apply the update and restart
6. CLick restart
7. Verify the dialog just exits back to the homescreen, and no update is ever applied.

Expected:
- update applied, and restart happens with the new build

Actual:
- no update applied.

Comment 1

[Marshall Culpepper [:marshall_law]]

This should be fixed when the patch for forcing update checks lands:
https://bugzilla.mozilla.org/show_bug.cgi?id=798948

Comment 2

[Andreas Gal :gal]

Was this fixed?

Comment 3

[Alex Keybl [:akeybl]]

(In reply to Andreas Gal :gal from comment #2)
> Was this fixed?

qawanted for Comment 2

Comment 4

[Tony Chung [:tchung]]

Verified fix on 10-15-2012 unagi 3 build.  install now button reboots and applies the update.

Comment 5

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

We're fixed, removing qawanted